[PATCH] Update git-clone documentation

[git.git] / sha1_name.c

diff --git a/sha1_name.c b/sha1_name.c
index 133af3b..57e6cd3 100644 (file)
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -84,19 +84,19 @@ static int find_short_packed_object(int len, const unsigned char *match, unsigne
        return 0;
 }
 
-static int get_short_sha1(const char *name, unsigned char *sha1)
+static int get_short_sha1(const char *name, int len, unsigned char *sha1)
 {
        int i;
        char canonical[40];
        unsigned char res[20];
 
+       if (len < 4)
+               return -1;
        memset(res, 0, 20);
        memset(canonical, 'x', 40);
-       for (i = 0;;i++) {
+       for (i = 0; i < len ;i++) {
                unsigned char c = name[i];
                unsigned char val;
-               if (!c || i > 40)
-                       break;
                if (c >= '0' && c <= '9')
                        val = c - '0';
                else if (c >= 'a' && c <= 'f')
@@ -112,8 +112,6 @@ static int get_short_sha1(const char *name, unsigned char *sha1)
                        val <<= 4;
                res[i >> 1] |= val;
        }
-       if (i < 4)
-               return -1;
        if (find_short_object_filename(i, canonical, sha1))
                return 0;
        if (find_short_packed_object(i, res, sha1))
@@ -121,21 +119,6 @@ static int get_short_sha1(const char *name, unsigned char *sha1)
        return -1;
 }
 
-static int get_sha1_file(const char *path, unsigned char *result)
-{
-       char buffer[60];
-       int fd = open(path, O_RDONLY);
-       int len;
-
-       if (fd < 0)
-               return -1;
-       len = read(fd, buffer, sizeof(buffer));
-       close(fd);
-       if (len < 40)
-               return -1;
-       return get_sha1_hex(buffer, result);
-}
-
 static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
 {
        static const char *prefix[] = {
@@ -152,7 +135,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
 
        for (p = prefix; *p; p++) {
                char *pathname = git_path("%s/%.*s", *p, len, str);
-               if (!get_sha1_file(pathname, sha1))
+               if (!read_ref(pathname, sha1))
                        return 0;
        }
 
@@ -254,7 +237,7 @@ static int get_sha1_1(const char *name, int len, unsigned char *sha1)
        ret = get_sha1_basic(name, len, sha1);
        if (!ret)
                return 0;
-       return get_short_sha1(name, sha1);
+       return get_short_sha1(name, len, sha1);
 }
 
 /*