git-fetch-pack: really do not ask for funny refs

[git.git] / sha1_name.c

diff --git a/sha1_name.c b/sha1_name.c
index 75c688e..b13ed78 100644 (file)
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -188,7 +188,10 @@ const char *find_unique_abbrev(const unsigned char *sha1, int len)
 {
        int status;
        static char hex[41];
+
        memcpy(hex, sha1_to_hex(sha1), 40);
+       if (len == 40)
+               return hex;
        while (len < 40) {
                unsigned char sha1_ret[20];
                status = get_short_sha1(hex, len, sha1_ret, 1);
@@ -203,6 +206,31 @@ const char *find_unique_abbrev(const unsigned char *sha1, int len)
        return NULL;
 }
 
+static int ambiguous_path(const char *path, int len)
+{
+       int slash = 1;
+       int cnt;
+
+       for (cnt = 0; cnt < len; cnt++) {
+               switch (*path++) {
+               case '\0':
+                       break;
+               case '/':
+                       if (slash)
+                               break;
+                       slash = 1;
+                       continue;
+               case '.':
+                       continue;
+               default:
+                       slash = 0;
+                       continue;
+               }
+               break;
+       }
+       return slash;
+}
+
 static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
 {
        static const char *prefix[] = {
@@ -217,12 +245,15 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
        if (len == 40 && !get_sha1_hex(str, sha1))
                return 0;
 
+       /* Accept only unambiguous ref paths. */
+       if (ambiguous_path(str, len))
+               return -1;
+
        for (p = prefix; *p; p++) {
                char *pathname = git_path("%s/%.*s", *p, len, str);
                if (!read_ref(pathname, sha1))
                        return 0;
        }
-
        return -1;
 }
 
@@ -322,7 +353,9 @@ static int peel_onion(const char *name, int len, unsigned char *sha1)
        if (!o)
                return -1;
        if (!type_string) {
-               o = deref_tag(o);
+               o = deref_tag(o, name, sp - name - 2);
+               if (!o || (!o->parsed && !parse_object(o->sha1)))
+                       return -1;
                memcpy(sha1, o->sha1, 20);
        }
        else {
@@ -332,7 +365,7 @@ static int peel_onion(const char *name, int len, unsigned char *sha1)
                 */
 
                while (1) {
-                       if (!o)
+                       if (!o || (!o->parsed && !parse_object(o->sha1)))
                                return -1;
                        if (o->type == type_string) {
                                memcpy(sha1, o->sha1, 20);