* rrd_open: rrd_close does not purge file from cache
[rrdtool.git] / src / rrd_open.c
index 4b9a0f9..d701204 100644 (file)
@@ -11,7 +11,7 @@
 #define MEMBLK 8192
 
 /* DEBUG 2 prints information obtained via mincore(2) */
-// #define DEBUG 2
+//#define DEBUG 2
 /* do not calculate exact madvise hints but assume 1 page for headers and
  * set DONTNEED for the rest, which is assumed to be data */
 //#define ONE_PAGE 1
        offset += read (rrd_file->fd, dst, sizeof(dst_t)*(cnt))
 #endif
 
-/* next page-aligned (i.e. page-align up) */
-#ifndef PAGE_ALIGN
-#define PAGE_ALIGN(addr) (((addr)+_page_size-1)&(~(_page_size-1)))
-#endif
-/* previous page-aligned (i.e. page-align down) */
-#ifndef PAGE_ALIGN_DOWN
-#define PAGE_ALIGN_DOWN(addr) (((addr)+_page_size-1)&(~(_page_size-1)))
+/* get the address of the start of this page */
+#ifndef PAGE_START
+#define PAGE_START(addr) ((addr)&(~(_page_size-1)))
 #endif
 
 #ifdef HAVE_MMAP
@@ -90,6 +86,8 @@ rrd_file_t *rrd_open(
     off_t     newfile_size = 0;
 
     if (rdwr & RRD_CREAT) {
+        /* yes bad inline signaling alert, we are using the
+           floatcookie to pass the size in ... only used in resize */
         newfile_size = (off_t) rrd->stat_head->float_cookie;
         free(rrd->stat_head);
     }
@@ -211,11 +209,9 @@ rrd_file_t *rrd_open(
     } else {
 # ifndef ONE_PAGE
         /* We do not need to read anything in for the moment */
-        _madvise(data, rrd_file->file_len, MADV_DONTNEED);
+        _madvise(data, rrd_file->file_len, MADV_RANDOM);
         /* the stat_head will be needed soonish, so hint accordingly */
-        _madvise(data + PAGE_ALIGN_DOWN(offset),
-                 PAGE_ALIGN(sizeof(stat_head_t)),
-                 MADV_WILLNEED | MADV_RANDOM);
+        _madvise(data, sizeof(stat_head_t), MADV_WILLNEED | MADV_RANDOM);
 
 # else
 /* alternatively: keep 1 page worth of data, likely headers,
@@ -250,8 +246,8 @@ rrd_file_t *rrd_open(
     }
 #if defined USE_MADVISE && !defined ONE_PAGE
     /* the ds_def will be needed soonish, so hint accordingly */
-    _madvise(data + PAGE_ALIGN_DOWN(offset),
-             PAGE_ALIGN(sizeof(ds_def_t) * rrd->stat_head->ds_cnt),
+    _madvise(data + PAGE_START(offset),
+             sizeof(ds_def_t) * rrd->stat_head->ds_cnt,
              MADV_WILLNEED);
 #endif
     __rrd_read(rrd->ds_def, ds_def_t,
@@ -259,8 +255,8 @@ rrd_file_t *rrd_open(
 
 #if defined USE_MADVISE && !defined ONE_PAGE
     /* the rra_def will be needed soonish, so hint accordingly */
-    _madvise(data + PAGE_ALIGN_DOWN(offset),
-             PAGE_ALIGN(sizeof(rra_def_t) * rrd->stat_head->rra_cnt),
+    _madvise(data + PAGE_START(offset),
+             sizeof(rra_def_t) * rrd->stat_head->rra_cnt,
              MADV_WILLNEED);
 #endif
     __rrd_read(rrd->rra_def, rra_def_t,
@@ -283,8 +279,8 @@ rrd_file_t *rrd_open(
     } else {
 #if defined USE_MADVISE && !defined ONE_PAGE
         /* the live_head will be needed soonish, so hint accordingly */
-        _madvise(data + PAGE_ALIGN_DOWN(offset),
-                 PAGE_ALIGN(sizeof(live_head_t)), MADV_WILLNEED);
+        _madvise(data + PAGE_START(offset),
+                 sizeof(live_head_t), MADV_WILLNEED);
 #endif
         __rrd_read(rrd->live_head, live_head_t,
                    1);
@@ -316,19 +312,13 @@ rrd_file_t *rrd_open(
 
 
 /* Close a reference to an rrd_file.  */
-
-int rrd_close(
-    rrd_file_t *rrd_file)
-{
-    int       ret;
-
-#if defined HAVE_MMAP || defined DEBUG
-    ssize_t   _page_size = sysconf(_SC_PAGESIZE);
-#endif
-#if defined DEBUG && DEBUG > 1
+static
+void mincore_print(rrd_file_t *rrd_file,char * mark){
+#ifdef HAVE_MMAP
     /* pretty print blocks in core */
     off_t     off;
     unsigned char *vec;
+    ssize_t   _page_size = sysconf(_SC_PAGESIZE);
 
     off = rrd_file->file_len +
         ((rrd_file->file_len + _page_size - 1) / _page_size);
@@ -344,35 +334,79 @@ int rrd_close(
                 if (off == 0)
                     was_in = is_in;
                 if (was_in != is_in) {
-                    fprintf(stderr, "%sin core: %p len %ld\n",
+                    fprintf(stderr, "%s: %sin core: %p len %ld\n",mark,
                             was_in ? "" : "not ", vec + prev, off - prev);
                     was_in = is_in;
                     prev = off;
                 }
             }
             fprintf(stderr,
-                    "%sin core: %p len %ld\n",
+                    "%s: %sin core: %p len %ld\n", mark,
                     was_in ? "" : "not ", vec + prev, off - prev);
         } else
             fprintf(stderr, "mincore: %s", rrd_strerror(errno));
     }
-#endif                          /* DEBUG */
+#else
+  fprintf(stderr, "sorry mincore only works with mmap");
+#endif
+}
+
+
+/* drop cache except for the header and the active pages */
+void
+rrd_dontneed (
+    rrd_file_t *rrd_file,
+    rrd_t *rrd){
+    unsigned long      dontneed_start;
+    unsigned long      rra_start;
+    unsigned long      active_block;
+    unsigned long      i;
+    ssize_t   _page_size = sysconf(_SC_PAGESIZE);
+
+#if defined DEBUG && DEBUG > 1
+    mincore_print(rrd_file,"before");
+#endif
 
-#ifdef USE_MADVISE
-# ifdef ONE_PAGE
-    /* Keep headers around, round up to next page boundary.  */
-    ret =
-        PAGE_ALIGN(rrd_file->header_len % _page_size + rrd_file->header_len);
-    if (rrd_file->file_len > ret)
-        _madvise(rrd_file->file_start + ret,
-                 rrd_file->file_len - ret, MADV_DONTNEED);
-# else
     /* ignoring errors from RRDs that are smaller then the file_len+rounding */
-    _madvise(rrd_file->file_start + PAGE_ALIGN_DOWN(rrd_file->header_len),
-             rrd_file->file_len - PAGE_ALIGN(rrd_file->header_len),
+    rra_start = rrd_file->header_len;
+    dontneed_start = PAGE_START(rra_start)+_page_size;
+    for (i = 0; i < rrd->stat_head->rra_cnt; ++i) {
+       active_block =
+              PAGE_START(rra_start
+                         + rrd->rra_ptr[i].cur_row 
+                         * rrd->stat_head->ds_cnt 
+                         * sizeof(rrd_value_t));
+       if (active_block > dontneed_start){
+#ifdef USE_MADVISE
+           _madvise(rrd_file->file_start + dontneed_start,
+                   active_block-dontneed_start-1,
+                   MADV_DONTNEED);
+#endif
+/* in linux at least only fadvise DONTNEED seems to purge pages from cache */
+#ifdef HAVE_POSIX_FADVISE
+            posix_fadvise(rrd_file->fd, dontneed_start, active_block-dontneed_start-1, POSIX_FADV_DONTNEED);
+#endif
+       }
+       dontneed_start = active_block + _page_size;
+       rra_start += rrd->rra_def[i].row_cnt * rrd->stat_head->ds_cnt * sizeof(rrd_value_t);
+    }
+#ifdef USE_MADVISE
+    _madvise(rrd_file->file_start + dontneed_start,
+             rrd_file->file_len - dontneed_start,
              MADV_DONTNEED);
-# endif
 #endif
+#ifdef HAVE_POSIX_FADVISE
+    posix_fadvise(rrd_file->fd, dontneed_start, rrd_file->file_len-dontneed_start, POSIX_FADV_DONTNEED);
+#endif
+#if defined DEBUG && DEBUG > 1
+    mincore_print(rrd_file,"after");
+#endif
+}
+
+int rrd_close(
+    rrd_file_t *rrd_file)
+{
+    int       ret;
 #ifdef HAVE_MMAP
     ret = munmap(rrd_file->file_start, rrd_file->file_len);
     if (ret != 0)