safe_fgets() - even more anal fgets()

[git.git] / upload-pack.c

diff --git a/upload-pack.c b/upload-pack.c
index c5eff21..3606529 100644 (file)
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -4,6 +4,7 @@
 #include "tag.h"
 #include "object.h"
 #include "commit.h"
+#include "exec_cmd.h"
 
 static const char upload_pack_usage[] = "git-upload-pack [--strict] [--timeout=nn] <dir>";
 
@@ -60,7 +61,7 @@ static void create_pack_file(void)
                close(0);
                close(fd[0]);
                close(fd[1]);
-               *p++ = "git-rev-list";
+               *p++ = "rev-list";
                *p++ = "--objects";
                if (create_full_pack || MAX_NEEDS <= nr_needs)
                        *p++ = "--all";
@@ -79,13 +80,13 @@ static void create_pack_file(void)
                                buf += 41;
                        }
                *p++ = NULL;
-               execvp("git-rev-list", argv);
+               execv_git_cmd(argv);
                die("git-upload-pack: unable to exec git-rev-list");
        }
        dup2(fd[0], 0);
        close(fd[0]);
        close(fd[1]);
-       execlp("git-pack-objects", "git-pack-objects", "--stdout", NULL);
+       execl_git_cmd("pack-objects", "--stdout", NULL);
        die("git-upload-pack: unable to exec git-pack-objects");
 }
 
@@ -215,6 +216,9 @@ static int send_ref(const char *refname, const unsigned char *sha1)
        static char *capabilities = "multi_ack";
        struct object *o = parse_object(sha1);
 
+       if (!o)
+               die("git-upload-pack: cannot find object %s:", sha1_to_hex(sha1));
+
        if (capabilities)
                packet_write(1, "%s %s%c%s\n", sha1_to_hex(sha1), refname,
                        0, capabilities);
@@ -226,7 +230,7 @@ static int send_ref(const char *refname, const unsigned char *sha1)
                nr_our_refs++;
        }
        if (o->type == tag_type) {
-               o = deref_tag(o);
+               o = deref_tag(o, refname, 0);
                packet_write(1, "%s %s^{}\n", sha1_to_hex(o->sha1), refname);
        }
        return 0;
@@ -248,7 +252,7 @@ static int upload_pack(void)
 
 int main(int argc, char **argv)
 {
-       const char *dir;
+       char *dir;
        int i;
        int strict = 0;
 
@@ -275,18 +279,9 @@ int main(int argc, char **argv)
                usage(upload_pack_usage);
        dir = argv[i];
 
-       /* chdir to the directory. If that fails, try appending ".git" */
-       if (chdir(dir) < 0) {
-               if (strict || chdir(mkpath("%s.git", dir)) < 0)
-                       die("git-upload-pack unable to chdir to %s", dir);
-       }
-       if (!strict)
-               chdir(".git");
-
-       if (access("objects", X_OK) || access("refs", X_OK))
-               die("git-upload-pack: %s doesn't seem to be a git archive", dir);
+       if (!enter_repo(dir, strict))
+               die("'%s': unable to chdir or not a git archive", dir);
 
-       putenv("GIT_DIR=.");
        upload_pack();
        return 0;
 }