Mark the variable declarations in .h files as extern

[git.git] / write-tree.c

diff --git a/write-tree.c b/write-tree.c
index bb7ceed..d801d7f 100644 (file)
--- a/write-tree.c
+++ b/write-tree.c
@@ -26,11 +26,11 @@ static int write_tree(struct cache_entry **cachep, int maxentries, const char *b
 
        /* Guess at some random initial size */
        size = 8192;
-       buffer = malloc(size);
+       buffer = xmalloc(size);
        offset = 0;
 
        nr = 0;
-       do {
+       while (nr < maxentries) {
                struct cache_entry *ce = cachep[nr];
                const char *pathname = ce->name, *filename, *dirname;
                int pathlen = ce_namelen(ce), entrylen;
@@ -68,14 +68,14 @@ static int write_tree(struct cache_entry **cachep, int maxentries, const char *b
                entrylen = pathlen - baselen;
                if (offset + entrylen + 100 > size) {
                        size = alloc_nr(offset + entrylen + 100);
-                       buffer = realloc(buffer, size);
+                       buffer = xrealloc(buffer, size);
                }
                offset += sprintf(buffer + offset, "%o %.*s", mode, entrylen, filename);
                buffer[offset++] = 0;
                memcpy(buffer + offset, sha1, 20);
                offset += 20;
                nr++;
-       } while (nr < maxentries);
+       }
 
        write_sha1_file(buffer, offset, "tree", returnsha1);
        free(buffer);
@@ -88,8 +88,8 @@ int main(int argc, char **argv)
        int entries = read_cache();
        unsigned char sha1[20];
 
-       if (entries <= 0)
-               die("write-tree: no cache contents to write");
+       if (entries < 0)
+               die("write-tree: error reading cache");
 
        /* Verify that the tree is merged */
        unmerged = 0;