X-Git-Url: https://git.octo.it/?a=blobdiff_plain;ds=sidebyside;f=fsck-objects.c;h=65cec7d12b6fecc95e842069d2afa1e87bceebc1;hb=e11fc02066435b0f370d639e665ec70680e876a6;hp=6cb0f29be8a1eed5c22c90894560e399aa537f56;hpb=0493a3fd5204a36bc961a8611770ddb9ec1ed8ed;p=git.git diff --git a/fsck-objects.c b/fsck-objects.c index 6cb0f29b..65cec7d1 100644 --- a/fsck-objects.c +++ b/fsck-objects.c @@ -30,7 +30,7 @@ static void objreport(struct object *obj, const char *severity, fputs("\n", stderr); } -int objerror(struct object *obj, const char *err, ...) +static int objerror(struct object *obj, const char *err, ...) { va_list params; va_start(params, err); @@ -39,7 +39,7 @@ int objerror(struct object *obj, const char *err, ...) return -1; } -int objwarning(struct object *obj, const char *err, ...) +static int objwarning(struct object *obj, const char *err, ...) { va_list params; va_start(params, err); @@ -402,28 +402,17 @@ static void fsck_object_dir(const char *path) static int fsck_head_link(void) { - int fd, count; - char hex[40]; unsigned char sha1[20]; - static char path[PATH_MAX], link[PATH_MAX]; - const char *git_dir; - - git_dir = getenv(GIT_DIR_ENVIRONMENT); - if (!git_dir) git_dir = DEFAULT_GIT_DIR_ENVIRONMENT; - - snprintf(path, sizeof(path), "%s/HEAD", git_dir); - if (readlink(path, link, sizeof(link)) < 0) - return error("HEAD is not a symlink"); - if (strncmp("refs/heads/", link, 11)) - return error("HEAD points to something strange (%s)", link); - fd = open(path, O_RDONLY); - if (fd < 0) - return error("HEAD: %s", strerror(errno)); - count = read(fd, hex, sizeof(hex)); - close(fd); - if (count < 0) - return error("HEAD: %s", strerror(errno)); - if (count < 40 || get_sha1_hex(hex, sha1)) + const char *git_HEAD = strdup(git_path("HEAD")); + const char *git_refs_heads_master = resolve_ref(git_HEAD, sha1, 1); + int pfxlen = strlen(git_HEAD) - 4; /* strip .../.git/ part */ + + if (!git_refs_heads_master) + return error("HEAD is not a symbolic ref"); + if (strncmp(git_refs_heads_master + pfxlen, "refs/heads/", 11)) + return error("HEAD points to something strange (%s)", + git_refs_heads_master + pfxlen); + if (!memcmp(null_sha1, sha1, 20)) return error("HEAD: not a valid git pointer"); return 0; }