X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=CONTRIBUTING.md;h=eeb174ba2989f27fe02369542f9b464c9867c10b;hb=24bdf52decaf93359aab0364fb11420af5cd4a21;hp=74dd42ecb9788f818b1975435f56196b7a254109;hpb=3447f33dee731225f1951e9ede81a55677242ef2;p=collectd.git diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 74dd42ec..eeb174ba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,9 +11,10 @@ Issues](https://github.com/collectd/collectd/issues). Try to answer the following questions: * Which version of *collectd* are you using? -* How can we reproduce the problem you're having? +* Which operating system (distribution) are you using at which version? * What is the expected behavior / output? * What is the actual (observed) behavior / output? +* How can we reproduce the problem you're having? * If *collectd* crashes, try to get a [stack trace](https://collectd.org/wiki/index.php/Core_file). @@ -39,10 +40,10 @@ the mailing list have a tendency to fall through the cracks. integration environment will try to build it on a number of platforms. If this reports a failure, please investigate and fix the problem. We will at best do a very casual review for failing PRs. -* *Don't rebase:* Rebasing our branch destroys the review history. If a review +* *Don't rebase:* Rebasing your branch destroys the review history. If a review takes a long time, we may ask you to rebase on a more recent *master*, but please don't do it without being asked. -* *types.db:* One of the most common mistakes done by new contributors is the +* *types.db:* One of the most common mistakes made by new contributors is the addition of (many) new *types* in the file `src/types.db`. The majority of usecases can be met with one of the existing entries. If you plan to add new entries to `src/types.db`, you should talk to us early in the design