X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fcollectd-nagios.c;h=0c480a06ea90fe5a823bc2d77b31fd1338ccb8c7;hb=3602864950048219eb2981be13d902cc60117da2;hp=4e4e494c1981bb198a8aeb43099fc9e15b5fdf59;hpb=19d94267852103c952ab33e8e6a577cbc827635d;p=collectd.git

diff --git a/src/collectd-nagios.c b/src/collectd-nagios.c
index 4e4e494c..0c480a06 100644
--- a/src/collectd-nagios.c
+++ b/src/collectd-nagios.c
@@ -19,37 +19,19 @@
  *   Florian octo Forster <octo at verplant.org>
  **/
 
-/* Set to C99 and POSIX code */
-#ifndef _ISOC99_SOURCE
-# define _ISOC99_SOURCE
-#endif
-#ifndef _POSIX_SOURCE
-# define _POSIX_SOURCE
-#endif
-#ifndef _POSIX_C_SOURCE
-# define _POSIX_C_SOURCE 200112L
-#endif
-#ifndef _REENTRANT
-# define _REENTRANT
+#if HAVE_CONFIG_H
+# include "config.h"
 #endif
 
-/* Disable non-standard extensions */
-#ifdef _BSD_SOURCE
-# undef _BSD_SOURCE
-#endif
-#ifdef _SVID_SOURCE
-# undef _SVID_SOURCE
-#endif
-#ifdef _GNU_SOURCE
-# undef _GNU_SOURCE
-#endif
+/* Set to C99 and POSIX code */
+#if COLLECT_STANDARDS
+# include "standards.h"
+#endif /* COLLECT_STANDARDS */
 
 #if !defined(__GNUC__) || !__GNUC__
 # define __attribute__(x) /**/
 #endif
 
-#include "config.h"
-
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdio.h>
@@ -165,7 +147,7 @@ static int filter_ds (size_t *values_num,
 		return (RET_UNKNOWN);
 	}
 
-	for (i = 0; i < match_ds_num_g; i++)
+	for (i = 0; i < (size_t) match_ds_num_g; i++)
 	{
 		size_t j;
 
@@ -298,7 +280,7 @@ static int do_check_con_none (size_t values_num,
 	int num_okay = 0;
 	const char *status_str = "UNKNOWN";
 	int status_code = RET_UNKNOWN;
-	int i;
+	size_t i;
 
 	for (i = 0; i < values_num; i++)
 	{
@@ -349,7 +331,7 @@ static int do_check_con_none (size_t values_num,
 static int do_check_con_average (size_t values_num,
 		double *values, char **values_names)
 {
-	int i;
+	size_t i;
 	double total;
 	int total_num;
 	double average;
@@ -402,7 +384,7 @@ static int do_check_con_average (size_t values_num,
 static int do_check_con_sum (size_t values_num,
 		double *values, char **values_names)
 {
-	int i;
+	size_t i;
 	double total;
 	int total_num;
 	const char *status_str = "UNKNOWN";
@@ -452,7 +434,7 @@ static int do_check_con_sum (size_t values_num,
 static int do_check_con_percentage (size_t values_num,
 		double *values, char **values_names)
 {
-	int i;
+	size_t i;
 	double sum = 0.0;
 	double percentage;
 
@@ -617,7 +599,11 @@ int main (int argc, char **argv)
 				else if (strcasecmp (optarg, "percentage") == 0)
 					consolitation_g = CON_PERCENTAGE;
 				else
+				{
+					fprintf (stderr, "Unknown consolidation function `%s'.\n",
+							optarg);
 					usage (argv[0]);
+				}
 				break;
 			case 'd':
 			{
@@ -649,7 +635,10 @@ int main (int argc, char **argv)
 
 	if ((socket_file_g == NULL) || (value_string_g == NULL)
 			|| (hostname_g == NULL))
+	{
+		fprintf (stderr, "Missing required arguments.\n");
 		usage (argv[0]);
+	}
 
 	return (do_check ());
 } /* int main */