X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fcpu.c;h=d48ab886332912a1c09e62c477d0048209dc9ab6;hb=5fbface07644e941cb7b2bebeeeabb9b055ceab0;hp=cdacf4297d651c88b1253578c731b94845ccb0a0;hpb=f00e980cf98776b10c582c3a0fb9924a3f332ba7;p=collectd.git diff --git a/src/cpu.c b/src/cpu.c index cdacf429..d48ab886 100644 --- a/src/cpu.c +++ b/src/cpu.c @@ -644,7 +644,6 @@ static int cpu_read(void) { char *fields[11]; int numfields; - long long user_value, nice_value, value; if ((fh = fopen("/proc/stat", "r")) == NULL) { char errbuf[1024]; @@ -666,8 +665,8 @@ static int cpu_read(void) { cpu = atoi(fields[0] + 3); /* Do not stage User and Nice immediately: we may need to alter them later: */ - user_value = atoll(fields[1]); - nice_value = atoll(fields[2]); + long long user_value = atoll(fields[1]); + long long nice_value = atoll(fields[2]); cpu_stage(cpu, COLLECTD_CPU_STATE_SYSTEM, (derive_t)atoll(fields[3]), now); cpu_stage(cpu, COLLECTD_CPU_STATE_IDLE, (derive_t)atoll(fields[4]), now); @@ -677,40 +676,37 @@ static int cpu_read(void) { now); cpu_stage(cpu, COLLECTD_CPU_STATE_SOFTIRQ, (derive_t)atoll(fields[7]), now); + } - if (numfields >= 9) { - cpu_stage(cpu, COLLECTD_CPU_STATE_STEAL, (derive_t)atoll(fields[8]), - now); - - if (numfields >= 10) { /* Guest (since Linux 2.6.24) */ - if (report_guest) { - value = atoll(fields[9]); - cpu_stage(cpu, COLLECTD_CPU_STATE_GUEST, - (derive_t)value, now); - /* Guest is included in User; optionally subtract Guest from - User: */ - if (subtract_guest) { - user_value -= value; - if (user_value < 0) user_value = 0; - } - } - - if (numfields >= 11) { /* Guest_nice (since Linux 2.6.33) */ - if (report_guest) { - value = atoll(fields[10]); - cpu_stage(cpu, COLLECTD_CPU_STATE_GUEST_NICE, - (derive_t)value, now); - /* Guest_nice is included in Nice; optionally subtract - Guest_nice from Nice: */ - if (subtract_guest) { - nice_value -= value; - if (nice_value < 0) nice_value = 0; - } - } - } + if (numfields >= 9) { /* Steal (since Linux 2.6.11) */ + cpu_stage(cpu, COLLECTD_CPU_STATE_STEAL, (derive_t)atoll(fields[8]), now); + } + + if (numfields >= 10) { /* Guest (since Linux 2.6.24) */ + if (report_guest) { + long long value = atoll(fields[9]); + cpu_stage(cpu, COLLECTD_CPU_STATE_GUEST, (derive_t)value, now); + /* Guest is included in User; optionally subtract Guest from User: */ + if (subtract_guest) { + user_value -= value; + if (user_value < 0) user_value = 0; } } } + + if (numfields >= 11) { /* Guest_nice (since Linux 2.6.33) */ + if (report_guest) { + long long value = atoll(fields[10]); + cpu_stage(cpu, COLLECTD_CPU_STATE_GUEST_NICE, (derive_t)value, now); + /* Guest_nice is included in Nice; optionally subtract Guest_nice from + Nice: */ + if (subtract_guest) { + nice_value -= value; + if (nice_value < 0) nice_value = 0; + } + } + } + /* Eventually stage User and Nice: */ cpu_stage(cpu, COLLECTD_CPU_STATE_USER, (derive_t)user_value, now); cpu_stage(cpu, COLLECTD_CPU_STATE_NICE, (derive_t)nice_value, now);