X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fcpufreq.c;h=f95b2828a5246806476fc3626809b4457692683c;hb=d93c31e59d1bbb5ed8c2ef624ef8ffa800bc5961;hp=b967042eeb04765f23fe88037fb689a4fbf0c0c8;hpb=12bc586750e4772a8dd70a454db982b949c6de4b;p=collectd.git diff --git a/src/cpufreq.c b/src/cpufreq.c index b967042e..f95b2828 100644 --- a/src/cpufreq.c +++ b/src/cpufreq.c @@ -22,9 +22,15 @@ #include "collectd.h" -#include "common.h" #include "plugin.h" +#include "utils/common/common.h" +#if KERNEL_FREEBSD +#include +#include +#endif + +#if KERNEL_LINUX #define MAX_AVAIL_FREQS 20 static int num_cpu; @@ -33,48 +39,57 @@ struct cpu_data_t { value_to_rate_state_t time_state[MAX_AVAIL_FREQS]; } * cpu_data; -/* Flags denoting capability of reporting stats. */ -unsigned report_time_in_state, report_total_trans; +/* Flags denoting capability of reporting CPU frequency statistics. */ +static bool report_p_stats = false; -static int counter_init(void) { - cpu_data = calloc(num_cpu, sizeof(struct cpu_data_t)); +static void cpufreq_stats_init(void) { + cpu_data = calloc(num_cpu, sizeof(*cpu_data)); if (cpu_data == NULL) - return 0; + return; - report_time_in_state = 1; - report_total_trans = 1; + report_p_stats = true; /* Check for stats module and disable if not present. */ for (int i = 0; i < num_cpu; i++) { char filename[PATH_MAX]; - int status = snprintf(filename, sizeof(filename), - "/sys/devices/system/cpu/cpu%d/cpufreq/" - "stats/time_in_state", - num_cpu); - if ((status < 1) || ((unsigned int)status >= sizeof(filename))) - report_time_in_state = 0; - status = snprintf(filename, sizeof(filename), - "/sys/devices/system/cpu/cpu%d/cpufreq/" - "stats/total_transitions", - num_cpu); - if ((status < 1) || ((unsigned int)status >= sizeof(filename))) - report_total_trans = 0; + snprintf(filename, sizeof(filename), + "/sys/devices/system/cpu/cpu%d/cpufreq/stats/time_in_state", i); + if (access(filename, R_OK)) { + NOTICE("cpufreq plugin: File %s not exists or no access. P-State " + "statistics will not be reported. Check if `cpufreq-stats' kernel " + "module is loaded.", + filename); + report_p_stats = false; + break; + } + + snprintf(filename, sizeof(filename), + "/sys/devices/system/cpu/cpu%d/cpufreq/stats/total_trans", i); + if (access(filename, R_OK)) { + NOTICE("cpufreq plugin: File %s not exists or no access. P-State " + "statistics will not be reported. Check if `cpufreq-stats' kernel " + "module is loaded.", + filename); + report_p_stats = false; + break; } } - return 0; + return; } +#endif /* KERNEL_LINUX */ static int cpufreq_init(void) { +#if KERNEL_LINUX char filename[PATH_MAX]; num_cpu = 0; while (1) { int status = snprintf(filename, sizeof(filename), - "/sys/devices/system/cpu/cpu%d/cpufreq/" - "scaling_cur_freq", - num_cpu); + "/sys/devices/system/cpu/cpu%d/cpufreq/" + "scaling_cur_freq", + num_cpu); if ((status < 1) || ((unsigned int)status >= sizeof(filename))) break; @@ -85,10 +100,20 @@ static int cpufreq_init(void) { } INFO("cpufreq plugin: Found %d CPU%s", num_cpu, (num_cpu == 1) ? "" : "s"); - counter_init(); + cpufreq_stats_init(); if (num_cpu == 0) plugin_unregister_read("cpufreq"); +#elif KERNEL_FREEBSD + char mib[] = "dev.cpu.0.freq"; + int cpufreq; + size_t cf_len = sizeof(cpufreq); + + if (sysctlbyname(mib, &cpufreq, &cf_len, NULL, 0) != 0) { + WARNING("cpufreq plugin: sysctl \"%s\" failed.", mib); + plugin_unregister_read("cpufreq"); + } +#endif return 0; } /* int cpufreq_init */ @@ -109,12 +134,84 @@ static void cpufreq_submit(int cpu_num, const char *type, plugin_dispatch_values(&vl); } +#if KERNEL_LINUX +static void cpufreq_read_stats(int cpu) { + char filename[PATH_MAX]; + /* Read total transitions for cpu frequency */ + snprintf(filename, sizeof(filename), + "/sys/devices/system/cpu/cpu%d/cpufreq/stats/total_trans", cpu); + + value_t v; + if (parse_value_file(filename, &v, DS_TYPE_DERIVE) != 0) { + ERROR("cpufreq plugin: Reading \"%s\" failed.", filename); + return; + } + cpufreq_submit(cpu, "transitions", NULL, &v); + + /* Determine percentage time in each state for cpu during previous + * interval. */ + snprintf(filename, sizeof(filename), + "/sys/devices/system/cpu/cpu%d/cpufreq/stats/time_in_state", cpu); + + FILE *fh = fopen(filename, "r"); + if (fh == NULL) { + ERROR("cpufreq plugin: Reading \"%s\" failed.", filename); + return; + } + + int state_index = 0; + cdtime_t now = cdtime(); + char buffer[DATA_MAX_NAME_LEN]; + + while (fgets(buffer, sizeof(buffer), fh) != NULL) { + unsigned int frequency; + unsigned long long time; + + /* + * State time units is 10ms. To get rate of seconds per second + * we have to divide by 100. To get percents we have to multiply it + * by 100 back. So, just use parsed value directly. + */ + if (!sscanf(buffer, "%u%llu", &frequency, &time)) { + ERROR("cpufreq plugin: Reading \"%s\" failed.", filename); + break; + } + + char state[DATA_MAX_NAME_LEN]; + snprintf(state, sizeof(state), "%u", frequency); + + if (state_index >= MAX_AVAIL_FREQS) { + NOTICE("cpufreq plugin: Found too many frequency states (%d > %d). " + "Plugin needs to be recompiled. Please open a bug report for " + "this.", + (state_index + 1), MAX_AVAIL_FREQS); + break; + } + + gauge_t g; + if (value_to_rate(&g, (value_t){.derive = time}, DS_TYPE_DERIVE, now, + &(cpu_data[cpu].time_state[state_index])) == 0) { + /* + * Due to some inaccuracy reported value can be a bit greatrer than 100.1. + * That produces gaps on charts. + */ + if (g > 100.1) + g = 100.1; + cpufreq_submit(cpu, "percent", state, &(value_t){.gauge = g}); + } + state_index++; + } + fclose(fh); +} +#endif /* KERNEL_LINUX */ + static int cpufreq_read(void) { - for (int i = 0; i < num_cpu; i++) { +#if KERNEL_LINUX + for (int cpu = 0; cpu < num_cpu; cpu++) { char filename[PATH_MAX]; /* Read cpu frequency */ snprintf(filename, sizeof(filename), - "/sys/devices/system/cpu/cpu%d/cpufreq/scaling_cur_freq", i); + "/sys/devices/system/cpu/cpu%d/cpufreq/scaling_cur_freq", cpu); value_t v; if (parse_value_file(filename, &v, DS_TYPE_GAUGE) != 0) { @@ -125,57 +222,28 @@ static int cpufreq_read(void) { /* convert kHz to Hz */ v.gauge *= 1000.0; - cpufreq_submit(i, "cpufreq", NULL, &v); - - /* Read total transitions for cpu frequency */ - if (report_total_trans) { - snprintf(filename, sizeof(filename), - "/sys/devices/system/cpu/cpu%d/cpufreq/stats/total_trans", i); - if (parse_value_file(filename, &v, DS_TYPE_COUNTER) != 0) { - WARNING("cpufreq plugin: Reading \"%s\" failed.", filename); - continue; - } - cpufreq_submit(i, "counter", "transitions", &v); - } + cpufreq_submit(cpu, "cpufreq", NULL, &v); - /* - * Determine percentage time in each state for cpu during previous interval. - */ - if (report_time_in_state) { - int j = 0; - cdtime_t now = cdtime(); - char state[DATA_MAX_NAME_LEN]; - - snprintf(filename, sizeof(filename), - "/sys/devices/system/cpu/cpu%d/cpufreq/stats/time_in_state", i); - - FILE *fh = fopen(filename, "r"); - if (fh == NULL) - continue; - - char buffer[DATA_MAX_NAME_LEN]; //128 - - while (fgets(buffer, sizeof(buffer), fh) != NULL) { - unsigned long long time; - if (!sscanf(buffer, "%s%llu", state, &time)) { - WARNING("cpufreq plugin: Reading \"%s\" failed.", filename); - fclose(fh); - return 0; - } - - if (j < MAX_AVAIL_FREQS) { - gauge_t g; - if (value_to_rate(&g, (value_t){.counter = time}, DS_TYPE_COUNTER, now, &cpu_data[i].time_state[j]) != 0) { - continue; - j++; - } - cpufreq_submit(i, "percent", state, &(value_t){.gauge = g}); - } - j++; - } - fclose(fh); - } + if (report_p_stats) + cpufreq_read_stats(cpu); + } +#elif KERNEL_FREEBSD + /* FreeBSD currently only has 1 freq setting. See BUGS in cpufreq(4) */ + char mib[] = "dev.cpu.0.freq"; + int cpufreq; + size_t cf_len = sizeof(cpufreq); + + if (sysctlbyname(mib, &cpufreq, &cf_len, NULL, 0) != 0) { + WARNING("cpufreq plugin: sysctl \"%s\" failed.", mib); + return 0; } + + value_t v; + /* convert Mhz to Hz */ + v.gauge = cpufreq * 1000000.0; + + cpufreq_submit(0, "cpufreq", NULL, &v); +#endif return 0; } /* int cpufreq_read */