X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fcurl_json.c;h=6b8449c9e40a54f3c4e485e23f7d04b7f1a5029f;hb=f8379dd45f4a43595f4027992696ee8d02908bff;hp=a7997907b74d46bd94fa18fff6e436ca4987c006;hpb=59c22282427eb6c38d6651cdaa205533752284cb;p=collectd.git diff --git a/src/curl_json.c b/src/curl_json.c index a7997907..6b8449c9 100644 --- a/src/curl_json.c +++ b/src/curl_json.c @@ -1,7 +1,7 @@ /** * collectd - src/curl_json.c * Copyright (C) 2009 Doug MacEachern - * Copyright (C) 2006-2011 Florian octo Forster + * Copyright (C) 2006-2013 Florian octo Forster * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the @@ -28,7 +28,12 @@ #include "utils_avltree.h" #include "utils_complain.h" +#include +#include +#include + #include + #include #if HAVE_YAJL_YAJL_VERSION_H # include @@ -40,7 +45,7 @@ #define CJ_DEFAULT_HOST "localhost" #define CJ_KEY_MAGIC 0x43484b59UL /* CHKY */ -#define CJ_IS_KEY(key) (key)->magic == CJ_KEY_MAGIC +#define CJ_IS_KEY(key) ((key)->magic == CJ_KEY_MAGIC) #define CJ_ANY "*" #define COUCH_MIN(x,y) ((x) < (y) ? (x) : (y)) @@ -48,10 +53,10 @@ struct cj_key_s; typedef struct cj_key_s cj_key_t; struct cj_key_s /* {{{ */ { + unsigned long magic; char *path; char *type; char *instance; - unsigned long magic; }; /* }}} */ @@ -60,13 +65,17 @@ struct cj_s /* {{{ */ char *instance; char *host; + char *sock; + char *url; char *user; char *pass; char *credentials; - int verify_peer; - int verify_host; + _Bool verify_peer; + _Bool verify_host; char *cacert; + struct curl_slist *headers; + char *post_body; CURL *curl; char curl_errbuf[CURL_ERROR_SIZE]; @@ -80,6 +89,8 @@ struct cj_s /* {{{ */ c_avl_tree_t *tree; cj_key_t *key; }; + _Bool in_array; + int index; char name[DATA_MAX_NAME_LEN]; } state[YAJL_MAX_DEPTH]; }; @@ -92,7 +103,6 @@ typedef unsigned int yajl_len_t; #endif static int cj_read (user_data_t *ud); -static int cj_curl_perform (cj_t *db, CURL *curl); static void cj_submit (cj_t *db, cj_key_t *key, value_t *value); static size_t cj_curl_callback (void *buf, /* {{{ */ @@ -119,16 +129,11 @@ static size_t cj_curl_callback (void *buf, /* {{{ */ return (len); #endif - if (status != yajl_status_ok) - { - unsigned char *msg = - yajl_get_error(db->yajl, 1, (unsigned char *)buf, len); - ERROR ("curl_json plugin: yajl_parse failed: %s", msg); - yajl_free_error(db->yajl, msg); - return (0); /* abort write callback */ - } - - return (len); + unsigned char *msg = yajl_get_error(db->yajl, /* verbose = */ 1, + /* jsonText = */ (unsigned char *) buf, (unsigned int) len); + ERROR ("curl_json plugin: yajl_parse failed: %s", msg); + yajl_free_error(db->yajl, msg); + return (0); /* abort write callback */ } /* }}} size_t cj_curl_callback */ static int cj_get_type (cj_key_t *key) @@ -164,12 +169,44 @@ static int cj_get_type (cj_key_t *key) return ds->ds[0].type; } +static int cj_cb_map_key (void *ctx, const unsigned char *val, + yajl_len_t len); + +static void cj_cb_inc_array_index (void *ctx, _Bool update_key) +{ + cj_t *db = (cj_t *)ctx; + + if (!db->state[db->depth].in_array) + return; + + db->state[db->depth].index++; + + if (update_key) + { + char name[DATA_MAX_NAME_LEN]; + + ssnprintf (name, sizeof (name), "%d", db->state[db->depth].index - 1); + + cj_cb_map_key (ctx, (unsigned char *)name, (yajl_len_t) strlen (name)); + } +} + /* yajl callbacks */ #define CJ_CB_ABORT 0 #define CJ_CB_CONTINUE 1 -/* "number" may not be null terminated, so copy it into a buffer before - * parsing. */ +static int cj_cb_boolean (void * ctx, int boolVal) +{ + cj_cb_inc_array_index (ctx, /* update_key = */ 0); + return (CJ_CB_CONTINUE); +} + +static int cj_cb_null (void * ctx) +{ + cj_cb_inc_array_index (ctx, /* update_key = */ 0); + return (CJ_CB_CONTINUE); +} + static int cj_cb_number (void *ctx, const char *number, yajl_len_t number_len) { @@ -177,41 +214,34 @@ static int cj_cb_number (void *ctx, cj_t *db = (cj_t *)ctx; cj_key_t *key = db->state[db->depth].key; - char *endptr; value_t vt; int type; + int status; - if (key == NULL) - return (CJ_CB_CONTINUE); - + /* Create a null-terminated version of the string. */ memcpy (buffer, number, number_len); buffer[sizeof (buffer) - 1] = 0; - type = cj_get_type (key); - if (type < 0) - return (CJ_CB_CONTINUE); - - endptr = NULL; - errno = 0; - - if (type == DS_TYPE_COUNTER) - vt.counter = (counter_t) strtoull (buffer, &endptr, /* base = */ 0); - else if (type == DS_TYPE_GAUGE) - vt.gauge = (gauge_t) strtod (buffer, &endptr); - else if (type == DS_TYPE_DERIVE) - vt.derive = (derive_t) strtoll (buffer, &endptr, /* base = */ 0); - else if (type == DS_TYPE_ABSOLUTE) - vt.absolute = (absolute_t) strtoull (buffer, &endptr, /* base = */ 0); + if ((key == NULL) || !CJ_IS_KEY (key)) { + if (key != NULL) + NOTICE ("curl_json plugin: Found \"%s\", but the configuration expects" + " a map.", buffer); + cj_cb_inc_array_index (ctx, /* update_key = */ 1); + key = db->state[db->depth].key; + if (key == NULL) { + return (CJ_CB_CONTINUE); + } + } else { - ERROR ("curl_json plugin: Unknown data source type: \"%s\"", key->type); - return (CJ_CB_ABORT); + cj_cb_inc_array_index (ctx, /* update_key = */ 1); } - if ((endptr == &buffer[0]) || (errno != 0)) + type = cj_get_type (key); + status = parse_value (buffer, &vt, type); + if (status != 0) { - NOTICE ("curl_json plugin: Overflow while parsing number. " - "Ignoring this value."); + NOTICE ("curl_json plugin: Unable to parse number: \"%s\"", buffer); return (CJ_CB_CONTINUE); } @@ -219,8 +249,11 @@ static int cj_cb_number (void *ctx, return (CJ_CB_CONTINUE); } /* int cj_cb_number */ -static int cj_cb_map_key (void *ctx, const unsigned char *val, - yajl_len_t len) +/* Queries the key-tree of the parent context for "in_name" and, if found, + * updates the "key" field of the current context. Otherwise, "key" is set to + * NULL. */ +static int cj_cb_map_key (void *ctx, + unsigned char const *in_name, yajl_len_t in_name_len) { cj_t *db = (cj_t *)ctx; c_avl_tree_t *tree; @@ -229,17 +262,32 @@ static int cj_cb_map_key (void *ctx, const unsigned char *val, if (tree != NULL) { - cj_key_t *value; + cj_key_t *value = NULL; char *name; + size_t name_len; + /* Create a null-terminated version of the name. */ name = db->state[db->depth].name; - len = COUCH_MIN(len, sizeof (db->state[db->depth].name)-1); - sstrncpy (name, (char *)val, len+1); - - if (c_avl_get (tree, name, (void *) &value) == 0) - db->state[db->depth].key = value; + name_len = COUCH_MIN ((size_t) in_name_len, + sizeof (db->state[db->depth].name) - 1); + memcpy (name, in_name, name_len); + name[name_len] = 0; + + if (c_avl_get (tree, name, (void *) &value) == 0) { + if (CJ_IS_KEY((cj_key_t*)value)) { + db->state[db->depth].key = value; + } + else { + db->state[db->depth].tree = (c_avl_tree_t*) value; + } + } else if (c_avl_get (tree, CJ_ANY, (void *) &value) == 0) - db->state[db->depth].key = value; + if (CJ_IS_KEY((cj_key_t*)value)) { + db->state[db->depth].key = value; + } + else { + db->state[db->depth].tree = (c_avl_tree_t*) value; + } else db->state[db->depth].key = NULL; } @@ -250,42 +298,17 @@ static int cj_cb_map_key (void *ctx, const unsigned char *val, static int cj_cb_string (void *ctx, const unsigned char *val, yajl_len_t len) { - cj_t *db = (cj_t *)ctx; - c_avl_tree_t *tree; - char *ptr; - - if (db->depth != 1) /* e.g. _all_dbs */ - return (CJ_CB_CONTINUE); - - cj_cb_map_key (ctx, val, len); /* same logic */ - - tree = db->state[db->depth].tree; - - if ((tree != NULL) && (ptr = rindex (db->url, '/'))) - { - char url[PATH_MAX]; - CURL *curl; - - /* url =~ s,[^/]+$,$name, */ - len = (ptr - db->url) + 1; - ptr = url; - sstrncpy (ptr, db->url, sizeof (url)); - sstrncpy (ptr + len, db->state[db->depth].name, sizeof (url) - len); - - curl = curl_easy_duphandle (db->curl); - curl_easy_setopt (curl, CURLOPT_URL, url); - cj_curl_perform (db, curl); - curl_easy_cleanup (curl); - } - return (CJ_CB_CONTINUE); -} + /* Handle the string as if it was a number. */ + return (cj_cb_number (ctx, (const char *) val, len)); +} /* int cj_cb_string */ static int cj_cb_start (void *ctx) { cj_t *db = (cj_t *)ctx; if (++db->depth >= YAJL_MAX_DEPTH) { - ERROR ("curl_json plugin: %s depth exceeds max, aborting.", db->url); + ERROR ("curl_json plugin: %s depth exceeds max, aborting.", + db->url ? db->url : db->sock); return (CJ_CB_ABORT); } return (CJ_CB_CONTINUE); @@ -301,6 +324,7 @@ static int cj_cb_end (void *ctx) static int cj_cb_start_map (void *ctx) { + cj_cb_inc_array_index (ctx, /* update_key = */ 1); return cj_cb_start (ctx); } @@ -311,17 +335,25 @@ static int cj_cb_end_map (void *ctx) static int cj_cb_start_array (void * ctx) { + cj_t *db = (cj_t *)ctx; + cj_cb_inc_array_index (ctx, /* update_key = */ 1); + if (db->depth+1 < YAJL_MAX_DEPTH) { + db->state[db->depth+1].in_array = 1; + db->state[db->depth+1].index = 0; + } return cj_cb_start (ctx); } static int cj_cb_end_array (void * ctx) { + cj_t *db = (cj_t *)ctx; + db->state[db->depth].in_array = 0; return cj_cb_end (ctx); } static yajl_callbacks ycallbacks = { - NULL, /* null */ - NULL, /* boolean */ + cj_cb_null, /* null */ + cj_cb_boolean, /* boolean */ NULL, /* integer */ NULL, /* double */ cj_cb_number, @@ -389,19 +421,28 @@ static void cj_free (void *arg) /* {{{ */ sfree (db->instance); sfree (db->host); + sfree (db->sock); + sfree (db->url); sfree (db->user); sfree (db->pass); sfree (db->credentials); sfree (db->cacert); + sfree (db->post_body); + curl_slist_free_all (db->headers); sfree (db); } /* }}} void cj_free */ /* Configuration handling functions {{{ */ -static int cj_config_add_string (const char *name, char **dest, /* {{{ */ - oconfig_item_t *ci) +static c_avl_tree_t *cj_avl_create(void) +{ + return c_avl_create ((int (*) (const void *, const void *)) strcmp); +} + +static int cj_config_append_string (const char *name, struct curl_slist **dest, /* {{{ */ + oconfig_item_t *ci) { if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_STRING)) { @@ -409,32 +450,12 @@ static int cj_config_add_string (const char *name, char **dest, /* {{{ */ return (-1); } - sfree (*dest); - *dest = strdup (ci->values[0].value.string); + *dest = curl_slist_append(*dest, ci->values[0].value.string); if (*dest == NULL) return (-1); return (0); -} /* }}} int cj_config_add_string */ - -static int cj_config_set_boolean (const char *name, int *dest, /* {{{ */ - oconfig_item_t *ci) -{ - if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_BOOLEAN)) - { - WARNING ("curl_json plugin: `%s' needs exactly one boolean argument.", name); - return (-1); - } - - *dest = ci->values[0].value.boolean ? 1 : 0; - - return (0); -} /* }}} int cj_config_set_boolean */ - -static c_avl_tree_t *cj_avl_create(void) -{ - return c_avl_create ((int (*) (const void *, const void *)) strcmp); -} +} /* }}} int cj_config_append_string */ static int cj_config_add_key (cj_t *db, /* {{{ */ oconfig_item_t *ci) @@ -462,7 +483,7 @@ static int cj_config_add_key (cj_t *db, /* {{{ */ if (strcasecmp ("Key", ci->key) == 0) { - status = cj_config_add_string ("Key", &key->path, ci); + status = cf_util_get_string (ci, &key->path); if (status != 0) { sfree (key); @@ -473,6 +494,7 @@ static int cj_config_add_key (cj_t *db, /* {{{ */ { ERROR ("curl_json plugin: cj_config: " "Invalid key: %s", ci->key); + cj_key_free (key); return (-1); } @@ -482,9 +504,9 @@ static int cj_config_add_key (cj_t *db, /* {{{ */ oconfig_item_t *child = ci->children + i; if (strcasecmp ("Type", child->key) == 0) - status = cj_config_add_string ("Type", &key->type, child); + status = cf_util_get_string (child, &key->type); else if (strcasecmp ("Instance", child->key) == 0) - status = cj_config_add_string ("Instance", &key->instance, child); + status = cf_util_get_string (child, &key->instance); else { WARNING ("curl_json plugin: Option `%s' not allowed here.", child->key); @@ -495,71 +517,68 @@ static int cj_config_add_key (cj_t *db, /* {{{ */ break; } /* for (i = 0; i < ci->children_num; i++) */ - while (status == 0) + if (status != 0) { - if (key->type == NULL) - { - WARNING ("curl_json plugin: `Type' missing in `Key' block."); - status = -1; - } + cj_key_free (key); + return (-1); + } - break; - } /* while (status == 0) */ + if (key->type == NULL) + { + WARNING ("curl_json plugin: `Type' missing in `Key' block."); + cj_key_free (key); + return (-1); + } /* store path in a tree that will match the json map structure, example: * "httpd/requests/count", * "httpd/requests/current" -> * { "httpd": { "requests": { "count": $key, "current": $key } } } */ - if (status == 0) + char *ptr; + char *name; + c_avl_tree_t *tree; + + if (db->tree == NULL) + db->tree = cj_avl_create(); + + tree = db->tree; + ptr = key->path; + if (*ptr == '/') + ++ptr; + + name = ptr; + while ((ptr = strchr (name, '/')) != NULL) { - char *ptr; - char *name; char ent[PATH_MAX]; - c_avl_tree_t *tree; + c_avl_tree_t *value; + size_t len; - if (db->tree == NULL) - db->tree = cj_avl_create(); + len = ptr - name; + if (len == 0) + break; - tree = db->tree; - name = key->path; - ptr = key->path; - if (*ptr == '/') - ++ptr; + len = COUCH_MIN(len, sizeof (ent)-1); + sstrncpy (ent, name, len+1); - name = ptr; - while (*ptr) + if (c_avl_get (tree, ent, (void *) &value) != 0) { - if (*ptr == '/') - { - c_avl_tree_t *value; - int len; - - len = ptr-name; - if (len == 0) - break; - sstrncpy (ent, name, len+1); - - if (c_avl_get (tree, ent, (void *) &value) != 0) - { - value = cj_avl_create (); - c_avl_insert (tree, strdup (ent), value); - } - - tree = value; - name = ptr+1; - } - ++ptr; - } - if (*name) - c_avl_insert (tree, strdup(name), key); - else - { - ERROR ("curl_json plugin: invalid key: %s", key->path); - status = -1; + value = cj_avl_create (); + c_avl_insert (tree, strdup (ent), value); } + + tree = value; + name = ptr + 1; + } + + if (strlen (name) == 0) + { + ERROR ("curl_json plugin: invalid key: %s", key->path); + cj_key_free (key); + return (-1); } + c_avl_insert (tree, strdup (name), key); return (status); } /* }}} int cj_config_add_key */ @@ -605,6 +624,10 @@ static int cj_init_curl (cj_t *db) /* {{{ */ db->verify_host ? 2L : 0L); if (db->cacert != NULL) curl_easy_setopt (db->curl, CURLOPT_CAINFO, db->cacert); + if (db->headers != NULL) + curl_easy_setopt (db->curl, CURLOPT_HTTPHEADER, db->headers); + if (db->post_body != NULL) + curl_easy_setopt (db->curl, CURLOPT_POSTFIELDS, db->post_body); return (0); } /* }}} int cj_init_curl */ @@ -632,20 +655,21 @@ static int cj_config_add_url (oconfig_item_t *ci) /* {{{ */ memset (db, 0, sizeof (*db)); if (strcasecmp ("URL", ci->key) == 0) - { - status = cj_config_add_string ("URL", &db->url, ci); - if (status != 0) - { - sfree (db); - return (status); - } - } + status = cf_util_get_string (ci, &db->url); + else if (strcasecmp ("Sock", ci->key) == 0) + status = cf_util_get_string (ci, &db->sock); else { ERROR ("curl_json plugin: cj_config: " "Invalid key: %s", ci->key); + cj_free (db); return (-1); } + if (status != 0) + { + sfree (db); + return (status); + } /* Fill the `cj_t' structure.. */ for (i = 0; i < ci->children_num; i++) @@ -653,19 +677,23 @@ static int cj_config_add_url (oconfig_item_t *ci) /* {{{ */ oconfig_item_t *child = ci->children + i; if (strcasecmp ("Instance", child->key) == 0) - status = cj_config_add_string ("Instance", &db->instance, child); + status = cf_util_get_string (child, &db->instance); else if (strcasecmp ("Host", child->key) == 0) - status = cj_config_add_string ("Host", &db->host, child); - else if (strcasecmp ("User", child->key) == 0) - status = cj_config_add_string ("User", &db->user, child); - else if (strcasecmp ("Password", child->key) == 0) - status = cj_config_add_string ("Password", &db->pass, child); - else if (strcasecmp ("VerifyPeer", child->key) == 0) - status = cj_config_set_boolean ("VerifyPeer", &db->verify_peer, child); - else if (strcasecmp ("VerifyHost", child->key) == 0) - status = cj_config_set_boolean ("VerifyHost", &db->verify_host, child); - else if (strcasecmp ("CACert", child->key) == 0) - status = cj_config_add_string ("CACert", &db->cacert, child); + status = cf_util_get_string (child, &db->host); + else if (db->url && strcasecmp ("User", child->key) == 0) + status = cf_util_get_string (child, &db->user); + else if (db->url && strcasecmp ("Password", child->key) == 0) + status = cf_util_get_string (child, &db->pass); + else if (db->url && strcasecmp ("VerifyPeer", child->key) == 0) + status = cf_util_get_boolean (child, &db->verify_peer); + else if (db->url && strcasecmp ("VerifyHost", child->key) == 0) + status = cf_util_get_boolean (child, &db->verify_host); + else if (db->url && strcasecmp ("CACert", child->key) == 0) + status = cf_util_get_string (child, &db->cacert); + else if (db->url && strcasecmp ("Header", child->key) == 0) + status = cj_config_append_string ("Header", &db->headers, child); + else if (db->url && strcasecmp ("Post", child->key) == 0) + status = cf_util_get_string (child, &db->post_body); else if (strcasecmp ("Key", child->key) == 0) status = cj_config_add_key (db, child); else @@ -682,11 +710,11 @@ static int cj_config_add_url (oconfig_item_t *ci) /* {{{ */ { if (db->tree == NULL) { - WARNING ("curl_json plugin: No (valid) `Key' block " - "within `URL' block `%s'.", db->url); + WARNING ("curl_json plugin: No (valid) `Key' block within `%s' \"`%s'\".", + db->url ? "URL" : "Sock", db->url ? db->url : db->sock); status = -1; } - if (status == 0) + if (status == 0 && db->url) status = cj_init_curl (db); } @@ -694,7 +722,7 @@ static int cj_config_add_url (oconfig_item_t *ci) /* {{{ */ if (status == 0) { user_data_t ud; - char cb_name[DATA_MAX_NAME_LEN]; + char *cb_name; if (db->instance == NULL) db->instance = strdup("default"); @@ -706,11 +734,12 @@ static int cj_config_add_url (oconfig_item_t *ci) /* {{{ */ ud.data = (void *) db; ud.free_func = cj_free; - ssnprintf (cb_name, sizeof (cb_name), "curl_json-%s-%s", - db->instance, db->url); + cb_name = ssnprintf_alloc ("curl_json-%s-%s", + db->instance, db->url ? db->url : db->sock); - plugin_register_complex_read (/* group = */ NULL, cb_name, cj_read, + plugin_register_complex_read (/* group = */ "curl_json", cb_name, cj_read, /* interval = */ NULL, &ud); + sfree (cb_name); } else { @@ -736,7 +765,8 @@ static int cj_config (oconfig_item_t *ci) /* {{{ */ { oconfig_item_t *child = ci->children + i; - if (strcasecmp ("URL", child->key) == 0) + if (strcasecmp ("Sock", child->key) == 0 + || strcasecmp ("URL", child->key) == 0) { status = cj_config_add_url (child); if (status == 0) @@ -796,11 +826,75 @@ static void cj_submit (cj_t *db, cj_key_t *key, value_t *value) /* {{{ */ plugin_dispatch_values (&vl); } /* }}} int cj_submit */ -static int cj_curl_perform (cj_t *db, CURL *curl) /* {{{ */ +static int cj_sock_perform (cj_t *db) /* {{{ */ +{ + char errbuf[1024]; + struct sockaddr_un sa_unix = {}; + sa_unix.sun_family = AF_UNIX; + sstrncpy (sa_unix.sun_path, db->sock, sizeof (sa_unix.sun_path)); + + int fd = socket (AF_UNIX, SOCK_STREAM, 0); + if (fd < 0) + return (-1); + if (connect (fd, (struct sockaddr *)&sa_unix, sizeof(sa_unix)) < 0) + { + ERROR ("curl_json plugin: connect(%s) failed: %s", + (db->sock != NULL) ? db->sock : "", + sstrerror(errno, errbuf, sizeof (errbuf))); + close (fd); + return (-1); + } + + ssize_t red; + do { + unsigned char buffer[4096]; + red = read (fd, buffer, sizeof(buffer)); + if (red < 0) { + ERROR ("curl_json plugin: read(%s) failed: %s", + (db->sock != NULL) ? db->sock : "", + sstrerror(errno, errbuf, sizeof (errbuf))); + close (fd); + return (-1); + } + if (!cj_curl_callback (buffer, red, 1, db)) + break; + } while (red > 0); + close (fd); + return (0); +} /* }}} int cj_sock_perform */ + + +static int cj_curl_perform(cj_t *db) /* {{{ */ { int status; long rc; char *url; + url = db->url; + + status = curl_easy_perform (db->curl); + if (status != CURLE_OK) + { + ERROR ("curl_json plugin: curl_easy_perform failed with status %i: %s (%s)", + status, db->curl_errbuf, url); + return (-1); + } + + curl_easy_getinfo(db->curl, CURLINFO_EFFECTIVE_URL, &url); + curl_easy_getinfo(db->curl, CURLINFO_RESPONSE_CODE, &rc); + + /* The response code is zero if a non-HTTP transport was used. */ + if ((rc != 0) && (rc != 200)) + { + ERROR ("curl_json plugin: curl_easy_perform failed with " + "response code %ld (%s)", rc, url); + return (-1); + } + return (0); +} /* }}} int cj_curl_perform */ + +static int cj_perform (cj_t *db) /* {{{ */ +{ + int status; yajl_handle yprev = db->yajl; db->yajl = yajl_alloc (&ycallbacks, @@ -817,51 +911,40 @@ static int cj_curl_perform (cj_t *db, CURL *curl) /* {{{ */ return (-1); } - status = curl_easy_perform (curl); - - curl_easy_getinfo(curl, CURLINFO_EFFECTIVE_URL, &url); - curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &rc); - - /* The response code is zero if a non-HTTP transport was used. */ - if ((rc != 0) && (rc != 200)) - { - ERROR ("curl_json plugin: curl_easy_perform failed with response code %ld (%s)", - rc, url); - yajl_free (db->yajl); - db->yajl = yprev; - return (-1); - } - - if (status != 0) + if (db->url) + status = cj_curl_perform (db); + else + status = cj_sock_perform (db); + if (status < 0) { - ERROR ("curl_json plugin: curl_easy_perform failed with status %i: %s (%s)", - status, db->curl_errbuf, url); yajl_free (db->yajl); db->yajl = yprev; return (-1); } #if HAVE_YAJL_V2 - status = yajl_complete_parse(db->yajl); + status = yajl_complete_parse(db->yajl); #else - status = yajl_parse_complete(db->yajl); + status = yajl_parse_complete(db->yajl); #endif if (status != yajl_status_ok) { - ERROR ("curl_json plugin: %s failed with status %i.", -#if HAVE_YAJL_V2 - "yajl_complete_parse", -#else - "yajl_parse_complete", -#endif - status); + unsigned char *errmsg; + + errmsg = yajl_get_error (db->yajl, /* verbose = */ 0, + /* jsonText = */ NULL, /* jsonTextLen = */ 0); + ERROR ("curl_json plugin: yajl_parse_complete failed: %s", + (char *) errmsg); + yajl_free_error (db->yajl, errmsg); + yajl_free (db->yajl); + db->yajl = yprev; + return (-1); } yajl_free (db->yajl); db->yajl = yprev; - return (0); -} /* }}} int cj_curl_perform */ +} /* }}} int cj_perform */ static int cj_read (user_data_t *ud) /* {{{ */ { @@ -880,12 +963,21 @@ static int cj_read (user_data_t *ud) /* {{{ */ db->state[db->depth].tree = db->tree; db->key = NULL; - return cj_curl_perform (db, db->curl); + return cj_perform (db); } /* }}} int cj_read */ +static int cj_init (void) /* {{{ */ +{ + /* Call this while collectd is still single-threaded to avoid + * initialization issues in libgcrypt. */ + curl_global_init (CURL_GLOBAL_SSL); + return (0); +} /* }}} int cj_init */ + void module_register (void) { plugin_register_complex_config ("curl_json", cj_config); + plugin_register_init ("curl_json", cj_init); } /* void module_register */ /* vim: set sw=2 sts=2 et fdm=marker : */