X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fexec.c;h=f080ad674bac793ceb27feb0f75de67d16385fb4;hb=eab8493d114c7c209d90ac54edb7c8026c085747;hp=a90563346f70673857a7588330eb9568774f5751;hpb=94e562250296b1435e3e48cd302055d89c4c702b;p=collectd.git diff --git a/src/exec.c b/src/exec.c index a9056334..f080ad67 100755 --- a/src/exec.c +++ b/src/exec.c @@ -18,11 +18,12 @@ * 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * * Authors: - * Florian octo Forster + * Florian octo Forster * Sebastian Harl * Peter Holik **/ +#define _DEFAULT_SOURCE #define _BSD_SOURCE /* For setgroups */ #include "collectd.h" @@ -354,18 +355,7 @@ static void reset_signal_mask (void) /* {{{ */ sigprocmask (SIG_SETMASK, &ss, /* old mask = */ NULL); } /* }}} void reset_signal_mask */ -static void close_pipe(int fd_pipe[2]) -{ - if(fd_pipe[0] != -1) { - close(fd_pipe[0]); - } - - if(fd_pipe[1] != -1) { - close(fd_pipe[1]); - } -} - -static int create_pipe(int fd_pipe[2]) +static int create_pipe (int fd_pipe[2]) /* {{{ */ { char errbuf[1024]; int status; @@ -379,7 +369,16 @@ static int create_pipe(int fd_pipe[2]) } return 0; -} +} /* }}} int create_pipe */ + +static void close_pipe (int fd_pipe[2]) /* {{{ */ +{ + if (fd_pipe[0] != -1) + close (fd_pipe[0]); + + if (fd_pipe[1] != -1) + close (fd_pipe[1]); +} /* }}} void close_pipe */ /* * Creates three pipes (one for reading, one for writing and one for errors), @@ -407,9 +406,10 @@ static int fork_child (program_list_t *pl, int *fd_in, int *fd_out, int *fd_err) if (pl->pid != 0) return (-1); - if(create_pipe(fd_pipe_in) == -1 || create_pipe(fd_pipe_out) == -1 || create_pipe(fd_pipe_err) == -1) { + if ((create_pipe(fd_pipe_in) == -1) + || (create_pipe(fd_pipe_out) == -1) + || (create_pipe(fd_pipe_err) == -1)) goto failed; - } sp_ptr = NULL; status = getpwnam_r (pl->user, &sp, nambuf, sizeof (nambuf), &sp_ptr);