X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fiptables.c;h=8bc71ccbd54bdda226c44f2b2356cea5a7d6ccb1;hb=8f6aa6970bf787e6a11e095322af3338ec781d78;hp=8fad588e85120c9bf78d86e0ccf29b3b3ec6092b;hpb=a0412f28fc15eb04a9a630678a97b6bce2d71fb1;p=collectd.git diff --git a/src/iptables.c b/src/iptables.c index 8fad588e..8bc71ccb 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -26,8 +26,8 @@ #include "collectd.h" -#include "common.h" #include "plugin.h" +#include "utils/common/common.h" #include #include @@ -103,9 +103,7 @@ static int iptables_config(const char *key, const char *value) { ip_chain_t temp = {0}; ip_chain_t *final, **list; char *table; - int table_len; char *chain; - int chain_len; char *value_copy; char *fields[4]; @@ -136,16 +134,16 @@ static int iptables_config(const char *key, const char *value) { table = fields[0]; chain = fields[1]; - table_len = strlen(table) + 1; - if ((unsigned int)table_len > sizeof(temp.table)) { + size_t table_len = strlen(table) + 1; + if (table_len > sizeof(temp.table)) { ERROR("Table `%s' too long.", table); free(value_copy); return 1; } sstrncpy(temp.table, table, table_len); - chain_len = strlen(chain) + 1; - if ((unsigned int)chain_len > sizeof(temp.chain)) { + size_t chain_len = strlen(chain) + 1; + if (chain_len > sizeof(temp.chain)) { ERROR("Chain `%s' too long.", chain); free(value_copy); return 1; @@ -223,7 +221,7 @@ static int submit6_match(const struct ip6t_entry_match *match, sstrncpy(vl.plugin, "ip6tables", sizeof(vl.plugin)); - status = snprintf(vl.plugin_instance, sizeof(vl.plugin_instance), "%s-%s", + status = ssnprintf(vl.plugin_instance, sizeof(vl.plugin_instance), "%s-%s", chain->table, chain->chain); if ((status < 1) || ((unsigned int)status >= sizeof(vl.plugin_instance))) return 0; @@ -232,7 +230,7 @@ static int submit6_match(const struct ip6t_entry_match *match, sstrncpy(vl.type_instance, chain->name, sizeof(vl.type_instance)); } else { if (chain->rule_type == RTYPE_NUM) - snprintf(vl.type_instance, sizeof(vl.type_instance), "%i", + ssnprintf(vl.type_instance, sizeof(vl.type_instance), "%i", chain->rule.num); else sstrncpy(vl.type_instance, (char *)match->data, sizeof(vl.type_instance)); @@ -271,7 +269,7 @@ static int submit_match(const struct ipt_entry_match *match, sstrncpy(vl.plugin, "iptables", sizeof(vl.plugin)); - status = snprintf(vl.plugin_instance, sizeof(vl.plugin_instance), "%s-%s", + status = ssnprintf(vl.plugin_instance, sizeof(vl.plugin_instance), "%s-%s", chain->table, chain->chain); if ((status < 1) || ((unsigned int)status >= sizeof(vl.plugin_instance))) return 0; @@ -280,7 +278,7 @@ static int submit_match(const struct ipt_entry_match *match, sstrncpy(vl.type_instance, chain->name, sizeof(vl.type_instance)); } else { if (chain->rule_type == RTYPE_NUM) - snprintf(vl.type_instance, sizeof(vl.type_instance), "%i", + ssnprintf(vl.type_instance, sizeof(vl.type_instance), "%i", chain->rule.num); else sstrncpy(vl.type_instance, (char *)match->data, sizeof(vl.type_instance));