X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fiptables.c;h=ea8c65e9008916c6004d4ce0b9e41f24f78cba64;hb=a6124ab6c4ffcbbd1f57995b14e8d057f2c86f36;hp=0e7fa70f86740ec864f187e8e2b90d7c28644528;hpb=79b07973208a37d18818541ed6dcdaac8dc35e0f;p=collectd.git diff --git a/src/iptables.c b/src/iptables.c index 0e7fa70f..ea8c65e9 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -25,7 +25,9 @@ #include "plugin.h" #include "configfile.h" -#if HAVE_LIBIPTC_LIBIPTC_H +#if OWN_LIBIPTC +# include "libiptc/libiptc.h" +#else # include #endif @@ -106,7 +108,7 @@ static int iptables_config (const char *key, const char *value) chain = fields[1]; table_len = strlen (table); - if (table_len >= sizeof(temp.table)) + if ((unsigned int)table_len >= sizeof(temp.table)) { ERROR ("Table `%s' too long.", table); free (value_copy); @@ -116,7 +118,7 @@ static int iptables_config (const char *key, const char *value) temp.table[table_len] = '\0'; chain_len = strlen (chain); - if (chain_len >= sizeof(temp.chain)) + if ((unsigned int)chain_len >= sizeof(temp.chain)) { ERROR ("Chain `%s' too long.", chain); free (value_copy); @@ -219,12 +221,12 @@ static int submit_match (const struct ipt_entry_match *match, vl.values = values; vl.values_len = 1; vl.time = time (NULL); - strcpy (vl.host, hostname_g); - strcpy (vl.plugin, "iptables"); + sstrncpy (vl.host, hostname_g, sizeof (vl.host)); + sstrncpy (vl.plugin, "iptables", sizeof (vl.plugin)); status = snprintf (vl.plugin_instance, sizeof (vl.plugin_instance), "%s-%s", chain->table, chain->chain); - if ((status >= sizeof (vl.plugin_instance)) || (status < 1)) + if ((status < 1) || ((unsigned int)status >= sizeof (vl.plugin_instance))) return (0); if (chain->name[0] != '\0')