X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Firq.c;h=401cc6f9cb3f13e84e1a5e2fd961238565c6632c;hb=25c2a62280fcc4cd47875b719549c7eeb581392e;hp=792ac346fa83c3e0ac9df24c1844c2e0325e0d79;hpb=d98487a27d294e31f483b9d43e0d6c02717d248c;p=collectd.git diff --git a/src/irq.c b/src/irq.c index 792ac346..401cc6f9 100644 --- a/src/irq.c +++ b/src/irq.c @@ -85,9 +85,7 @@ static int irq_config (const char *key, const char *value) } else if (strcasecmp (key, "IgnoreSelected") == 0) { - if ((strcasecmp (value, "True") == 0) - || (strcasecmp (value, "Yes") == 0) - || (strcasecmp (value, "On") == 0)) + if (IS_TRUE (value)) irq_list_action = 1; else irq_list_action = 0; @@ -131,10 +129,9 @@ static void irq_submit (unsigned int irq, counter_t value) vl.values = values; vl.values_len = 1; - vl.time = time (NULL); - strcpy (vl.host, hostname_g); - strcpy (vl.plugin, "irq"); - strcpy (vl.type, "irq"); + sstrncpy (vl.host, hostname_g, sizeof (vl.host)); + sstrncpy (vl.plugin, "irq", sizeof (vl.plugin)); + sstrncpy (vl.type, "irq", sizeof (vl.type)); status = ssnprintf (vl.type_instance, sizeof (vl.type_instance), "%u", irq); @@ -152,8 +149,8 @@ static int irq_read (void) FILE *fh; char buffer[BUFSIZE]; unsigned int irq; - unsigned int irq_value; - long value; + unsigned long long irq_value; + unsigned long long value; char *endptr; int i; @@ -183,7 +180,7 @@ static int irq_read (void) for (i = 1; i < fields_num; i++) { errno = 0; - value = strtol (fields[i], &endptr, 10); + value = strtoull (fields[i], &endptr, 10); if ((*endptr != '\0') || (errno != 0)) break; @@ -191,8 +188,10 @@ static int irq_read (void) irq_value += value; } /* for (i) */ - irq_submit (irq, irq_value); + /* Force 32bit wrap-around */ + irq_submit (irq, irq_value % 4294967296ULL); } + fclose (fh); return (0);