X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Flvm.c;h=63107279be19da94f6754caf7423f2140da29114;hb=ac114eac058472786c5ccd52bfb812075343f00f;hp=f6ca577e2cf51ef16c2d960a74a9754103fd36de;hpb=79963d13c1884d1d92667cc502ad20758b084a12;p=collectd.git

diff --git a/src/lvm.c b/src/lvm.c
index f6ca577e..63107279 100644
--- a/src/lvm.c
+++ b/src/lvm.c
@@ -18,7 +18,7 @@
  *
  * Authors:
  *   Chad Malfait <malfaitc at yahoo.com>
- *   Benjamin Gilbert <bgilbert at cs.cmu.edu>
+ *   Benjamin Gilbert <bgilbert at backtick.net>
  **/
 
 #include <lvm2app.h>
@@ -52,15 +52,11 @@ static char const *get_lv_property_string(lv_t lv, char const *property) {
 
 static void lvm_submit(char const *plugin_instance, char const *type_instance,
                        uint64_t ivalue) {
-  value_t v;
   value_list_t vl = VALUE_LIST_INIT;
 
-  v.gauge = (gauge_t)ivalue;
-
-  vl.values = &v;
+  vl.values = &(value_t){.gauge = (gauge_t)ivalue};
   vl.values_len = 1;
 
-  sstrncpy(vl.host, hostname_g, sizeof(vl.host));
   sstrncpy(vl.plugin, "lvm", sizeof(vl.plugin));
   sstrncpy(vl.plugin_instance, plugin_instance, sizeof(vl.plugin_instance));
   sstrncpy(vl.type, "df_complex", sizeof(vl.type));
@@ -81,8 +77,7 @@ static void report_lv_utilization(lv_t lv, char const *vg_name,
     return;
   used_bytes = lv_size * (used_percent_unscaled * PERCENT_SCALE_FACTOR);
 
-  ssnprintf(plugin_instance, sizeof(plugin_instance), "%s-%s", vg_name,
-            lv_name);
+  snprintf(plugin_instance, sizeof(plugin_instance), "%s-%s", vg_name, lv_name);
   lvm_submit(plugin_instance, "used", used_bytes);
   lvm_submit(plugin_instance, "free", lv_size - used_bytes);
 }
@@ -160,14 +155,14 @@ static int lvm_read(void) {
   lvm = lvm_init(NULL);
   if (!lvm) {
     ERROR("lvm plugin: lvm_init failed.");
-    return (-1);
+    return -1;
   }
 
   vg_names = lvm_list_vg_names(lvm);
   if (!vg_names) {
     ERROR("lvm plugin lvm_list_vg_name failed %s", lvm_errmsg(lvm));
     lvm_quit(lvm);
-    return (-1);
+    return -1;
   }
 
   dm_list_iterate_items(name_list, vg_names) {
@@ -185,7 +180,7 @@ static int lvm_read(void) {
   }
 
   lvm_quit(lvm);
-  return (0);
+  return 0;
 } /*lvm_read */
 
 void module_register(void) {