X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fmatch_value.c;h=54ddba28e6cdea3a32af5fe3328cf5a3bd029839;hb=da612fa9c6a3343b43789569d64197d7c690be52;hp=604f0d6fc9eb711edd1d150cddb4929d0481e831;hpb=a5377cf935630082f2eac2e5f4a538844cc06c8d;p=collectd.git diff --git a/src/match_value.c b/src/match_value.c index 604f0d6f..54ddba28 100644 --- a/src/match_value.c +++ b/src/match_value.c @@ -59,14 +59,12 @@ struct mv_match_s */ static void mv_free_match (mv_match_t *m) /* {{{ */ { - size_t i; - if (m == NULL) return; if (m->data_sources != NULL) { - for (i = 0; i < m->data_sources_num; ++i) + for (size_t i = 0; i < m->data_sources_num; ++i) free(m->data_sources[i]); free(m->data_sources); } @@ -104,7 +102,6 @@ static int mv_config_add_data_source (mv_match_t *m, /* {{{ */ { size_t new_data_sources_num; char **temp; - int i; /* Check number of arbuments. */ if (ci->values_num < 1) @@ -115,7 +112,7 @@ static int mv_config_add_data_source (mv_match_t *m, /* {{{ */ } /* Check type of arguments */ - for (i = 0; i < ci->values_num; i++) + for (int i = 0; i < ci->values_num; i++) { if (ci->values[i].type == OCONFIG_TYPE_STRING) continue; @@ -140,14 +137,12 @@ static int mv_config_add_data_source (mv_match_t *m, /* {{{ */ m->data_sources = temp; /* Copy the strings, allocating memory as needed. */ - for (i = 0; i < ci->values_num; i++) + for (int i = 0; i < ci->values_num; i++) { - size_t j; - /* If we get here, there better be memory for us to write to. */ assert (m->data_sources_num < new_data_sources_num); - j = m->data_sources_num; + size_t j = m->data_sources_num; m->data_sources[j] = sstrdup (ci->values[i].value.string); if (m->data_sources[j] == NULL) { @@ -199,7 +194,6 @@ static int mv_create (const oconfig_item_t *ci, void **user_data) /* {{{ */ { mv_match_t *m; int status; - int i; m = calloc (1, sizeof (*m)); if (m == NULL) @@ -216,7 +210,7 @@ static int mv_create (const oconfig_item_t *ci, void **user_data) /* {{{ */ m->data_sources_num = 0; status = 0; - for (i = 0; i < ci->children_num; i++) + for (int i = 0; i < ci->children_num; i++) { oconfig_item_t *child = ci->children + i; @@ -277,7 +271,6 @@ static int mv_match (const data_set_t *ds, const value_list_t *vl, /* {{{ */ mv_match_t *m; gauge_t *values; int status; - size_t i; if ((user_data == NULL) || (*user_data == NULL)) return (-1); @@ -294,7 +287,7 @@ static int mv_match (const data_set_t *ds, const value_list_t *vl, /* {{{ */ status = FC_MATCH_NO_MATCH; - for (i = 0; i < ds->ds_num; i++) + for (size_t i = 0; i < ds->ds_num; i++) { int value_matches = 0;