X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fmeta_data.c;h=0fc58ff5c021e784a3bcc0feb902ab634db040f6;hb=f0b9430b0c0f45ada6f655dd4b9c64a8cbdf8d66;hp=ea98ba94abf44670583ab47601e39ce6a0f68394;hpb=1126617bebe569dffe6b7a5d3f0c400134b41d65;p=collectd.git diff --git a/src/meta_data.c b/src/meta_data.c index ea98ba94..0fc58ff5 100644 --- a/src/meta_data.c +++ b/src/meta_data.c @@ -109,6 +109,8 @@ static meta_entry_t *md_entry_clone (const meta_entry_t *orig) /* {{{ */ return (NULL); copy = md_entry_alloc (orig->key); + if (copy == NULL) + return (NULL); copy->type = orig->type; if (copy->type == MD_TYPE_STRING) copy->value.mv_string = strdup (orig->value.mv_string); @@ -250,7 +252,6 @@ void meta_data_destroy (meta_data_t *md) /* {{{ */ if (md == NULL) return; - pthread_mutex_destroy(&md->lock); md_entry_free (md->head); pthread_mutex_destroy (&md->lock); free (md); @@ -313,7 +314,13 @@ int meta_data_toc (meta_data_t *md, char ***toc) /* {{{ */ for (e = md->head; e != NULL; e = e->next) ++count; - *toc = malloc(count * sizeof(**toc)); + if (count == 0) + { + pthread_mutex_unlock (&md->lock); + return (count); + } + + *toc = calloc(count, sizeof(**toc)); for (e = md->head; e != NULL; e = e->next) (*toc)[i++] = strdup(e->key); @@ -483,7 +490,7 @@ int meta_data_get_string (meta_data_t *md, /* {{{ */ if (e->type != MD_TYPE_STRING) { - ERROR ("meta_data_get_signed_int: Type mismatch for key `%s'", e->key); + ERROR ("meta_data_get_string: Type mismatch for key `%s'", e->key); pthread_mutex_unlock (&md->lock); return (-ENOENT); }