X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fnotify_email.c;h=0120a4039466e240c753ed3e7e2472995dec3335;hb=edd9af8a874ebc9f2a7f02846807229a648917db;hp=cd216ca2da753a2e1a2895486f706c62c280e42d;hpb=d19bcbf5c310f3656503e64ba26829256112ded4;p=collectd.git diff --git a/src/notify_email.c b/src/notify_email.c index cd216ca2..0120a403 100644 --- a/src/notify_email.c +++ b/src/notify_email.c @@ -28,7 +28,6 @@ #include #include -#include #define MAXSTRING 256 @@ -66,7 +65,7 @@ static char *email_subject = NULL; /* Callback to get username and password */ static int authinteract (auth_client_request_t request, char **result, int fields, void __attribute__((unused)) *arg) -{ +{ int i; for (i = 0; i < fields; i++) { @@ -145,7 +144,7 @@ static int notify_email_init (void) if ( !smtp_auth_set_context (session, authctx)) { pthread_mutex_unlock (&session_lock); ERROR ("notify_email plugin: cannot set SMTP auth context"); - return (-1); + return (-1); } pthread_mutex_unlock (&session_lock); @@ -176,7 +175,7 @@ static int notify_email_config (const char *key, const char *value) { char **tmp; - tmp = (char **) realloc ((void *) recipients, (recipients_len + 1) * sizeof (char *)); + tmp = realloc (recipients, (recipients_len + 1) * sizeof (char *)); if (tmp == NULL) { ERROR ("notify_email: realloc failed."); return (-1); @@ -258,7 +257,7 @@ static int notify_email_notification (const notification_t *n, /* Let's make RFC822 message text with \r\n EOLs */ ssnprintf (buf, buf_len, "MIME-Version: 1.0\r\n" - "Content-Type: text/plain;\r\n" + "Content-Type: text/plain; charset=\"US-ASCII\"\r\n" "Content-Transfer-Encoding: 8bit\r\n" "Subject: %s\r\n" "\r\n" @@ -282,7 +281,7 @@ static int notify_email_notification (const notification_t *n, if (!(message = smtp_add_message (session))) { pthread_mutex_unlock (&session_lock); ERROR ("notify_email plugin: cannot set SMTP message"); - return (-1); + return (-1); } smtp_set_reverse_path (message, email_from); smtp_set_header (message, "To", NULL, NULL); @@ -293,7 +292,6 @@ static int notify_email_notification (const notification_t *n, /* Initiate a connection to the SMTP server and transfer the message. */ if (!smtp_start_session (session)) { - char buf[MAXSTRING]; ERROR ("notify_email plugin: SMTP server problem: %s", smtp_strerror (smtp_errno (), buf, sizeof buf)); pthread_mutex_unlock (&session_lock);