X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fovs_stats.c;h=e7859da20eff651384316f28b80abac7dfd9fb53;hb=47cb204f324be21ae54084fbe9e338d854b87bf5;hp=538386ae689fce2a15b2eb30948c20408015f20c;hpb=bcf9c488e832b4cba43b1c1e35d58f463feb967f;p=collectd.git diff --git a/src/ovs_stats.c b/src/ovs_stats.c index 538386ae..e7859da2 100644 --- a/src/ovs_stats.c +++ b/src/ovs_stats.c @@ -330,9 +330,10 @@ static int ovs_stats_update_bridge(yajl_val bridge) { br = ovs_stats_get_bridge(g_bridge_list_head, YAJL_GET_STRING(br_name)); pthread_mutex_lock(&g_stats_lock); if (br == NULL) { - br = (bridge_list_t *)calloc(1, sizeof(bridge_list_t)); + br = calloc(1, sizeof(*br)); if (!br) { - ERROR("%s: Error allocating memory for bridge", plugin_name); + pthread_mutex_unlock(&g_stats_lock); + ERROR("%s: calloc(%zu) failed.", plugin_name, sizeof(*br)); return -1; } char *tmp = YAJL_GET_STRING(br_name); @@ -342,6 +343,7 @@ static int ovs_stats_update_bridge(yajl_val bridge) { if (br->name == NULL) { sfree(br); pthread_mutex_unlock(&g_stats_lock); + ERROR("%s: strdup failed.", plugin_name); return -1; } br->next = g_bridge_list_head;