X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fplugin.c;h=5d882e64de7e69f47b47c53eeb7e63e4adea1045;hb=be99a844a40d7037a910d37a894988b807631a6e;hp=b150cf673ef75302d02a489991a11bcf3985f184;hpb=1e4db580e37d235755de0c4a4c08ba7a6ac7bb4c;p=collectd.git diff --git a/src/plugin.c b/src/plugin.c index b150cf67..5d882e64 100644 --- a/src/plugin.c +++ b/src/plugin.c @@ -888,6 +888,14 @@ int plugin_unregister_read (const char *name) /* {{{ */ } le = llist_search (read_list, name); + if (le == NULL) + { + pthread_mutex_unlock (&read_lock); + WARNING ("plugin_unregister_read: No such read function: %s", + name); + return (-ENOENT); + } + llist_remove (read_list, le); rf = le->value; @@ -1205,8 +1213,14 @@ void plugin_shutdown_all (void) (*callback) (); } - destroy_all_callbacks (&list_write); + /* Write plugins which use the `user_data' pointer usually need the + * same data available to the flush callback. If this is the case, set + * the free_function to NULL when registering the flush callback and to + * the real free function when registering the write callback. This way + * the data isn't freed twice. */ destroy_all_callbacks (&list_flush); + destroy_all_callbacks (&list_write); + destroy_all_callbacks (&list_notification); destroy_all_callbacks (&list_shutdown); destroy_all_callbacks (&list_log);