X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Frrd_dump.c;h=aa2488277aa6bbc51b095613dc1d25bc5d70b8e4;hb=5d074b0e4c13e9345e442aec5cf02b9acd198738;hp=d839bf65c4798ad7da2f860e2d7379b749c15237;hpb=2a6a270edfda89b04722b42b57992907f871c671;p=rrdtool.git diff --git a/src/rrd_dump.c b/src/rrd_dump.c index d839bf6..aa24882 100644 --- a/src/rrd_dump.c +++ b/src/rrd_dump.c @@ -1,5 +1,5 @@ /***************************************************************************** - * RRDtool 1.2.23 Copyright by Tobi Oetiker, 1997-2007 + * RRDtool 1.3.2 Copyright by Tobi Oetiker, 1997-2008 ***************************************************************************** * rrd_dump Display a RRD ***************************************************************************** @@ -43,34 +43,16 @@ *****************************************************************************/ #include "rrd_tool.h" #include "rrd_rpncalc.h" +#include "rrd_client.h" #if !(defined(NETWARE) || defined(WIN32)) extern char *tzname[2]; #endif -int rrd_dump( - int argc, - char **argv) -{ - int rc; - - if (argc < 2) { - rrd_set_error("Not enough arguments"); - return -1; - } - - if (argc == 3) { - rc = rrd_dump_r(argv[1], argv[2]); - } else { - rc = rrd_dump_r(argv[1], NULL); - } - - return rc; -} - -int rrd_dump_r( +static int rrd_dump_opt_r( const char *filename, - char *outname) + char *outname, + int opt_noheader) { unsigned int i, ii, ix, iii = 0; time_t now; @@ -83,7 +65,8 @@ int rrd_dump_r( rrd_value_t value; struct tm tm; - rrd_file = rrd_open(filename, &rrd, RRD_READONLY); + rrd_init(&rrd); + rrd_file = rrd_open(filename, &rrd, RRD_READONLY | RRD_READAHEAD); if (rrd_file == NULL) { rrd_free(&rrd); return (-1); @@ -98,9 +81,19 @@ int rrd_dump_r( out_file = stdout; } + if (!opt_noheader) { + fputs("\n", out_file); + fputs + ("\n", + out_file); + } fputs("", out_file); fputs("", out_file); - fprintf(out_file, "\t %s \n", RRD_VERSION); + if (atoi(rrd.stat_head->version) <= 3) { + fprintf(out_file, "\t %s \n", RRD_VERSION3); + } else { + fprintf(out_file, "\t %s \n", RRD_VERSION); + } fprintf(out_file, "\t %lu \n", rrd.stat_head->pdp_step); #if HAVE_STRFTIME @@ -109,8 +102,8 @@ int rrd_dump_r( #else # error "Need strftime" #endif - fprintf(out_file, "\t %ld \n\n", - rrd.live_head->last_up, somestring); + fprintf(out_file, "\t %lu \n\n", + (unsigned long) rrd.live_head->last_up, somestring); for (i = 0; i < rrd.stat_head->ds_cnt; i++) { fprintf(out_file, "\t\n"); fprintf(out_file, "\t\t %s \n", rrd.ds_def[i].ds_nam); @@ -134,7 +127,7 @@ int rrd_dump_r( } else { /* DST_CDEF */ char *str = NULL; - rpn_compact2str((rpn_cdefds_t *) & (rrd.ds_def[i].par[DS_cdef]), + rpn_compact2str((rpn_cdefds_t *) &(rrd.ds_def[i].par[DS_cdef]), rrd.ds_def, &str); fprintf(out_file, "\t\t %s \n", str); free(str); @@ -176,6 +169,7 @@ int rrd_dump_r( fprintf(out_file, "\t\t\n"); switch (cf_conv(rrd.rra_def[i].cf_nam)) { case CF_HWPREDICT: + case CF_MHWPREDICT: fprintf(out_file, "\t\t %0.10e \n", rrd.rra_def[i].par[RRA_hw_alpha].u_val); fprintf(out_file, "\t\t %0.10e \n", @@ -192,6 +186,12 @@ int rrd_dump_r( fprintf(out_file, "\t\t %lu \n", rrd.rra_def[i].par[RRA_seasonal_smooth_idx].u_cnt); + if (atoi(rrd.stat_head->version) >= 4) { + fprintf(out_file, + "\t\t %0.10e \n", + rrd.rra_def[i].par[RRA_seasonal_smoothing_window]. + u_val); + } fprintf(out_file, "\t\t %lu \n", rrd.rra_def[i].par[RRA_dependent_rra_idx].u_cnt); @@ -255,6 +255,7 @@ int rrd_dump_r( } switch (cf_conv(rrd.rra_def[i].cf_nam)) { case CF_HWPREDICT: + case CF_MHWPREDICT: value = rrd.cdp_prep[i * rrd.stat_head->ds_cnt + ii].scratch[CDP_hw_intercept].u_val; @@ -421,9 +422,86 @@ int rrd_dump_r( } fprintf(out_file, "\n"); rrd_free(&rrd); - close(rrd_file->fd); if (out_file != stdout) { fclose(out_file); } - return (0); + return rrd_close(rrd_file); +} + +/* backward compatibility with 1.2.x */ +int rrd_dump_r( + const char *filename, + char *outname) +{ + return rrd_dump_opt_r(filename, outname, 0); +} + +int rrd_dump( + int argc, + char **argv) +{ + int rc; + int opt_noheader = 0; + char *opt_daemon = NULL; + + /* init rrd clean */ + + optind = 0; + opterr = 0; /* initialize getopt */ + + while (42) { + int opt; + int option_index = 0; + static struct option long_options[] = { + {"daemon", required_argument, 0, 'd'}, + {"no-header", no_argument, 0, 'n'}, + {0, 0, 0, 0} + }; + + opt = getopt_long(argc, argv, "d:n", long_options, &option_index); + + if (opt == EOF) + break; + + switch (opt) { + case 'd': + if (opt_daemon != NULL) + free (opt_daemon); + opt_daemon = strdup (optarg); + if (opt_daemon == NULL) + { + rrd_set_error ("strdup failed."); + return (-1); + } + break; + + case 'n': + opt_noheader = 1; + break; + + default: + rrd_set_error("usage rrdtool %s [--no-header|-n] " + "file.rrd [file.xml]", argv[0]); + return (-1); + break; + } + } /* while (42) */ + + if ((argc - optind) < 1 || (argc - optind) > 2) { + rrd_set_error("usage rrdtool %s [--no-header|-n] " + "file.rrd [file.xml]", argv[0]); + return (-1); + } + + rc = rrdc_flush_if_daemon(opt_daemon, argv[optind]); + if (opt_daemon) free(opt_daemon); + if (rc) return (rc); + + if ((argc - optind) == 2) { + rc = rrd_dump_opt_r(argv[optind], argv[optind + 1], opt_noheader); + } else { + rc = rrd_dump_opt_r(argv[optind], NULL, opt_noheader); + } + + return rc; }