X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Frrd_fetch.c;h=1317483b110adf49478d71b509b6b1c446ef4440;hb=daf8e7ff715a59e1f9827080d1b785ffb3c5a4b1;hp=c065793992dc0f1fcecf90bed8b40e9a1214f693;hpb=7d0d6b07c9f5bd5dfd99aa7fe9826eebf2181f1f;p=rrdtool.git diff --git a/src/rrd_fetch.c b/src/rrd_fetch.c index c065793..1317483 100644 --- a/src/rrd_fetch.c +++ b/src/rrd_fetch.c @@ -1,5 +1,5 @@ /***************************************************************************** - * RRDtool 1.2.23 Copyright by Tobi Oetiker, 1997-2007 + * RRDtool 1.3rc7 Copyright by Tobi Oetiker, 1997-2008 ***************************************************************************** * rrd_fetch.c read date from an rrd to use for further processing ***************************************************************************** @@ -260,7 +260,7 @@ int rrd_fetch_fn( tmp_step_diff = labs(*step - (rrd.stat_head->pdp_step * rrd.rra_def[i].pdp_cnt)); /* best full match */ - if (cal_end >= *end && cal_start <= *start) { + if (cal_start <= *start) { if (first_full || (tmp_step_diff < best_full_step_diff)) { first_full = 0; best_full_step_diff = tmp_step_diff; @@ -277,8 +277,6 @@ int rrd_fetch_fn( tmp_match = full_match; if (cal_start > *start) tmp_match -= (cal_start - *start); - if (cal_end < *end) - tmp_match -= (*end - cal_end); if (first_part || (best_match < tmp_match) || (best_match == tmp_match && @@ -420,18 +418,6 @@ int rrd_fetch_fn( rrd_set_error("fetching cdp from rra"); goto err_free_data; } -#ifdef HAVE_POSIX_FADVISE - /* don't pollute the buffer cache with data read from the file. We do this while reading to - keep damage minimal */ - if (0 != - posix_fadvise(rrd_file->fd, rrd_file->header_len, 0, - POSIX_FADV_DONTNEED)) { - rrd_set_error("setting POSIX_FADV_DONTNEED on '%s': %s", - filename, rrd_strerror(errno)); - goto err_close; /*XXX: should use err_free_all_ds_namv */ - } -#endif - #ifdef DEBUG fprintf(stderr, "post fetch %li -- ", i); for (ii = 0; ii < *ds_cnt; ii++) @@ -445,16 +431,7 @@ int rrd_fetch_fn( #endif } -#ifdef HAVE_POSIX_FADVISE - /* and just to be sure we drop everything except the header at the end */ - if (0 != - posix_fadvise(rrd_file->fd, rrd_file->header_len, 0, - POSIX_FADV_DONTNEED)) { - rrd_set_error("setting POSIX_FADV_DONTNEED on '%s': %s", filename, - rrd_strerror(errno)); - goto err_free; /*XXX: should use err_free_all_ds_namv */ - } -#endif + rrd_close(rrd_file); return (0); err_free_data: