X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Frrd_open.c;h=11476de43cb85bcec38ceb56cab7a42da86454c9;hb=9b54930dbbfe127febcd165e79f6019f822ec802;hp=443a1a5652a50c01a023a47c6fb51773241d364d;hpb=59ffebeb1600f4bd7b0ff79fb2bc08941d3a0195;p=rrdtool.git diff --git a/src/rrd_open.c b/src/rrd_open.c index 443a1a5..11476de 100644 --- a/src/rrd_open.c +++ b/src/rrd_open.c @@ -1,10 +1,13 @@ /***************************************************************************** - * RRDtool 1.1.x Copyright Tobias Oetiker, 1997 - 2002 + * RRDtool 1.2.9 Copyright by Tobi Oetiker, 1997-2005 ***************************************************************************** * rrd_open.c Open an RRD File ***************************************************************************** * $Id$ * $Log$ + * Revision 1.10 2004/05/26 22:11:12 oetiker + * reduce compiler warnings. Many small fixes. -- Mike Slifcak + * * Revision 1.9 2003/04/29 21:56:49 oetiker * readline in rrd_open.c reads the file in 8 KB blocks, and calls realloc for * each block. realloc is very slow in Mac OS X for huge blocks, e.g. when @@ -66,7 +69,7 @@ /* positioned to the first cdp in the first rra */ int -rrd_open(char *file_name, FILE **in_file, rrd_t *rrd, int rdwr) +rrd_open(const char *file_name, FILE **in_file, rrd_t *rrd, int rdwr) { @@ -75,17 +78,9 @@ rrd_open(char *file_name, FILE **in_file, rrd_t *rrd, int rdwr) rrd_init(rrd); if (rdwr == RRD_READONLY) { -#ifndef WIN32 - mode = "r"; -#else mode = "rb"; -#endif } else { -#ifndef WIN32 - mode = "r+"; -#else mode = "rb+"; -#endif } if (((*in_file) = fopen(file_name,mode)) == NULL ){ @@ -106,11 +101,17 @@ rrd_open(char *file_name, FILE **in_file, rrd_t *rrd, int rdwr) if ((MYVAR = malloc(sizeof(MYVART) * MYCNT)) == NULL) {\ rrd_set_error("" #MYVAR " malloc"); \ fclose(*in_file); \ - return (-1); } \ + return (-1); } \ fread(MYVAR,sizeof(MYVART),MYCNT, *in_file); MYFREAD(rrd->stat_head, stat_head_t, 1) + /* lets see if the first read worked */ + if (ferror( *in_file ) || feof(*in_file)) { + rrd_set_error("reading the cookie off %s faild",file_name); + fclose(*in_file); + return(-1); + } version = atoi(rrd->stat_head->version); /* lets do some test if we are on track ... */ @@ -190,7 +191,7 @@ void rrd_freemem(void *mem) if (mem) free(mem); } -int readfile(char *file_name, char **buffer, int skipfirst){ +int readfile(const char *file_name, char **buffer, int skipfirst){ long writecnt=0,totalcnt = MEMBLK; long offset = 0; FILE *input=NULL;