X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Frrd_resize.c;h=e6b17c2f9f71266ca973fa7406ac8014aff9550e;hb=3d068765c6b6c8d096e0692f22e5b5e407948b54;hp=52c208b58f6c98869bafee934ba059b94f1cac12;hpb=dd86fdf1b4d99437b9aa19934e02230c090cc1d5;p=rrdtool.git diff --git a/src/rrd_resize.c b/src/rrd_resize.c index 52c208b..e6b17c2 100644 --- a/src/rrd_resize.c +++ b/src/rrd_resize.c @@ -1,5 +1,5 @@ /***************************************************************************** - * RRDtool 1.2.23 Copyright by Tobi Oetiker, 1997-2007 + * RRDtool 1.3rc2 Copyright by Tobi Oetiker, 1997-2008 ***************************************************************************** * rrd_resize.c Alters size of an RRA ***************************************************************************** @@ -81,7 +81,16 @@ int rrd_resize( rrd_close(rrd_file); return (-1); } - + /* the size of the new file */ + /* yes we are abusing the float cookie for this, aargh */ + if ((rrdnew.stat_head = calloc(1, sizeof(stat_head_t))) == NULL) { + rrd_set_error("allocating stat_head for new RRD"); + rrd_free(&rrdold); + rrd_close(rrd_file); + return (-1); + } + rrdnew.stat_head->float_cookie = rrd_file->file_len + + (rrdold.stat_head->ds_cnt * sizeof(rrd_value_t) * modify); rrd_out_file = rrd_open(outfilename, &rrdnew, RRD_READWRITE | RRD_CREAT); if (rrd_out_file == NULL) { rrd_set_error("Can't create '%s': %s", outfilename, @@ -158,19 +167,24 @@ int rrd_resize( /* Adding extra rows; insert unknown values just after the ** current row number. */ - l = rrdnew.stat_head->ds_cnt * (rrdnew.rra_ptr[target_rra].cur_row + - 1); + l = rrdnew.stat_head->ds_cnt * + (rrdnew.rra_ptr[target_rra].cur_row + 1); while (l > 0) { rrd_read(rrd_file, &buffer, sizeof(rrd_value_t) * 1); rrd_write(rrd_out_file, &buffer, sizeof(rrd_value_t) * 1); l--; } +#ifndef HAVE_MMAP buffer = DNAN; l = rrdnew.stat_head->ds_cnt * modify; while (l > 0) { rrd_write(rrd_out_file, &buffer, sizeof(rrd_value_t) * 1); l--; } +#else + /* for the mmap case, we did already fill the whole new file with DNAN + * before we copied the old values, so nothing to do here. */ +#endif } else { /* Removing rows. Normally this would be just after the cursor ** however this may also mean that we wrap to the beginning of @@ -203,7 +217,8 @@ int rrd_resize( } } while (modify < 0) { - rrd_seek(rrd_file, sizeof(rrd_value_t) * rrdnew.stat_head->ds_cnt, + rrd_seek(rrd_file, + sizeof(rrd_value_t) * rrdnew.stat_head->ds_cnt, SEEK_CUR); rrdnew.rra_def[target_rra].row_cnt--; modify++; @@ -234,7 +249,6 @@ int rrd_resize( rrd_free(&rrdold); rrd_close(rrd_file); - rrd_free(&rrdnew); rrd_close(rrd_out_file); return (0);