X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Frrd_tune.c;h=0df0476b5c7756dcc3a21de632fd8b0a95058fe7;hb=2f0b984b0dfee0a8ab2cb1d41670f40a07ec5cdb;hp=f675c8b24d92ec9f5524a696b67f543ca629d2dd;hpb=ad6f3441d407ca0c82b86b481f697ca913844d54;p=rrdtool.git diff --git a/src/rrd_tune.c b/src/rrd_tune.c index f675c8b..0df0476 100644 --- a/src/rrd_tune.c +++ b/src/rrd_tune.c @@ -1,5 +1,5 @@ /***************************************************************************** - * RRDtool 1.2.23 Copyright by Tobi Oetiker, 1997-2007 + * RRDtool 1.3.2 Copyright by Tobi Oetiker, 1997-2008 ***************************************************************************** * change header parameters of an rrd ***************************************************************************** @@ -39,6 +39,9 @@ * *****************************************************************************/ +#include +#include + #include "rrd_tool.h" #include "rrd_rpncalc.h" #include "rrd_hw.h" @@ -87,6 +90,8 @@ int rrd_tune( {"beta", required_argument, 0, 'y'}, {"gamma", required_argument, 0, 'z'}, {"gamma-deviation", required_argument, 0, 'v'}, + {"smoothing-window", required_argument, 0, 's'}, + {"smoothing-window-deviation", required_argument, 0, 'S'}, {"aberrant-reset", required_argument, 0, 'b'}, {0, 0, 0, 0} }; @@ -95,6 +100,7 @@ int rrd_tune( opterr = 0; /* initialize getopt */ + rrd_init(&rrd); rrd_file = rrd_open(argv[1], &rrd, RRD_READWRITE); if (rrd_file == NULL) { rrd_free(&rrd); @@ -104,6 +110,7 @@ int rrd_tune( while (1) { int option_index = 0; int opt; + char *old_locale = ""; opt = getopt_long(argc, argv, "h:i:a:d:r:p:n:w:f:x:y:z:v:b:", long_options, &option_index); @@ -113,14 +120,17 @@ int rrd_tune( optcnt++; switch (opt) { case 'h': + old_locale = setlocale(LC_NUMERIC, "C"); if ((matches = sscanf(optarg, DS_NAM_FMT ":%ld", ds_nam, &heartbeat)) != 2) { rrd_set_error("invalid arguments for heartbeat"); rrd_free(&rrd); rrd_close(rrd_file); + setlocale(LC_NUMERIC, old_locale); return -1; } + setlocale(LC_NUMERIC, old_locale); if ((ds = ds_match(&rrd, ds_nam)) == -1) { rrd_free(&rrd); rrd_close(rrd_file); @@ -130,13 +140,16 @@ int rrd_tune( break; case 'i': + old_locale = setlocale(LC_NUMERIC, "C"); if ((matches = sscanf(optarg, DS_NAM_FMT ":%lf", ds_nam, &min)) < 1) { rrd_set_error("invalid arguments for minimum ds value"); rrd_free(&rrd); rrd_close(rrd_file); + setlocale(LC_NUMERIC, old_locale); return -1; } + setlocale(LC_NUMERIC, old_locale); if ((ds = ds_match(&rrd, ds_nam)) == -1) { rrd_free(&rrd); rrd_close(rrd_file); @@ -149,13 +162,16 @@ int rrd_tune( break; case 'a': + old_locale = setlocale(LC_NUMERIC, "C"); if ((matches = sscanf(optarg, DS_NAM_FMT ":%lf", ds_nam, &max)) < 1) { rrd_set_error("invalid arguments for maximum ds value"); rrd_free(&rrd); rrd_close(rrd_file); + setlocale(LC_NUMERIC, old_locale); return -1; } + setlocale(LC_NUMERIC, old_locale); if ((ds = ds_match(&rrd, ds_nam)) == -1) { rrd_free(&rrd); rrd_close(rrd_file); @@ -184,15 +200,17 @@ int rrd_tune( rrd_close(rrd_file); return -1; } - strncpy(rrd.ds_def[ds].dst, dst, DST_SIZE - 1); - rrd.ds_def[ds].dst[DST_SIZE - 1] = '\0'; - - rrd.pdp_prep[ds].last_ds[0] = 'U'; - rrd.pdp_prep[ds].last_ds[1] = 'N'; - rrd.pdp_prep[ds].last_ds[2] = 'K'; - rrd.pdp_prep[ds].last_ds[3] = 'N'; - rrd.pdp_prep[ds].last_ds[4] = '\0'; + /* only reset when something is changed */ + if (strncmp(rrd.ds_def[ds].dst, dst, DST_SIZE - 1) != 0) { + strncpy(rrd.ds_def[ds].dst, dst, DST_SIZE - 1); + rrd.ds_def[ds].dst[DST_SIZE - 1] = '\0'; + rrd.pdp_prep[ds].last_ds[0] = 'U'; + rrd.pdp_prep[ds].last_ds[1] = 'N'; + rrd.pdp_prep[ds].last_ds[2] = 'K'; + rrd.pdp_prep[ds].last_ds[3] = 'N'; + rrd.pdp_prep[ds].last_ds[4] = '\0'; + } break; case 'r': if ((matches = @@ -285,6 +303,23 @@ int rrd_tune( return -1; } break; + case 's': + strcpy(rrd.stat_head->version, RRD_VERSION); /* smoothing_window causes Version 4 */ + if (set_hwarg + (&rrd, CF_SEASONAL, RRA_seasonal_smoothing_window, optarg)) { + rrd_free(&rrd); + return -1; + } + break; + case 'S': + strcpy(rrd.stat_head->version, RRD_VERSION); /* smoothing_window causes Version 4 */ + if (set_hwarg + (&rrd, CF_DEVSEASONAL, RRA_seasonal_smoothing_window, + optarg)) { + rrd_free(&rrd); + return -1; + } + break; case '?': if (optopt != 0) rrd_set_error("unknown option '%c'", optopt);