X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fthermal.c;h=b9d07bf5ce22fcacd55f5dcac729e4ad665b12d5;hb=e7a75874a24c1bf19931d5b4b423a0daa7f9be6b;hp=f7f2a59d5eb1521f628a9d518daef6f34f0ee03a;hpb=8afc7e0da30654711884328c2d6b09fc3370c8f7;p=collectd.git

diff --git a/src/thermal.c b/src/thermal.c
index f7f2a59d..b9d07bf5 100644
--- a/src/thermal.c
+++ b/src/thermal.c
@@ -1,6 +1,6 @@
 /**
  * collectd - src/thermal.c
- * Copyright (C) 2008  Micha³ Miros³aw
+ * Copyright (C) 2008  Michał Mirosław
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the
@@ -16,7 +16,7 @@
  * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  *
  * Authors:
- *   Micha³ Miros³aw <mirq-linux at rere.qmqm.pl>
+ *   Michał Mirosław <mirq-linux at rere.qmqm.pl>
  **/
 
 #include "collectd.h"
@@ -51,7 +51,6 @@ static void thermal_submit (const char *plugin_instance, enum dev_type dt,
 	vt.gauge = value;
 
 	vl.values = &vt;
-	vl.time = time (NULL);
 	sstrncpy (vl.plugin, "thermal", sizeof(vl.plugin));
 	sstrncpy (vl.plugin_instance, plugin_instance,
 			sizeof(vl.plugin_instance));
@@ -61,29 +60,20 @@ static void thermal_submit (const char *plugin_instance, enum dev_type dt,
 	plugin_dispatch_values (&vl);
 }
 
-static int read_file_contents (const char *filename, char *buf, int bufsize)
-{
-	FILE *fh;
-	int n;
-
-	if ((fh = fopen (filename, "r")) == NULL)
-		return -1;
-
-	n = fread(buf, 1, bufsize, fh);
-	fclose(fh);
-
-	return n;
-}
-
-static int thermal_sysfs_device_read (const char *name)
+static int thermal_sysfs_device_read (const char __attribute__((unused)) *dir,
+		const char *name, void __attribute__((unused)) *user_data)
 {
 	char filename[256];
 	char data[1024];
 	int len;
 	int ok = 0;
 
-	len = snprintf (filename, sizeof (filename), "%s/%s/temp", dirname_sysfs, name);
-	if ((len < 0) || ((unsigned int)len >= sizeof (filename)))
+	if (device_list && ignorelist_match (device_list, name))
+		return -1;
+
+	len = snprintf (filename, sizeof (filename),
+			"%s/%s/temp", dirname_sysfs, name);
+	if ((len < 0) || ((size_t) len >= sizeof (filename)))
 		return -1;
 
 	len = read_file_contents (filename, data, sizeof(data));
@@ -101,8 +91,9 @@ static int thermal_sysfs_device_read (const char *name)
 		}
 	}
 
-	len = snprintf (filename, sizeof (filename), "%s/%s/cur_state", dirname_sysfs, name);
-	if ((len < 0) || ((unsigned int)len >= sizeof (filename)))
+	len = snprintf (filename, sizeof (filename),
+			"%s/%s/cur_state", dirname_sysfs, name);
+	if ((len < 0) || ((size_t) len >= sizeof (filename)))
 		return -1;
 
 	len = read_file_contents (filename, data, sizeof(data));
@@ -123,24 +114,31 @@ static int thermal_sysfs_device_read (const char *name)
 	return ok ? 0 : -1;
 }
 
-static int thermal_procfs_device_read (const char *name)
+static int thermal_procfs_device_read (const char __attribute__((unused)) *dir,
+		const char *name, void __attribute__((unused)) *user_data)
 {
 	const char str_temp[] = "temperature:";
 	char filename[256];
 	char data[1024];
 	int len;
 
+	if (device_list && ignorelist_match (device_list, name))
+		return -1;
+
 	/**
 	 * rechot ~ # cat /proc/acpi/thermal_zone/THRM/temperature
 	 * temperature:             55 C
 	 */
 	
-	len = snprintf (filename, sizeof (filename), "%s/%s/temperature", dirname_procfs, name);
-	if ((len < 0) || ((unsigned int)len >= sizeof (filename)))
+	len = snprintf (filename, sizeof (filename),
+			"%s/%s/temperature", dirname_procfs, name);
+	if ((len < 0) || ((size_t) len >= sizeof (filename)))
 		return -1;
 
 	len = read_file_contents (filename, data, sizeof(data));
-	if (len > sizeof(str_temp) && data[--len] == '\n' && !strncmp(data, str_temp, sizeof(str_temp)-1)) {
+	if ((len > 0) && ((size_t) len > sizeof(str_temp))
+			&& (data[--len] == '\n')
+			&& (! strncmp(data, str_temp, sizeof(str_temp)-1))) {
 		char *endptr = NULL;
 		double temp;
 		double celsius, add;
@@ -200,17 +198,13 @@ static int thermal_config (const char *key, const char *value)
 	else if (strcasecmp (key, "IgnoreSelected") == 0)
 	{
 		ignorelist_set_invert (device_list, 1);
-		if ((strcasecmp (value, "True") == 0)
-				|| (strcasecmp (value, "Yes") == 0)
-				|| (strcasecmp (value, "On") == 0))
+		if (IS_TRUE (value))
 			ignorelist_set_invert (device_list, 0);
 	}
 	else if (strcasecmp (key, "ForceUseProcfs") == 0)
 	{
 		force_procfs = 0;
-		if ((strcasecmp (value, "True") == 0)
-				|| (strcasecmp (value, "Yes") == 0)
-				|| (strcasecmp (value, "On") == 0))
+		if (IS_TRUE (value))
 			force_procfs = 1;
 	}
 	else
@@ -221,48 +215,16 @@ static int thermal_config (const char *key, const char *value)
 	return 0;
 }
 
-static int walk_directory (const char *dir, int (*callback)(const char *dev))
-{
-	struct dirent *ent;
-	DIR *dh;
-	int ok = 0;
-
-	if ((dh = opendir (dir)) == NULL)
-	{
-		char errbuf[1024];
-		ERROR ("Cannot open '%s': %s", dir,
-				sstrerror (errno, errbuf, sizeof (errbuf)));
-		return -1;
-	}
-
-	while ((ent = readdir (dh)) != NULL)
-	{
-		if (ent->d_name[0] == '.')
-			continue;
-
-		if (device_list) {
-			DEBUG ("thermal plugin: Checking ignorelist for '%s'", ent->d_name);
-			if (ignorelist_match (device_list, ent->d_name))
-				continue;
-		}
-
-		if (!callback(ent->d_name))
-			++ok;
-	}
-
-	closedir (dh);
-
-	return ok ? 0 : -1;
-}
-
 static int thermal_sysfs_read (void)
 {
-	return walk_directory (dirname_sysfs, thermal_sysfs_device_read);
+	return walk_directory (dirname_sysfs, thermal_sysfs_device_read,
+			/* user_data = */ NULL, /* include hidden */ 0);
 }
 
 static int thermal_procfs_read (void)
 {
-	return walk_directory (dirname_procfs, thermal_procfs_device_read);
+	return walk_directory (dirname_procfs, thermal_procfs_device_read,
+			/* user_data = */ NULL, /* include hidden */ 0);
 }
 
 static int thermal_init (void)