X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Ftypes_list.c;h=49714176374a2979a24e5c161ac6b303d184708f;hb=f1b5b8611d87a7904c31ae4b28ea47f11f3c38b9;hp=ff8426286ac515472b63285aee83fe7df0d45cb7;hpb=3469385f04ffcfa2f4ef06d34ed4b24acb378b34;p=collectd.git diff --git a/src/types_list.c b/src/types_list.c index ff842628..49714176 100644 --- a/src/types_list.c +++ b/src/types_list.c @@ -34,7 +34,7 @@ static int parse_ds (data_source_t *dsrc, char *buf, size_t buf_len) if (buf_len < 11) { - ERROR ("parse_ds: (buf_len = %u) < 11", buf_len); + ERROR ("parse_ds: (buf_len = %zu) < 11", buf_len); return (-1); } @@ -62,16 +62,19 @@ static int parse_ds (data_source_t *dsrc, char *buf, size_t buf_len) return (-1); } - strncpy (dsrc->name, fields[0], sizeof (dsrc->name)); - dsrc->name[sizeof (dsrc->name) - 1] = '\0'; + sstrncpy (dsrc->name, fields[0], sizeof (dsrc->name)); if (strcasecmp (fields[1], "GAUGE") == 0) dsrc->type = DS_TYPE_GAUGE; else if (strcasecmp (fields[1], "COUNTER") == 0) dsrc->type = DS_TYPE_COUNTER; + else if (strcasecmp (fields[1], "DERIVE") == 0) + dsrc->type = DS_TYPE_DERIVE; + else if (strcasecmp (fields[1], "ABSOLUTE") == 0) + dsrc->type = DS_TYPE_ABSOLUTE; else { - ERROR ("(fields[1] = %s) != (GAUGE || COUNTER)", fields[1]); + ERROR ("(fields[1] = %s) != (GAUGE || COUNTER || DERIVE || ABSOLUTE)", fields[1]); return (-1); } @@ -85,9 +88,6 @@ static int parse_ds (data_source_t *dsrc, char *buf, size_t buf_len) else dsrc->max = atof (fields[3]); - DEBUG ("parse_ds: dsrc = {%s, %i, %lf, %lf};", - dsrc->name, dsrc->type, dsrc->min, dsrc->max); - return (0); } /* int parse_ds */ @@ -108,8 +108,7 @@ static void parse_line (char *buf) memset (ds, '\0', sizeof (data_set_t)); - strncpy (ds->type, fields[0], sizeof (ds->type)); - ds->type[sizeof (ds->type) - 1] = '\0'; + sstrncpy (ds->type, fields[0], sizeof (ds->type)); ds->ds_num = fields_num - 1; ds->ds = (data_source_t *) calloc (ds->ds_num, sizeof (data_source_t)); @@ -125,9 +124,6 @@ static void parse_line (char *buf) return; } - DEBUG ("parse_line: ds = {%s, %i, %p};", - ds->type, ds->ds_num, (void *) ds->ds); - plugin_register_data_set (ds); sfree (ds->ds); @@ -180,7 +176,9 @@ int read_types_list (const char *file) if (fh == NULL) { char errbuf[1024]; - ERROR ("open (%s) failed: %s", + fprintf (stderr, "Failed to open types database `%s': %s.\n", + file, sstrerror (errno, errbuf, sizeof (errbuf))); + ERROR ("Failed to open types database `%s': %s", file, sstrerror (errno, errbuf, sizeof (errbuf))); return (-1); }