X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Futils_cmd_listval.c;h=638f7fac3dda9384acf7f64e7ded4450efcdd741;hb=79963d13c1884d1d92667cc502ad20758b084a12;hp=b698388d3304e9686ae70f5c0202a1422a0fd36e;hpb=fc6f1e3d33d646391adb5cedc62e7b3904c15003;p=collectd.git diff --git a/src/utils_cmd_listval.c b/src/utils_cmd_listval.c index b698388d..638f7fac 100644 --- a/src/utils_cmd_listval.c +++ b/src/utils_cmd_listval.c @@ -25,83 +25,77 @@ **/ #include "collectd.h" + #include "common.h" #include "plugin.h" -#include "utils_cmd_listval.h" #include "utils_cache.h" +#include "utils_cmd_listval.h" #include "utils_parse_option.h" -#define free_everything_and_return(status) do { \ - size_t j; \ - for (j = 0; j < number; j++) { \ - sfree(names[j]); \ - names[j] = NULL; \ - } \ - sfree(names); \ - sfree(times); \ - return (status); \ +#define free_everything_and_return(status) \ + do { \ + for (size_t j = 0; j < number; j++) { \ + sfree(names[j]); \ + names[j] = NULL; \ + } \ + sfree(names); \ + sfree(times); \ + return (status); \ } while (0) -#define print_to_socket(fh, ...) \ - do { \ - if (fprintf (fh, __VA_ARGS__) < 0) { \ - char errbuf[1024]; \ - WARNING ("handle_listval: failed to write to socket #%i: %s", \ - fileno (fh), sstrerror (errno, errbuf, sizeof (errbuf))); \ - free_everything_and_return (-1); \ - } \ - fflush(fh); \ +#define print_to_socket(fh, ...) \ + do { \ + if (fprintf(fh, __VA_ARGS__) < 0) { \ + char errbuf[1024]; \ + WARNING("handle_listval: failed to write to socket #%i: %s", fileno(fh), \ + sstrerror(errno, errbuf, sizeof(errbuf))); \ + free_everything_and_return(-1); \ + } \ + fflush(fh); \ } while (0) -int handle_listval (FILE *fh, char *buffer) -{ +int handle_listval(FILE *fh, char *buffer) { char *command; char **names = NULL; cdtime_t *times = NULL; size_t number = 0; - size_t i; int status; - DEBUG ("utils_cmd_listval: handle_listval (fh = %p, buffer = %s);", - (void *) fh, buffer); + DEBUG("utils_cmd_listval: handle_listval (fh = %p, buffer = %s);", (void *)fh, + buffer); command = NULL; - status = parse_string (&buffer, &command); - if (status != 0) - { - print_to_socket (fh, "-1 Cannot parse command.\n"); - free_everything_and_return (-1); + status = parse_string(&buffer, &command); + if (status != 0) { + print_to_socket(fh, "-1 Cannot parse command.\n"); + free_everything_and_return(-1); } - assert (command != NULL); + assert(command != NULL); - if (strcasecmp ("LISTVAL", command) != 0) - { - print_to_socket (fh, "-1 Unexpected command: `%s'.\n", command); - free_everything_and_return (-1); + if (strcasecmp("LISTVAL", command) != 0) { + print_to_socket(fh, "-1 Unexpected command: `%s'.\n", command); + free_everything_and_return(-1); } - if (*buffer != 0) - { - print_to_socket (fh, "-1 Garbage after end of command: %s\n", buffer); - free_everything_and_return (-1); + if (*buffer != 0) { + print_to_socket(fh, "-1 Garbage after end of command: %s\n", buffer); + free_everything_and_return(-1); } - status = uc_get_names (&names, ×, &number); - if (status != 0) - { - DEBUG ("command listval: uc_get_names failed with status %i", status); - print_to_socket (fh, "-1 uc_get_names failed.\n"); - free_everything_and_return (-1); + status = uc_get_names(&names, ×, &number); + if (status != 0) { + DEBUG("command listval: uc_get_names failed with status %i", status); + print_to_socket(fh, "-1 uc_get_names failed.\n"); + free_everything_and_return(-1); } - print_to_socket (fh, "%i Value%s found\n", - (int) number, (number == 1) ? "" : "s"); - for (i = 0; i < number; i++) - print_to_socket (fh, "%.3f %s\n", CDTIME_T_TO_DOUBLE (times[i]), - names[i]); + print_to_socket(fh, "%i Value%s found\n", (int)number, + (number == 1) ? "" : "s"); + for (size_t i = 0; i < number; i++) + print_to_socket(fh, "%.3f %s\n", CDTIME_T_TO_DOUBLE(times[i]), names[i]); - free_everything_and_return (0); + free_everything_and_return(0); } /* int handle_listval */ /* vim: set sw=2 sts=2 ts=8 : */