X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Futils_format_json.c;h=8d46edd03418832d20277a78d82a07bac81bd4df;hb=f8379dd45f4a43595f4027992696ee8d02908bff;hp=bbc3dfdb4efc9b21be341e2e1ff2845c67e5ed33;hpb=7d5c193fce64d04cee72619c0b54d624d5011e35;p=collectd.git diff --git a/src/utils_format_json.c b/src/utils_format_json.c index bbc3dfdb..8d46edd0 100644 --- a/src/utils_format_json.c +++ b/src/utils_format_json.c @@ -108,7 +108,7 @@ static int values_to_json (char *buffer, size_t buffer_size, /* {{{ */ if (ds->ds[i].type == DS_TYPE_GAUGE) { if(isfinite (vl->values[i].gauge)) - BUFFER_ADD ("%g", vl->values[i].gauge); + BUFFER_ADD (JSON_GAUGE_FORMAT, vl->values[i].gauge); else BUFFER_ADD ("null"); } @@ -124,7 +124,7 @@ static int values_to_json (char *buffer, size_t buffer_size, /* {{{ */ } if(isfinite (rates[i])) - BUFFER_ADD ("%g", rates[i]); + BUFFER_ADD (JSON_GAUGE_FORMAT, rates[i]); else BUFFER_ADD ("null"); } @@ -225,16 +225,14 @@ static int dsnames_to_json (char *buffer, size_t buffer_size, /* {{{ */ return (0); } /* }}} int dsnames_to_json */ -static int meta_data_to_json (char *buffer, size_t buffer_size, /* {{{ */ - meta_data_t *meta) +static int meta_data_keys_to_json (char *buffer, size_t buffer_size, /* {{{ */ + meta_data_t *meta, char **keys, size_t keys_num) { size_t offset = 0; - char **keys = NULL; - int keys_num; int status; - int i; + size_t i; - memset (buffer, 0, buffer_size); + buffer[0] = 0; #define BUFFER_ADD(...) do { \ status = ssnprintf (buffer + offset, buffer_size - offset, \ @@ -247,7 +245,6 @@ static int meta_data_to_json (char *buffer, size_t buffer_size, /* {{{ */ offset += ((size_t) status); \ } while (0) - keys_num = meta_data_toc (meta, &keys); for (i = 0; i < keys_num; ++i) { int type; @@ -289,10 +286,7 @@ static int meta_data_to_json (char *buffer, size_t buffer_size, /* {{{ */ if (meta_data_get_boolean (meta, key, &value) == 0) BUFFER_ADD (",\"%s\":%s", key, value ? "true" : "false"); } - - free (key); } /* for (keys) */ - free (keys); if (offset <= 0) return (ENOENT); @@ -303,7 +297,32 @@ static int meta_data_to_json (char *buffer, size_t buffer_size, /* {{{ */ #undef BUFFER_ADD return (0); -} /* int meta_data_to_json */ +} /* }}} int meta_data_keys_to_json */ + +static int meta_data_to_json (char *buffer, size_t buffer_size, /* {{{ */ + meta_data_t *meta) +{ + char **keys = NULL; + size_t keys_num; + int status; + size_t i; + + if ((buffer == NULL) || (buffer_size == 0) || (meta == NULL)) + return (EINVAL); + + status = meta_data_toc (meta, &keys); + if (status <= 0) + return (status); + keys_num = (size_t) status; + + status = meta_data_keys_to_json (buffer, buffer_size, meta, keys, keys_num); + + for (i = 0; i < keys_num; ++i) + sfree (keys[i]); + sfree (keys); + + return status; +} /* }}} int meta_data_to_json */ static int value_list_to_json (char *buffer, size_t buffer_size, /* {{{ */ const data_set_t *ds, const value_list_t *vl, int store_rates)