X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fvserver.c;h=806fd921a7fca07dd531a91d0819c3c9d2126505;hb=4979d8dcd6f097eb8fd4661086e28accd31ff905;hp=6c09f439b1a157e1c8b29d41796fa0f4b0ef3b22;hpb=4ea7aebc3f05d082f64a62c679f414cf7cb0e631;p=collectd.git diff --git a/src/vserver.c b/src/vserver.c index 6c09f439..806fd921 100644 --- a/src/vserver.c +++ b/src/vserver.c @@ -27,6 +27,7 @@ **/ #include "collectd.h" + #include "common.h" #include "plugin.h" @@ -131,28 +132,21 @@ static derive_t vserver_get_sock_bytes(const char *s) static int vserver_read (void) { -#if NAME_MAX < 1024 -# define DIRENT_BUFFER_SIZE (sizeof (struct dirent) + 1024 + 1) -#else -# define DIRENT_BUFFER_SIZE (sizeof (struct dirent) + NAME_MAX + 1) -#endif - - DIR *proc; - struct dirent *dent; /* 42 */ - char dirent_buffer[DIRENT_BUFFER_SIZE]; + DIR *proc; errno = 0; proc = opendir (PROCDIR); if (proc == NULL) { char errbuf[1024]; - ERROR ("vserver plugin: fopen (%s): %s", PROCDIR, + ERROR ("vserver plugin: fopen (%s): %s", PROCDIR, sstrerror (errno, errbuf, sizeof (errbuf))); return (-1); } while (42) { + struct dirent *dent; int len; char file[BUFSIZE]; @@ -164,20 +158,20 @@ static int vserver_read (void) int status; - status = readdir_r (proc, (struct dirent *) dirent_buffer, &dent); - if (status != 0) + errno = 0; + dent = readdir (proc); + if (dent == NULL) { char errbuf[4096]; - ERROR ("vserver plugin: readdir_r failed: %s", - sstrerror (errno, errbuf, sizeof (errbuf))); + + if (errno == 0) /* end of directory */ + break; + + ERROR ("vserver plugin: failed to read directory %s: %s", + PROCDIR, sstrerror (errno, errbuf, sizeof (errbuf))); closedir (proc); return (-1); } - else if (dent == NULL) - { - /* end of directory */ - break; - } if (dent->d_name[0] == '.') continue; @@ -185,7 +179,7 @@ static int vserver_read (void) len = ssnprintf (file, sizeof (file), PROCDIR "/%s", dent->d_name); if ((len < 0) || (len >= BUFSIZE)) continue; - + status = stat (file, &statbuf); if (status != 0) { @@ -194,7 +188,7 @@ static int vserver_read (void) file, sstrerror (errno, errbuf, sizeof (errbuf))); continue; } - + if (!S_ISDIR (statbuf.st_mode)) continue;