X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fvserver.c;h=8fdae272746c0b23f7c31fb96cdd96a75cfdc983;hb=6597f3a6584704f92f824f3cf7bac3369102e8a0;hp=4cc8251674afda0665ec270906cb9343e8469637;hpb=cacaa2126020832df99fa6423147bd3de6d4faae;p=collectd.git

diff --git a/src/vserver.c b/src/vserver.c
index 4cc82516..8fdae272 100644
--- a/src/vserver.c
+++ b/src/vserver.c
@@ -56,11 +56,10 @@ static void traffic_submit (const char *plugin_instance,
 
 	vl.values = values;
 	vl.values_len = STATIC_ARRAY_SIZE (values);
-	vl.time = time (NULL);
-	strcpy (vl.host, hostname_g);
-	strcpy (vl.plugin, "vserver");
+	sstrncpy (vl.host, hostname_g, sizeof (vl.host));
+	sstrncpy (vl.plugin, "vserver", sizeof (vl.plugin));
 	sstrncpy (vl.plugin_instance, plugin_instance, sizeof (vl.plugin_instance));
-	strcpy (vl.type, "if_octets");
+	sstrncpy (vl.type, "if_octets", sizeof (vl.type));
 	sstrncpy (vl.type_instance, type_instance, sizeof (vl.type_instance));
 
 	plugin_dispatch_values (&vl);
@@ -78,11 +77,10 @@ static void load_submit (const char *plugin_instance,
 
 	vl.values = values;
 	vl.values_len = STATIC_ARRAY_SIZE (values);
-	vl.time = time (NULL);
-	strcpy (vl.host, hostname_g);
-	strcpy (vl.plugin, "vserver");
+	sstrncpy (vl.host, hostname_g, sizeof (vl.host));
+	sstrncpy (vl.plugin, "vserver", sizeof (vl.plugin));
 	sstrncpy (vl.plugin_instance, plugin_instance, sizeof (vl.plugin_instance));
-	strcpy (vl.type, "load");
+	sstrncpy (vl.type, "load", sizeof (vl.type));
 
 	plugin_dispatch_values (&vl);
 }
@@ -98,9 +96,8 @@ static void submit_gauge (const char *plugin_instance, const char *type,
 
 	vl.values = values;
 	vl.values_len = STATIC_ARRAY_SIZE (values);
-	vl.time = time (NULL);
-	strcpy (vl.host, hostname_g);
-	strcpy (vl.plugin, "vserver");
+	sstrncpy (vl.host, hostname_g, sizeof (vl.host));
+	sstrncpy (vl.plugin, "vserver", sizeof (vl.plugin));
 	sstrncpy (vl.plugin_instance, plugin_instance, sizeof (vl.plugin_instance));
 	sstrncpy (vl.type, type, sizeof (vl.type));
 	sstrncpy (vl.type_instance, type_instance, sizeof (vl.type_instance));
@@ -120,11 +117,19 @@ static inline long long __get_sock_bytes(const char *s)
 
 static int vserver_read (void)
 {
+#if NAME_MAX < 1024
+# define DIRENT_BUFFER_SIZE (sizeof (struct dirent) + 1024 + 1)
+#else
+# define DIRENT_BUFFER_SIZE (sizeof (struct dirent) + NAME_MAX + 1)
+#endif
+
 	DIR 			*proc;
 	struct dirent 	*dent; /* 42 */
+	char dirent_buffer[DIRENT_BUFFER_SIZE];
 
 	errno = 0;
-	if (NULL == (proc = opendir (PROCDIR)))
+	proc = opendir (PROCDIR);
+	if (proc == NULL)
 	{
 		char errbuf[1024];
 		ERROR ("vserver plugin: fopen (%s): %s", PROCDIR, 
@@ -132,27 +137,57 @@ static int vserver_read (void)
 		return (-1);
 	}
 
-	while (NULL != (dent = readdir (proc)))
+	while (42)
 	{
-		int  len;
+		int len;
 		char file[BUFSIZE];
 
 		FILE *fh;
 		char buffer[BUFSIZE];
 
+		struct stat statbuf;
 		char *cols[4];
 
+		int status;
+
+		status = readdir_r (proc, (struct dirent *) dirent_buffer, &dent);
+		if (status != 0)
+		{
+			char errbuf[4096];
+			ERROR ("vserver plugin: readdir_r failed: %s",
+					sstrerror (errno, errbuf, sizeof (errbuf)));
+			closedir (proc);
+			return (-1);
+		}
+		else if (dent == NULL)
+		{
+			/* end of directory */
+			break;
+		}
+
 		if (dent->d_name[0] == '.')
 			continue;
 
-		/* This is not a directory */
-		if (dent->d_type != DT_DIR)
+		len = ssnprintf (file, sizeof (file), PROCDIR "/%s", dent->d_name);
+		if ((len < 0) || (len >= BUFSIZE))
+			continue;
+		
+		status = stat (file, &statbuf);
+		if (status != 0)
+		{
+			char errbuf[4096];
+			WARNING ("vserver plugin: stat (%s) failed: %s",
+					file, sstrerror (errno, errbuf, sizeof (errbuf)));
+			continue;
+		}
+		
+		if (!S_ISDIR (statbuf.st_mode))
 			continue;
 
 		/* socket message accounting */
 		len = ssnprintf (file, sizeof (file),
 				PROCDIR "/%s/cacct", dent->d_name);
-		if ((len < 0) || (len >= sizeof (file)))
+		if ((len < 0) || ((size_t) len >= sizeof (file)))
 			continue;
 
 		if (NULL == (fh = fopen (file, "r")))
@@ -200,7 +235,7 @@ static int vserver_read (void)
 		/* thread information and load */
 		len = ssnprintf (file, sizeof (file),
 				PROCDIR "/%s/cvirt", dent->d_name);
-		if ((len < 0) || (len >= sizeof (file)))
+		if ((len < 0) || ((size_t) len >= sizeof (file)))
 			continue;
 
 		if (NULL == (fh = fopen (file, "r")))
@@ -253,7 +288,7 @@ static int vserver_read (void)
 		/* processes and memory usage */
 		len = ssnprintf (file, sizeof (file),
 				PROCDIR "/%s/limit", dent->d_name);
-		if ((len < 0) || (len >= sizeof (file)))
+		if ((len < 0) || ((size_t) len >= sizeof (file)))
 			continue;
 
 		if (NULL == (fh = fopen (file, "r")))