X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fwrite_redis.c;h=1e7281cb3243d64d725dbb42a8db6a552b042ce2;hb=dee232ec86cb375f00096117475a6f21cf56e015;hp=28d475fecbc41e22132cbf984812cdf0b735e27c;hpb=7a02bef3ed2adcdd6c7f8cf07eaad2aaa84bee2c;p=collectd.git diff --git a/src/write_redis.c b/src/write_redis.c index 28d475fe..1e7281cb 100644 --- a/src/write_redis.c +++ b/src/write_redis.c @@ -57,6 +57,7 @@ static int wr_write (const data_set_t *ds, /* {{{ */ char ident[512]; char key[512]; char value[512]; + char time[24]; size_t value_size; char *value_ptr; int status; @@ -67,6 +68,7 @@ static int wr_write (const data_set_t *ds, /* {{{ */ if (status != 0) return (status); ssnprintf (key, sizeof (key), "collectd/%s", ident); + ssnprintf (time, sizeof (time), "%.9f", CDTIME_T_TO_DOUBLE(vl->time)); memset (value, 0, sizeof (value)); value_size = sizeof (value); @@ -86,13 +88,14 @@ static int wr_write (const data_set_t *ds, /* {{{ */ } \ } while (0) - APPEND ("%.9f:", CDTIME_T_TO_DOUBLE(vl->time)); + APPEND ("%s:", time); + for (i = 0; i < ds->ds_num; i++) { if (ds->ds[i].type == DS_TYPE_COUNTER) APPEND ("%llu", vl->values[i].counter); else if (ds->ds[i].type == DS_TYPE_GAUGE) - APPEND ("%g", vl->values[i].gauge); + APPEND (GAUGE_FORMAT, vl->values[i].gauge); else if (ds->ds[i].type == DS_TYPE_DERIVE) APPEND ("%"PRIi64, vl->values[i].derive); else if (ds->ds[i].type == DS_TYPE_ABSOLUTE) @@ -108,19 +111,19 @@ static int wr_write (const data_set_t *ds, /* {{{ */ if (node->conn == NULL) { node->conn = redisConnectWithTimeout ((char *)node->host, node->port, node->timeout); - if (node->conn == NULL) + if (node->conn != NULL && node->conn->err) { - ERROR ("write_redis plugin: Connecting to host \"%s\" (port %i) failed.", + ERROR ("write_redis plugin: Connecting to host \"%s\" (port %i) failed: %s", (node->host != NULL) ? node->host : "localhost", - (node->port != 0) ? node->port : 6379); + (node->port != 0) ? node->port : 6379, + node->conn->errstr); pthread_mutex_unlock (&node->lock); return (-1); } } assert (node->conn != NULL); - rr = redisCommand (node->conn, "ZADD %s %.9f %s", key, - CDTIME_T_TO_DOUBLE(vl->time), value); + rr = redisCommand (node->conn, "ZADD %s %s %s", key, time, value); if (rr==NULL) WARNING("ZADD command error. key:%s", key);