X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Fzfs_arc.c;h=d1ee111bb637f70db05bf8fd5b3186bdb4995c87;hb=c00630eab6161514c1044e8adb2895f179a535da;hp=8f3b1b4b4bb59ace40c7dc1558f2950b0e7ac6a9;hpb=0b7cd83a5e6bac068ea83a88a5ddcfb07c09fbec;p=collectd.git diff --git a/src/zfs_arc.c b/src/zfs_arc.c index 8f3b1b4b..d1ee111b 100644 --- a/src/zfs_arc.c +++ b/src/zfs_arc.c @@ -99,6 +99,11 @@ static void free_zfs_values(kstat_t *ksp) { } #elif defined(KERNEL_SOLARIS) + +#if HAVE_KSTAT_H +#include +#endif + extern kstat_ctl_t *kc; static long long get_zfs_value(kstat_t *ksp, char *name) { @@ -207,6 +212,18 @@ static int za_read(void) { return -1; } + /* Ignore the first two lines because they contain information about the rest + * of the file. + * See kstat_seq_show_headers module/spl/spl-kstat.c of the spl kernel module. + */ + if ((fgets(buffer, sizeof(buffer), fh) == NULL) || + (fgets(buffer, sizeof(buffer), fh) == NULL)) { + ERROR("zfs_arc plugin: \"%s\" does not contain at least two lines.", + ZOL_ARCSTATS_FILE); + fclose(fh); + return -1; + } + ksp = llist_create(); if (ksp == NULL) { ERROR("zfs_arc plugin: `llist_create' failed."); @@ -222,13 +239,13 @@ static int za_read(void) { ERROR("zfs_arc plugin: \"%s\" does not contain a single line.", ZOL_ARCSTATS_FILE); fclose(fh); - return -1; + return (-1); } if (fgets(buffer, sizeof(buffer), fh) == NULL) { ERROR("zfs_arc plugin: \"%s\" does not contain at least two lines.", ZOL_ARCSTATS_FILE); fclose(fh); - return -1; + return (-1); } while (fgets(buffer, sizeof(buffer), fh) != NULL) {