X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=unpack-objects.c;h=8ae1a1c0fdab32e6c596872d857f40c5f87b97d4;hb=794f9fe7db30e2aff8f8f0543c6d18bf579cdbc2;hp=0892d2b920cbf5b3456867aaaabe45f7599edcc0;hpb=67e5a5ece41eebc7fec497911690e5a8ca38aea6;p=git.git

diff --git a/unpack-objects.c b/unpack-objects.c
index 0892d2b9..8ae1a1c0 100644
--- a/unpack-objects.c
+++ b/unpack-objects.c
@@ -3,8 +3,10 @@
 #include "delta.h"
 #include "pack.h"
 
-static int dry_run;
-static const char unpack_usage[] = "git-unpack-objects < pack-file";
+#include <sys/time.h>
+
+static int dry_run, quiet;
+static const char unpack_usage[] = "git-unpack-objects [-q] < pack-file";
 
 /* We always read in 4kB chunks. */
 static unsigned char buffer[4096];
@@ -55,8 +57,6 @@ static void *get_data(unsigned long size)
 	z_stream stream;
 	void *buf = xmalloc(size);
 
-	if (!size)
-		return buf;
 	memset(&stream, 0, sizeof(stream));
 
 	stream.next_out = buf;
@@ -75,6 +75,7 @@ static void *get_data(unsigned long size)
 		stream.next_in = fill(1);
 		stream.avail_in = len;
 	}
+	inflateEnd(&stream);
 	return buf;
 }
 
@@ -98,15 +99,22 @@ static void add_delta_to_list(unsigned char *base_sha1, void *delta, unsigned lo
 	delta_list = info;
 }
 
-static void added_object(unsigned char *sha1, char *type, void *data, unsigned long size);
+static void added_object(unsigned char *sha1, const char *type, void *data, unsigned long size);
 
-static int resolve_delta(char *type,
+static void write_object(void *buf, unsigned long size, const char *type)
+{
+	unsigned char sha1[20];
+	if (write_sha1_file(buf, size, type, sha1) < 0)
+		die("failed to write object");
+	added_object(sha1, type, buf, size);
+}
+
+static int resolve_delta(const char *type,
 	void *base, unsigned long base_size, 
 	void *delta, unsigned long delta_size)
 {
 	void *result;
 	unsigned long result_size;
-	unsigned char sha1[20];
 
 	result = patch_delta(base, base_size,
 			     delta, delta_size,
@@ -114,15 +122,12 @@ static int resolve_delta(char *type,
 	if (!result)
 		die("failed to apply delta");
 	free(delta);
-
-	if (write_sha1_file(result, result_size, type, sha1) < 0)
-		die("failed to write object");
-	added_object(sha1, type, result, result_size);
+	write_object(result, result_size, type);
 	free(result);
 	return 0;
 }
 
-static void added_object(unsigned char *sha1, char *type, void *data, unsigned long size)
+static void added_object(unsigned char *sha1, const char *type, void *data, unsigned long size)
 {
 	struct delta_info **p = &delta_list;
 	struct delta_info *info;
@@ -142,8 +147,7 @@ static void added_object(unsigned char *sha1, char *type, void *data, unsigned l
 static int unpack_non_delta_entry(enum object_type kind, unsigned long size)
 {
 	void *buf = get_data(size);
-	unsigned char sha1[20];
-	char *type;
+	const char *type;
 
 	switch (kind) {
 	case OBJ_COMMIT: type = "commit"; break;
@@ -152,9 +156,8 @@ static int unpack_non_delta_entry(enum object_type kind, unsigned long size)
 	case OBJ_TAG:    type = "tag"; break;
 	default: die("bad type %d", kind);
 	}
-	if (write_sha1_file(buf, size, type, sha1) < 0)
-		die("failed to write object");
-	added_object(sha1, type, buf, size);
+	if (!dry_run)
+		write_object(buf, size, type);
 	free(buf);
 	return 0;
 }
@@ -165,11 +168,16 @@ static int unpack_delta_entry(unsigned long delta_size)
 	unsigned long base_size;
 	char type[20];
 	unsigned char base_sha1[20];
+	int result;
 
 	memcpy(base_sha1, fill(20), 20);
 	use(20);
 
 	delta_data = get_data(delta_size);
+	if (dry_run) {
+		free(delta_data);
+		return 0;
+	}
 
 	if (!has_sha1_file(base_sha1)) {
 		add_delta_to_list(base_sha1, delta_data, delta_size);
@@ -178,11 +186,14 @@ static int unpack_delta_entry(unsigned long delta_size)
 	base = read_sha1_file(base_sha1, type, &base_size);
 	if (!base)
 		die("failed to read delta-pack base object %s", sha1_to_hex(base_sha1));
-	return resolve_delta(type, base, base_size, delta_data, delta_size);
+	result = resolve_delta(type, base, base_size, delta_data, delta_size);
+	free(base);
+	return result;
 }
 
-static void unpack_one(void)
+static void unpack_one(unsigned nr, unsigned total)
 {
+	unsigned shift;
 	unsigned char *pack, c;
 	unsigned long size;
 	enum object_type type;
@@ -192,11 +203,26 @@ static void unpack_one(void)
 	use(1);
 	type = (c >> 4) & 7;
 	size = (c & 15);
+	shift = 4;
 	while (c & 0x80) {
 		pack = fill(1);
 		c = *pack++;
 		use(1);
-		size = (size << 7) + (c & 0x7f);
+		size += (c & 0x7f) << shift;
+		shift += 7;
+	}
+	if (!quiet) {
+		static unsigned long last_sec;
+		static unsigned last_percent;
+		struct timeval now;
+		unsigned percentage = (nr * 100) / total;
+
+		gettimeofday(&now, NULL);
+		if (percentage != last_percent || now.tv_sec != last_sec) {
+			last_sec = now.tv_sec;
+			last_percent = percentage;
+			fprintf(stderr, "%4u%% (%u/%u) done\r", percentage, nr, total);
+		}
 	}
 	switch (type) {
 	case OBJ_COMMIT:
@@ -227,13 +253,13 @@ static void unpack_all(void)
 
 	if (ntohl(hdr->hdr_signature) != PACK_SIGNATURE)
 		die("bad pack file");
-	if (version != 1)
+	if (version != PACK_VERSION)
 		die("unable to handle pack file version %d", version);
 	fprintf(stderr, "Unpacking %d objects\n", nr_objects);
 
 	use(sizeof(struct pack_header));
 	for (i = 0; i < nr_objects; i++)
-		unpack_one();
+		unpack_one(i+1, nr_objects);
 	if (delta_list)
 		die("unresolved deltas left after unpacking");
 }
@@ -251,6 +277,10 @@ int main(int argc, char **argv)
 				dry_run = 1;
 				continue;
 			}
+			if (!strcmp(arg, "-q")) {
+				quiet = 1;
+				continue;
+			}
 			usage(unpack_usage);
 		}
 
@@ -280,5 +310,7 @@ int main(int argc, char **argv)
 	}
 
 	/* All done */
+	if (!quiet)
+		fprintf(stderr, "\n");
 	return 0;
 }