From: Florian Forster <octo@leeloo.lan.home.verplant.org>
Date: Mon, 11 Jun 2007 10:08:57 +0000 (+0200)
Subject: hddtemp, ntpd plugin: Allow numeric `Port' arguments.
X-Git-Tag: collectd-4.0.2~1
X-Git-Url: https://git.octo.it/?a=commitdiff_plain;h=b577149d350722ba57d995f27cff8bcf0daeabb9;p=collectd.git

hddtemp, ntpd plugin: Allow numeric `Port' arguments.
---

diff --git a/src/hddtemp.c b/src/hddtemp.c
index 00814bd2..d60481e3 100644
--- a/src/hddtemp.c
+++ b/src/hddtemp.c
@@ -69,7 +69,7 @@ typedef struct hddname
 
 static hddname_t *first_hddname = NULL;
 static char *hddtemp_host = NULL;
-static char *hddtemp_port = NULL;
+static char hddtemp_port[16];
 
 /*
  * NAME
@@ -118,7 +118,7 @@ static int hddtemp_query_daemon (char *buffer, int buffer_size)
 		host = HDDTEMP_DEF_HOST;
 
 	port = hddtemp_port;
-	if (port == NULL)
+	if (strlen (port) == 0)
 		port = HDDTEMP_DEF_PORT;
 
 	if ((ai_return = getaddrinfo (host, port, &ai_hints, &ai_list)) != 0)
@@ -211,17 +211,21 @@ static int hddtemp_query_daemon (char *buffer, int buffer_size)
 
 static int hddtemp_config (const char *key, const char *value)
 {
-	if (strcasecmp (key, "host") == 0)
+	if (strcasecmp (key, "Host") == 0)
 	{
 		if (hddtemp_host != NULL)
 			free (hddtemp_host);
 		hddtemp_host = strdup (value);
 	}
-	else if (strcasecmp (key, "port") == 0)
+	else if (strcasecmp (key, "Port") == 0)
 	{
-		if (hddtemp_port != NULL)
-			free (hddtemp_port);
-		hddtemp_port = strdup (value);
+		int port = (int) (atof (value));
+		if ((port > 0) && (port <= 65535))
+			snprintf (hddtemp_port, sizeof (hddtemp_port),
+					"%i", port);
+		else
+			strncpy (hddtemp_port, value, sizeof (hddtemp_port));
+		hddtemp_port[sizeof (hddtemp_port) - 1] = '\0';
 	}
 	else
 	{
diff --git a/src/ntpd.c b/src/ntpd.c
index 6f8e00e3..1c97e69a 100644
--- a/src/ntpd.c
+++ b/src/ntpd.c
@@ -65,7 +65,7 @@ static int config_keys_num = 2;
 # define NTPD_DEFAULT_PORT "123"
 static int   sock_descr = -1;
 static char *ntpd_host = NULL;
-static char *ntpd_port = NULL;
+static char  ntpd_port[16];
 
 /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
  * The following definitions were copied from the NTPd distribution  *
@@ -263,19 +263,22 @@ static int refclock_names_num = 45;
 
 static int ntpd_config (const char *key, const char *value)
 {
-	if (strcasecmp (key, "host") == 0)
+	if (strcasecmp (key, "Host") == 0)
 	{
 		if (ntpd_host != NULL)
 			free (ntpd_host);
 		if ((ntpd_host = strdup (value)) == NULL)
 			return (1);
 	}
-	else if (strcasecmp (key, "port") == 0)
+	else if (strcasecmp (key, "Port") == 0)
 	{
-		if (ntpd_port != NULL)
-			free (ntpd_port);
-		if ((ntpd_port = strdup (value)) == NULL)
-			return (1);
+		int port = (int) (atof (value));
+		if ((port > 0) && (port <= 65535))
+			snprintf (ntpd_port, sizeof (ntpd_port),
+					"%i", port);
+		else
+			strncpy (ntpd_port, value, sizeof (ntpd_port));
+		ntpd_port[sizeof (ntpd_port) - 1] = '\0';
 	}
 	else
 	{
@@ -348,7 +351,7 @@ static int ntpd_connect (void)
 		host = NTPD_DEFAULT_HOST;
 
 	port = ntpd_port;
-	if (port == NULL)
+	if (strlen (port) == 0)
 		port = NTPD_DEFAULT_PORT;
 
 	memset (&ai_hints, '\0', sizeof (ai_hints));