From: Linus Torvalds <torvalds@g5.osdl.org>
Date: Sun, 10 Jul 2005 23:14:22 +0000 (-0700)
Subject: Fix up progress report for off-by-one error
X-Git-Tag: v0.99~1
X-Git-Url: https://git.octo.it/?a=commitdiff_plain;h=cf219196a89becccb50ad4a0a667a2814ddae60f;p=git.git

Fix up progress report for off-by-one error

We used to print the index of the object we unpacked, not how many we
had unpacked.  Which caused slightly confusing progress reports like

	100% (2/3) done

rather than the more obvious "3/3" for 100% ;)
---

diff --git a/unpack-objects.c b/unpack-objects.c
index 355889f6..19874d00 100644
--- a/unpack-objects.c
+++ b/unpack-objects.c
@@ -211,7 +211,7 @@ static void unpack_one(unsigned nr, unsigned total)
 		static unsigned long last_sec;
 		static unsigned last_percent;
 		struct timeval now;
-		unsigned percentage = ((1+nr) * 100) / total;
+		unsigned percentage = (nr * 100) / total;
 
 		gettimeofday(&now, NULL);
 		if (percentage != last_percent || now.tv_sec != last_sec) {
@@ -255,7 +255,7 @@ static void unpack_all(void)
 
 	use(sizeof(struct pack_header));
 	for (i = 0; i < nr_objects; i++)
-		unpack_one(i, nr_objects);
+		unpack_one(i+1, nr_objects);
 	if (delta_list)
 		die("unresolved deltas left after unpacking");
 }