collectd.git
14 years agoprocesses plugin: Add support for AIX.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 21:16:58 +0000 (22:16 +0100)]
processes plugin: Add support for AIX.

In AIX, AFAIK, you do not known if an process are running or slepping,
this stat are saved in thread counter, so total measurement group data
by threads.  -- Andrés J. Díaz

14 years agomemory plugin: Add support for AIX.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 21:10:48 +0000 (22:10 +0100)]
memory plugin: Add support for AIX.

14 years agoload plugin: Add support for AIX.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 21:09:15 +0000 (22:09 +0100)]
load plugin: Add support for AIX.

14 years agointerface plugin: Add support for AIX.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 21:06:17 +0000 (22:06 +0100)]
interface plugin: Add support for AIX.

14 years agodisk plugin: Add support for AIX.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 21:03:53 +0000 (22:03 +0100)]
disk plugin: Add support for AIX.

14 years agocpu plugin: Add support for AIX.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 21:00:58 +0000 (22:00 +0100)]
cpu plugin: Add support for AIX.

14 years agoliboconfig: Rename the “TRUE” and “FALSE” tokens.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 20:57:29 +0000 (21:57 +0100)]
liboconfig: Rename the “TRUE” and “FALSE” tokens.

They are defines in <sys/types.h> under AIX.

14 years agosrc/Makefile.am: Special handling for AIX.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 20:54:54 +0000 (21:54 +0100)]
src/Makefile.am: Special handling for AIX.

Flags for linking:  -Wl,-bexpall,-brtllib
Link with -lm because isnan is in libm

14 years agoconfigure.in: When building on AIX, add “-lm” when checking for NAN.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 20:52:23 +0000 (21:52 +0100)]
configure.in: When building on AIX, add “-lm” when checking for NAN.

14 years agoversion-gen.sh: AIX doesn't have “echo -n”.
Manuel Sanmartin (no email) [Mon, 23 Nov 2009 20:51:29 +0000 (21:51 +0100)]
version-gen.sh: AIX doesn't have “echo -n”.

14 years agocontrib/examples/MyPlugin.pm: Updated to new interface.
Florian Forster [Mon, 23 Nov 2009 20:45:33 +0000 (21:45 +0100)]
contrib/examples/MyPlugin.pm: Updated to new interface.

14 years agoSplit the Values class into PluginData and Values to use PluginData as a baseclass...
Sven Trenkel [Mon, 23 Nov 2009 00:21:43 +0000 (01:21 +0100)]
Split the Values class into PluginData and Values to use PluginData as a baseclass for Notification later.
Also wrote some documentation.

14 years agoprotocols plugins: Fixed a typo in an error message.
Sebastian Harl [Sat, 21 Nov 2009 12:07:16 +0000 (13:07 +0100)]
protocols plugins: Fixed a typo in an error message.

Thanks to lintian(1) for finding that :-)

14 years agoAdded proper doc strings to the Config class.
Sven Trenkel [Sat, 21 Nov 2009 01:56:34 +0000 (02:56 +0100)]
Added proper doc strings to the Config class.

14 years agoAdded unregister functions for all callbacks.
Sven Trenkel [Mon, 16 Nov 2009 00:57:20 +0000 (01:57 +0100)]
Added unregister functions for all callbacks.
Also removed useless plugin_unregister_complex_read declaration.

14 years agoAdded flush and register_flush functions.
Sven Trenkel [Sun, 15 Nov 2009 02:46:03 +0000 (03:46 +0100)]
Added flush and register_flush functions.
Also changed name generation.

14 years agoMerge branch 'collectd-4.8'
Florian Forster [Sat, 14 Nov 2009 08:01:10 +0000 (09:01 +0100)]
Merge branch 'collectd-4.8'

14 years agosnmp plugin: Rename a variable (missed during merge).
Florian Forster [Sat, 14 Nov 2009 08:00:16 +0000 (09:00 +0100)]
snmp plugin: Rename a variable (missed during merge).

14 years agoProper exception logging.
Sven Trenkel [Wed, 11 Nov 2009 10:31:41 +0000 (11:31 +0100)]
Proper exception logging.

14 years agoMerge branch 'collectd-4.8'
Florian Forster [Tue, 10 Nov 2009 19:18:05 +0000 (20:18 +0100)]
Merge branch 'collectd-4.8'

14 years agoMerge branch 'collectd-4.7' into collectd-4.8
Florian Forster [Tue, 10 Nov 2009 19:17:36 +0000 (20:17 +0100)]
Merge branch 'collectd-4.7' into collectd-4.8

Conflicts:
src/snmp.c

14 years agoAdded a config option to start collectd as an interactive python shell.
Sven Trenkel [Mon, 9 Nov 2009 20:49:34 +0000 (21:49 +0100)]
Added a config option to start collectd as an interactive python shell.

14 years agocontrib/snmp-data.conf: Add support for Mikrotik RouterBoards.
Florian Forster [Mon, 9 Nov 2009 11:05:40 +0000 (12:05 +0100)]
contrib/snmp-data.conf: Add support for Mikrotik RouterBoards.

14 years agosnmp plugin: Fix handling of strings with control characters.
Florian Forster [Mon, 9 Nov 2009 11:04:23 +0000 (12:04 +0100)]
snmp plugin: Fix handling of strings with control characters.

If a byte of a string has a value <32, the string is printed as a
hex-string. This fixes issues with some devices returning MAC addresses
as "strings".

14 years agosnmp plugin: Fix handling of negative values.
Florian Forster [Mon, 9 Nov 2009 11:03:20 +0000 (12:03 +0100)]
snmp plugin: Fix handling of negative values.

14 years agoNo need to check for NULL if you're gonna pass NULL anyway.
Sven Trenkel [Sat, 7 Nov 2009 19:59:25 +0000 (20:59 +0100)]
No need to check for NULL if you're gonna pass NULL anyway.

14 years agoMeh, forgot to pass the userdata back on write callbacks.
Sven Trenkel [Sat, 7 Nov 2009 19:54:08 +0000 (20:54 +0100)]
Meh, forgot to pass the userdata back on write callbacks.

14 years agoAdded read callback. And "read" in this case means "plugin_register_complex_read".
Sven Trenkel [Sat, 7 Nov 2009 18:37:16 +0000 (19:37 +0100)]
Added read callback. And "read" in this case means "plugin_register_complex_read".

14 years agoAdded write callbacks.
Sven Trenkel [Tue, 3 Nov 2009 00:32:36 +0000 (01:32 +0100)]
Added write callbacks.

14 years agoBetter workaround for global plugin loading.
Sven Trenkel [Thu, 29 Oct 2009 12:24:39 +0000 (13:24 +0100)]
Better workaround for global plugin loading.

14 years agosrc/Makefile: Support parallel builds when creating the manpages.
Sebastian Harl [Wed, 28 Oct 2009 18:32:36 +0000 (19:32 +0100)]
src/Makefile: Support parallel builds when creating the manpages.

A temporary file name is used when creating the manpages. So far, a static
file name had been used for that, thus causing race conditions. Now, a unique
suffix (PID) is used to fix that.

Thanks to BC^bd for reporting that on IRC!

14 years agorrdcached plugin: Work around a bug in RRDtool 1.4rc2.
Sebastian Harl [Wed, 28 Oct 2009 16:38:51 +0000 (17:38 +0100)]
rrdcached plugin: Work around a bug in RRDtool 1.4rc2.

rrd_client.h in that pre-release checked for HAVE_CONFIG_H and would then try
to include rrd_config.h, which, obviously, is not available in collectd.

14 years agoGenericJMX plugin: Close and re-open the connection upon I/O-errors.
Florian Forster [Wed, 28 Oct 2009 12:31:06 +0000 (13:31 +0100)]
GenericJMX plugin: Close and re-open the connection upon I/O-errors.

14 years agoAdded new python class "Values". Only "dispatch" is implemented right now.
Sven Trenkel [Tue, 27 Oct 2009 16:36:57 +0000 (17:36 +0100)]
Added new python class "Values". Only "dispatch" is implemented right now.

14 years agokern.cp_times needs array of length kern.smp.maxcpus
Doug MacEachern [Thu, 22 Oct 2009 22:52:22 +0000 (15:52 -0700)]
kern.cp_times needs array of length kern.smp.maxcpus

14 years agosurpress gcc warnings on FreeBSD
Doug MacEachern [Thu, 22 Oct 2009 22:50:57 +0000 (15:50 -0700)]
surpress gcc warnings on FreeBSD
cc1: warnings being treated as errors
processes.c: In function 'ps_read':
processes.c:343: warning: 'pse.io_rchar' is used uninitialized in this function
processes.c:1436: note: 'pse.io_rchar' was declared here
processes.c:344: warning: 'pse.io_wchar' is used uninitialized in this function
processes.c:1436: note: 'pse.io_wchar' was declared here
processes.c:345: warning: 'pse.io_syscr' is used uninitialized in this function
processes.c:1436: note: 'pse.io_syscr' was declared here
processes.c:346: warning: 'pse.io_syscw' is used uninitialized in this function
processes.c:1436: note: 'pse.io_syscw' was declared here

14 years agoSplit python module. Added support for cyclic GC runs.
Sven Trenkel [Wed, 21 Oct 2009 14:08:30 +0000 (16:08 +0200)]
Split python module. Added support for cyclic GC runs.

14 years agoMerge branch 'collectd-4.8'
Florian Forster [Wed, 21 Oct 2009 09:36:17 +0000 (11:36 +0200)]
Merge branch 'collectd-4.8'

14 years agoMerge branch 'collectd-4.7' into collectd-4.8
Florian Forster [Wed, 21 Oct 2009 09:34:07 +0000 (11:34 +0200)]
Merge branch 'collectd-4.7' into collectd-4.8

Conflicts:
.gitignore

14 years agocontrib/collectd_unixsock.py: Support all plain text protocol commands
Garret Heaton [Sun, 18 Oct 2009 22:34:13 +0000 (15:34 -0700)]
contrib/collectd_unixsock.py: Support all plain text protocol commands

Also rename class from Collect to Collectd and improve output when run
as standalone script.

14 years agocontrib/collectd_unixsock.py: Follow Python PEP-8 syntax requirements.
Garret Heaton [Sun, 18 Oct 2009 21:19:26 +0000 (14:19 -0700)]
contrib/collectd_unixsock.py: Follow Python PEP-8 syntax requirements.

Also remove comment which seems to refer to a file outside of the
collectd project.

14 years agogitignore: Ignore compiled python files
Garret Heaton [Sun, 18 Oct 2009 21:09:26 +0000 (14:09 -0700)]
gitignore: Ignore compiled python files

14 years agoReplace dashes with underscores in python modules
Garret Heaton [Sun, 18 Oct 2009 21:06:22 +0000 (14:06 -0700)]
Replace dashes with underscores in python modules

It's not possible to import python modules with dashes in the name.
See http://bit.ly/2t7fcy for more information.

14 years agoIgnore more java bindings classes
Garret Heaton [Sun, 18 Oct 2009 20:29:23 +0000 (13:29 -0700)]
Ignore more java bindings classes

14 years agoprocesses plugin: Rename the new types and use DERIVE data sources.
Florian Forster [Wed, 21 Oct 2009 09:21:30 +0000 (11:21 +0200)]
processes plugin: Rename the new types and use DERIVE data sources.

This is probably a much safer choice in this case.

14 years agoprocesses plugin: Make “ps_read_io” static.
Florian Forster [Wed, 21 Oct 2009 09:16:35 +0000 (11:16 +0200)]
processes plugin: Make “ps_read_io” static.

14 years agoprocesses plugin: Add collection of IO-metrics.
Andrés J. Díaz [Wed, 21 Oct 2009 09:12:40 +0000 (11:12 +0200)]
processes plugin: Add collection of IO-metrics.

I attach a patch for collectd-4.8.0 adding a new feature which read IO
data for a process using /proc/<pid>/io (only works on linux > 2.6.20),
it's very usefull to monitoring disk throughput and what process is
related with high disk IO. I'm using this patchs for days in some
database environments with good results, but I think that is not enough
stable yet (more testing is required). The patch read from
/proc/<pid>/io (where available) the data for syscr and syscw (read and
write operations) and rchar and wchar (read and write bytes).

14 years agoMerge branch 'collectd-4.8'
Florian Forster [Wed, 21 Oct 2009 08:21:10 +0000 (10:21 +0200)]
Merge branch 'collectd-4.8'

14 years agoMerge branch 'collectd-4.7' into collectd-4.8
Florian Forster [Wed, 21 Oct 2009 08:20:27 +0000 (10:20 +0200)]
Merge branch 'collectd-4.7' into collectd-4.8

14 years agoAdded a workaround to module loading to allow Python scripts to do imports.
Sven Trenkel [Sat, 17 Oct 2009 18:06:51 +0000 (20:06 +0200)]
Added a workaround to module loading to allow Python scripts to do imports.
Redid the python thread handling.
Added log callback.

14 years agoconfigure.in: Fix auxiliary NetApp libraries.
Florian Forster [Wed, 14 Oct 2009 08:35:48 +0000 (10:35 +0200)]
configure.in: Fix auxiliary NetApp libraries.

14 years agogmond plugin: Fixed a typo.
Sebastian Harl [Tue, 13 Oct 2009 17:39:37 +0000 (19:39 +0200)]
gmond plugin: Fixed a typo.

For some reason, the value_t members "derive" and "absolute" had been spelled
in all capital letters, obviously resulting in a build error.

14 years agocollectd.conf: Added the "madwifi" and "match_empty_counter" plugins.
Sebastian Harl [Tue, 13 Oct 2009 17:34:20 +0000 (19:34 +0200)]
collectd.conf: Added the "madwifi" and "match_empty_counter" plugins.

14 years agoFixed a bug with newer NetApp Versions.
Sven Trenkel [Tue, 13 Oct 2009 14:48:01 +0000 (16:48 +0200)]
Fixed a bug with newer NetApp Versions.

NetApp OnTAP API 7.3 and newer actually read this field and
expect the value "counter".

14 years agoAdded logging.
Sven Trenkel [Mon, 12 Oct 2009 22:17:16 +0000 (00:17 +0200)]
Added logging.

14 years agoAdded shutdown callback.
Sven Trenkel [Sun, 11 Oct 2009 23:04:01 +0000 (01:04 +0200)]
Added shutdown callback.
Also fixed a refcount bug.

14 years agoREADME: Added missing prerequisites.
Sebastian Harl [Sun, 11 Oct 2009 16:43:00 +0000 (18:43 +0200)]
README: Added missing prerequisites.

14 years agoAdded init callbacks with full threading support.
Sven Trenkel [Sun, 11 Oct 2009 15:29:05 +0000 (17:29 +0200)]
Added init callbacks with full threading support.

14 years agoAdded keyword support for register_config.
Sven Trenkel [Sun, 11 Oct 2009 01:47:39 +0000 (03:47 +0200)]
Added keyword support for register_config.

14 years agoAdded python plugin.
Sven Trenkel [Sun, 11 Oct 2009 01:28:07 +0000 (03:28 +0200)]
Added python plugin.

It adds a "collectd" module to the embedded python interpreter
which contains a "register_config" method to register config
callbacks and "Config" class which contains a config item.

14 years agonetwork plugin: Implement statistics collection about the plugin itself.
Florian Forster [Sat, 10 Oct 2009 15:04:09 +0000 (17:04 +0200)]
network plugin: Implement statistics collection about the plugin itself.

14 years agoconfigure.in: Don't use “find -L”.
Florian Forster [Thu, 8 Oct 2009 17:00:21 +0000 (19:00 +0200)]
configure.in: Don't use “find -L”.

Apparently the “-L” is a (new) GNU extension. :/

14 years agocollectd-snmp(5): Fix a typo.
Florian Forster [Thu, 8 Oct 2009 16:57:04 +0000 (18:57 +0200)]
collectd-snmp(5): Fix a typo.

Thanks to mspo.

14 years agohashed match: Add a match to simplify load balancing.
Florian Forster [Thu, 8 Oct 2009 09:34:20 +0000 (11:34 +0200)]
hashed match: Add a match to simplify load balancing.

14 years agonetapp plugin: Use a separate read-thread for each host.
Florian Forster [Wed, 7 Oct 2009 15:32:14 +0000 (17:32 +0200)]
netapp plugin: Use a separate read-thread for each host.

Possibly not as efficient as one thread for each metric, but better than
collecting this sequentially any day.

14 years agoChangeLog: Fix a stupid typo. collectd-4.8.1
Florian Forster [Sun, 4 Oct 2009 07:45:00 +0000 (09:45 +0200)]
ChangeLog: Fix a stupid typo.

14 years agoBumped version to 4.8.1; Updated ChangeLog.
Florian Forster [Sun, 4 Oct 2009 07:06:18 +0000 (09:06 +0200)]
Bumped version to 4.8.1; Updated ChangeLog.

14 years agoMerge branch 'collectd-4.7' into collectd-4.8
Florian Forster [Sun, 4 Oct 2009 07:02:31 +0000 (09:02 +0200)]
Merge branch 'collectd-4.7' into collectd-4.8

Conflicts:
ChangeLog
version-gen.sh

14 years agoBumped version to 4.7.4; Updated ChangeLog. collectd-4.7.4
Florian Forster [Sat, 3 Oct 2009 15:44:24 +0000 (17:44 +0200)]
Bumped version to 4.7.4; Updated ChangeLog.

14 years agocontrib/collection3: Improve configuration for "df_complex".
Florian Forster [Fri, 2 Oct 2009 16:02:08 +0000 (18:02 +0200)]
contrib/collection3: Improve configuration for "df_complex".

14 years agoVarious plugins: Use the IS_TRUE and IS_FALSE macros everywhere.
Florian Forster [Fri, 2 Oct 2009 16:01:38 +0000 (18:01 +0200)]
Various plugins: Use the IS_TRUE and IS_FALSE macros everywhere.

14 years agocontextswitches, processes plugins: Don't print an error if number of fields don...
Florian Forster [Fri, 2 Oct 2009 09:37:05 +0000 (11:37 +0200)]
contextswitches, processes plugins: Don't print an error if number of fields don't match.

Because we pick the required line further down, having lines with more
fields is not illegal anymore.

Thanks to Patrik Weiskircher for noticing :)

14 years agodf plugin: Implement the "ReportInodes" option.
Florian Forster [Fri, 2 Oct 2009 09:35:43 +0000 (11:35 +0200)]
df plugin: Implement the "ReportInodes" option.

This option can be used to enable / disable inode statistics collection.

Defaults to "false" for now.

14 years agodf plugin: Implement the "ReportReserved" option.
Florian Forster [Fri, 2 Oct 2009 09:29:44 +0000 (11:29 +0200)]
df plugin: Implement the "ReportReserved" option.

When enabled, the reserved space is reported separately. The "df_complex"
type is used and the mount point or device name is used as plugin instance
(as it should be) instead of the type instance (which is now needed for
"free", "reserved" and "used").

The INode handling has been split up in the same manner.

14 years agoAUTHORS: Added Patrik.
Florian Forster [Fri, 2 Oct 2009 07:56:54 +0000 (09:56 +0200)]
AUTHORS: Added Patrik.

14 years agoREADME: Added the contextswitch plugin.
Florian Forster [Fri, 2 Oct 2009 07:55:17 +0000 (09:55 +0200)]
README: Added the contextswitch plugin.

14 years agoMerge branch 'collectd-4.8'
Florian Forster [Fri, 2 Oct 2009 07:54:14 +0000 (09:54 +0200)]
Merge branch 'collectd-4.8'

Conflicts:
src/df.c

14 years agoMerge branch 'collectd-4.7' into collectd-4.8
Florian Forster [Fri, 2 Oct 2009 07:50:20 +0000 (09:50 +0200)]
Merge branch 'collectd-4.7' into collectd-4.8

Conflicts:
README

14 years agoREADME: Fix order of the curl_json plugin in the list.
Florian Forster [Fri, 2 Oct 2009 07:47:54 +0000 (09:47 +0200)]
README: Fix order of the curl_json plugin in the list.

14 years agoREADME: Fix order of the curl plugin in the list.
Florian Forster [Fri, 2 Oct 2009 07:47:54 +0000 (09:47 +0200)]
README: Fix order of the curl plugin in the list.

14 years agocontextswitch plugin: Only submit if we actually did find a value.
Florian Forster [Fri, 2 Oct 2009 07:44:27 +0000 (09:44 +0200)]
contextswitch plugin: Only submit if we actually did find a value.

Also makes parsing more robust (strncmp would allow for garbage after the key,
strtoul does not overflow when given an invalid string).

14 years agoprocesses plugin: Don't *abort* if a line has more than two fields.
Florian Forster [Fri, 2 Oct 2009 07:40:49 +0000 (09:40 +0200)]
processes plugin: Don't *abort* if a line has more than two fields.

14 years agoAdded contextswitch plugin (for linux).
Patrik Weiskircher [Thu, 1 Oct 2009 11:57:12 +0000 (13:57 +0200)]
Added contextswitch plugin (for linux).

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
14 years agoprocesses plugin: Improve the error handling.
Florian Forster [Fri, 2 Oct 2009 07:06:41 +0000 (09:06 +0200)]
processes plugin: Improve the error handling.

The fork-rate function now returns ULONG_MAX upon error. The error detection
when using strtoul has been improved (overflow is not the only possible error).

14 years agoAdded fork rate collecting to processes plugin.
Patrik Weiskircher [Thu, 1 Oct 2009 11:57:11 +0000 (13:57 +0200)]
Added fork rate collecting to processes plugin.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
14 years agodf plugin: Fix a typo.
Florian Forster [Fri, 2 Oct 2009 06:27:44 +0000 (08:27 +0200)]
df plugin: Fix a typo.

14 years agodf plugin also collects inode count now.
Patrik Weiskircher [Thu, 1 Oct 2009 11:57:10 +0000 (13:57 +0200)]
df plugin also collects inode count now.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
14 years agoMerge branch 'collectd-4.8'
Florian Forster [Thu, 1 Oct 2009 19:34:21 +0000 (21:34 +0200)]
Merge branch 'collectd-4.8'

Conflicts:
src/types.db

14 years agoMerge branch 'collectd-4.7' into collectd-4.8
Florian Forster [Thu, 1 Oct 2009 19:33:37 +0000 (21:33 +0200)]
Merge branch 'collectd-4.7' into collectd-4.8

14 years agosrc/types.db: Replace spaces with tabs.
Florian Forster [Thu, 1 Oct 2009 19:30:53 +0000 (21:30 +0200)]
src/types.db: Replace spaces with tabs.

14 years agosrc/types.db: Replace spaces with tabs.
Florian Forster [Thu, 1 Oct 2009 19:30:53 +0000 (21:30 +0200)]
src/types.db: Replace spaces with tabs.

14 years agosrc/plugin.c: plugin_log: Print to stderr if no log plugin has been loaded.
Florian Forster [Thu, 1 Oct 2009 19:27:40 +0000 (21:27 +0200)]
src/plugin.c: plugin_log: Print to stderr if no log plugin has been loaded.

14 years agoMerge commit 'octo/master'
Sven Trenkel [Thu, 1 Oct 2009 11:25:17 +0000 (13:25 +0200)]
Merge commit 'octo/master'

14 years agoAdded new netapp data types to types.db.
Sven Trenkel [Thu, 1 Oct 2009 11:24:20 +0000 (13:24 +0200)]
Added new netapp data types to types.db.

14 years agoAdded new netapp data types to types.db.
Sven Trenkel [Thu, 1 Oct 2009 11:20:53 +0000 (13:20 +0200)]
Added new netapp data types to types.db.

14 years agoinclude netinet/in.h for sockaddr_in on FreeBSD
Doug MacEachern [Thu, 1 Oct 2009 00:28:08 +0000 (17:28 -0700)]
include netinet/in.h for sockaddr_in on FreeBSD

Fixes:

 common.c: In function 'service_name_to_port_number':
 common.c:1112: error: dereferencing pointer to incomplete type
 common.c:1119: error: dereferencing pointer to incomplete type

14 years agounixsock plugin: Fix a (well hidden) race condition.
Florian Forster [Wed, 30 Sep 2009 20:49:16 +0000 (22:49 +0200)]
unixsock plugin: Fix a (well hidden) race condition.

Within the client handling thread, fdopen is called twice on the file
descriptor passed to the thread. Later those file handles are closed like:

  fclose (fhin);
  fclose (fhout);

This is a race condition, because the first call to fclose will close the file
descriptor. The second call to fclose will try the same. Usually, it would fail
silently and all is well. On a busy machine, however, another thread may just
have opened a file or accepted a socket. In that case an arbitrary file
descriptor is closed. If the file descriptor is opened yet again fast enough,
data may even end up in a totally wrong location.

As a work-around the file descriptor is not dup'ed so each fdopen operates on
its own file descriptor. As an alternative the "r+" mode and a single file
handle may be suitable, too.

Many thanks to Sven Trenkel for pointing me into the right directioin :)

14 years agoMerge branch 'st/netapp'
Florian Forster [Wed, 30 Sep 2009 16:20:32 +0000 (18:20 +0200)]
Merge branch 'st/netapp'

14 years agonetapp plugin: Subtract snap_norm_used from norm_used in any case.
Florian Forster [Wed, 30 Sep 2009 16:16:15 +0000 (18:16 +0200)]
netapp plugin: Subtract snap_norm_used from norm_used in any case.

14 years agocollectd.conf(5): Updated the “GetSnapshot” entry.
Florian Forster [Wed, 30 Sep 2009 15:51:17 +0000 (17:51 +0200)]
collectd.conf(5): Updated the “GetSnapshot” entry.