collectd.git
16 years agoconfigfile.c: Abort if any config file could not be read.
Sebastian Harl [Thu, 20 Mar 2008 10:02:06 +0000 (11:02 +0100)]
configfile.c: Abort if any config file could not be read.

So far, when including all files from some directory, errors while reading
any of those config files have been reported but otherwise ignored. So,
collectd would run with some potentially incomplete configuration which is
not what I would expect.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigfile.c: Fixed a memory leak in cf_read_generic().
Sebastian Harl [Thu, 20 Mar 2008 10:01:18 +0000 (11:01 +0100)]
configfile.c: Fixed a memory leak in cf_read_generic().

In case stat(2) failed, the memory allocated for the return value has not
been freed.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigfile.c: Fixed a segfault after a parse error.
Sebastian Harl [Thu, 20 Mar 2008 10:00:37 +0000 (11:00 +0100)]
configfile.c: Fixed a segfault after a parse error.

In cf_read_generic(), the parse result had not been checked to not be
NULL, which caused a segfault when trying to access any of its members.
Now, an error will be returned in that case.

Also, cf_ci_append_children() has been made more robust in that respect.
It now detects an empty source and does nothing in that case.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoAUTHORS: Speak about `plugins', not `modules'.
Florian Forster [Sat, 22 Mar 2008 08:27:44 +0000 (09:27 +0100)]
AUTHORS: Speak about `plugins', not `modules'.

Also sorted the plugins and put them all before any other patches.

16 years agoMerge branch 'pull/collectd-4.3' into collectd-4.3
Florian Forster [Tue, 18 Mar 2008 09:19:43 +0000 (10:19 +0100)]
Merge branch 'pull/collectd-4.3' into collectd-4.3

16 years agosrc/utils_{cache,threshold}.c: Fix the concept of failed and missing values.
Florian Forster [Tue, 18 Mar 2008 09:18:11 +0000 (10:18 +0100)]
src/utils_{cache,threshold}.c: Fix the concept of failed and missing values.

Apparently I was confused at the time - and still am ;)

16 years agoMerge branch 'pull/collectd-4.3' into collectd-4.3
Florian Forster [Mon, 17 Mar 2008 09:45:23 +0000 (10:45 +0100)]
Merge branch 'pull/collectd-4.3' into collectd-4.3

16 years agosrc/utils_cache.c: Fix the handling of `Persist'.
Florian Forster [Fri, 14 Mar 2008 13:30:02 +0000 (14:30 +0100)]
src/utils_cache.c: Fix the handling of `Persist'.

And reorganized/cleaned up the code a bit.

16 years agocontrib/rrd_filter.px: Added the ability to add (empty) data sources.
Florian Forster [Thu, 13 Mar 2008 17:19:48 +0000 (18:19 +0100)]
contrib/rrd_filter.px: Added the ability to add (empty) data sources.

16 years agosrc/{mbmon,plugin,unixsock}.c: Simple fixes for Solaris 5.8
Florian Forster [Thu, 13 Mar 2008 17:19:00 +0000 (18:19 +0100)]
src/{mbmon,plugin,unixsock}.c: Simple fixes for Solaris 5.8

16 years agocontrib/rrd_filter.px: Added a scale and shift filter.
Florian Forster [Thu, 13 Mar 2008 11:33:50 +0000 (12:33 +0100)]
contrib/rrd_filter.px: Added a scale and shift filter.

16 years agosrc/utils_threshold.c: Fix the configuration of {Failure,Warning}Max and inverted...
Florian Forster [Wed, 5 Mar 2008 13:15:02 +0000 (14:15 +0100)]
src/utils_threshold.c: Fix the configuration of {Failure,Warning}Max and inverted checking.

The first issue is a simple copy'n'paste error, the second a nasty oversight.

16 years agocontrib/rrd_filter.px: Remove the (unused) Data::Dumper.
Florian Forster [Wed, 5 Mar 2008 09:03:18 +0000 (10:03 +0100)]
contrib/rrd_filter.px: Remove the (unused) Data::Dumper.

16 years agoBumped version to 4.3.1; Updated ChangeLog. collectd-4.3.1
Florian Forster [Wed, 5 Mar 2008 08:44:24 +0000 (09:44 +0100)]
Bumped version to 4.3.1; Updated ChangeLog.

16 years agocontrib/rrd_filter.px: Renamed the old `extractDS.px'.
Florian Forster [Wed, 5 Mar 2008 08:43:21 +0000 (09:43 +0100)]
contrib/rrd_filter.px: Renamed the old `extractDS.px'.

It can do more than extracting DSes now.

16 years agonetwork plugin: Use `sstrncpy' instead of `strncpy'.
Florian Forster [Wed, 5 Mar 2008 08:28:11 +0000 (09:28 +0100)]
network plugin: Use `sstrncpy' instead of `strncpy'.

This removes a few "buf[buflen - 1] = '\0';".

16 years agosrc/common.[ch]: Changed the signature of `sstrncpy' to match that of `strncpy'.
Florian Forster [Wed, 5 Mar 2008 08:27:28 +0000 (09:27 +0100)]
src/common.[ch]: Changed the signature of `sstrncpy' to match that of `strncpy'.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 5 Mar 2008 08:16:16 +0000 (09:16 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

Conflicts:

ChangeLog
src/network.c
version-gen.sh

16 years agoBumped version to 4.2.5; Updated ChangeLog. collectd-4.2.5
Florian Forster [Tue, 4 Mar 2008 13:43:40 +0000 (14:43 +0100)]
Bumped version to 4.2.5; Updated ChangeLog.

16 years agoconfigure.in: Fix a typo.
Florian Forster [Tue, 4 Mar 2008 13:36:14 +0000 (14:36 +0100)]
configure.in: Fix a typo.

16 years agonetwork plugin: Tested and fixed the receiving part on Sparc.
Florian Forster [Tue, 4 Mar 2008 13:35:07 +0000 (14:35 +0100)]
network plugin: Tested and fixed the receiving part on Sparc.

16 years agonetwork plugin: Use `memcpy' when parsing packages, too.
Florian Forster [Tue, 4 Mar 2008 10:09:07 +0000 (11:09 +0100)]
network plugin: Use `memcpy' when parsing packages, too.

This should prevent crashes due to unaligned memory access when running as
server.

16 years agoChangeLog: Wrote an entry for 4.2.5.
Florian Forster [Tue, 4 Mar 2008 08:36:42 +0000 (09:36 +0100)]
ChangeLog: Wrote an entry for 4.2.5.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Thu, 28 Feb 2008 22:06:16 +0000 (23:06 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agosrc/common.c: Use uint8_t's instead of (signed) char's.
Florian Forster [Thu, 28 Feb 2008 18:54:55 +0000 (19:54 +0100)]
src/common.c: Use uint8_t's instead of (signed) char's.

16 years agosrc/common.[ch]: Implemented `htond' and `ntohd' and applied it to the network plugin.
Florian Forster [Thu, 28 Feb 2008 14:15:53 +0000 (15:15 +0100)]
src/common.[ch]: Implemented `htond' and `ntohd' and applied it to the network plugin.

The functions convert doubles to the x86 representation or from the x86
representation to the representation used on the host. On x86 systems, this is
a NOP.

16 years agoconfigure.in: Added checks to find out how doubles are stored.
Florian Forster [Thu, 28 Feb 2008 13:23:27 +0000 (14:23 +0100)]
configure.in: Added checks to find out how doubles are stored.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 27 Feb 2008 14:33:45 +0000 (15:33 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agosrc/utils_cache.c: Fix SPARC alignment problems.
Florian Forster [Wed, 27 Feb 2008 11:20:42 +0000 (12:20 +0100)]
src/utils_cache.c: Fix SPARC alignment problems.

16 years agonetwork plugin: Align write access to the send buffer.
Florian octo Forster [Wed, 27 Feb 2008 09:22:19 +0000 (10:22 +0100)]
network plugin: Align write access to the send buffer.

SPARC and possibly other architectures cannot access arbitrary memory
locations. This caused a `bus error' on SPARC when the network plugin was
loaded. This change hopefully fixes this problem.

16 years agosrc/Makefile.am: Added dependencies on `utils_cmd_putnotif.[ch]' to the exec plugin.
Florian Forster [Wed, 27 Feb 2008 09:21:00 +0000 (10:21 +0100)]
src/Makefile.am: Added dependencies on `utils_cmd_putnotif.[ch]' to the exec plugin.

16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Wed, 27 Feb 2008 07:09:18 +0000 (08:09 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agotcpconns plugin: Fix for compilation under FreeBSD.
Rob Lensen [Wed, 27 Feb 2008 07:04:57 +0000 (08:04 +0100)]
tcpconns plugin: Fix for compilation under FreeBSD.

16 years agorrdtool plugin: Simplified heartbeat calculation
Stefan Völkel [Mon, 25 Feb 2008 19:14:19 +0000 (20:14 +0100)]
rrdtool plugin: Simplified heartbeat calculation

Looks simpler, should do the same.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agohddtemp plugin: Use SCSI_DISK8_MAJOR thru SCSI_DISK15_MAJOR only if available.
Sebastian Harl [Tue, 19 Feb 2008 11:24:53 +0000 (12:24 +0100)]
hddtemp plugin: Use SCSI_DISK8_MAJOR thru SCSI_DISK15_MAJOR only if available.

Some Linux versions don't seem to provide the major numbers 8 thru 15.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Mon, 25 Feb 2008 07:30:10 +0000 (08:30 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoping plugin: Fixed a typo when setting the TTL.
Sebastian Harl [Sun, 24 Feb 2008 17:25:14 +0000 (18:25 +0100)]
ping plugin: Fixed a typo when setting the TTL.

PING_DEF_TIMEOUT used to be used instead of PING_OPT_TTL as option
argument of ping_setopt(). This caused really strange effects when pinging
hosts, like a failed assertion in ping_timeval_sub() in liboping
indicating a latency <= 0.

Thanks to Romain Francoise for pointing this out and a lot of helpful
debugging information.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoexec plugin: Don't pass an invalid egid to setgroups() if no group was given.
Sebastian Harl [Sun, 24 Feb 2008 11:17:24 +0000 (12:17 +0100)]
exec plugin: Don't pass an invalid egid to setgroups() if no group was given.

In case that no group has been specified in the config file, egid = -1 used to
be passed to setgroups() which, obviously, is not what we want.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Warn if "EnableDebugger" has been used after "LoadPlugin".
Sebastian Harl [Mon, 25 Feb 2008 07:28:39 +0000 (08:28 +0100)]
perl plugin: Warn if "EnableDebugger" has been used after "LoadPlugin".

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.2' into collectd-4.3
Florian Forster [Sat, 23 Feb 2008 09:58:09 +0000 (10:58 +0100)]
Merge branch 'collectd-4.2' into collectd-4.3

16 years agoMerge branch 'collectd-4.1' into collectd-4.2
Florian Forster [Sat, 23 Feb 2008 09:58:00 +0000 (10:58 +0100)]
Merge branch 'collectd-4.1' into collectd-4.2

16 years agoping plugin: Deactivate the plugin if (pingobj == NULL).
Florian Forster [Sat, 23 Feb 2008 09:56:37 +0000 (10:56 +0100)]
ping plugin: Deactivate the plugin if (pingobj == NULL).

If (pingobj == NULL), then the init-function will return (-1) so that the
plugin is deactivated.

16 years agosrc/collectd.c: Fix the arguments passed to an error message.
Brian Micek [Sat, 23 Feb 2008 09:51:46 +0000 (10:51 +0100)]
src/collectd.c: Fix the arguments passed to an error message.

Unfortunately the compiler doesn't check va-args, so this was unnoticed :/

16 years agoMerge branch 'collectd-4.2' of octo@verplant.org:/var/lib/git/collectd into collectd-4.2
Florian Forster [Sat, 23 Feb 2008 09:48:19 +0000 (10:48 +0100)]
Merge branch 'collectd-4.2' of octo@verplant.org:/var/lib/git/collectd into collectd-4.2

16 years agoswap plugin: Reapply a patch for Solaris.
Christophe Kalt [Sat, 23 Feb 2008 09:47:20 +0000 (10:47 +0100)]
swap plugin: Reapply a patch for Solaris.

This is a previously applied change that somehow got lost.

See http://git.verplant.org/?p=collectd.git;a=commitdiff;h=ee1113650b0b565776fc3d62162d84741e234f05
and http://git.verplant.org/?p=collectd.git;a=commitdiff;h=f68b68c5825efbd23c51531ff4e43c78a3bb2b3b

16 years agocontrib/extractDS.px: Enhanced the script to modify RRD files a bit.
Florian Forster [Fri, 22 Feb 2008 16:24:23 +0000 (17:24 +0100)]
contrib/extractDS.px: Enhanced the script to modify RRD files a bit.

It can now also change the stepsize and add an RRA.

16 years agoChangeLog: Removed the legacy message about Nagios integration in the exec plugin. collectd-4.3.0
Florian Forster [Tue, 19 Feb 2008 18:06:13 +0000 (19:06 +0100)]
ChangeLog: Removed the legacy message about Nagios integration in the exec plugin.

16 years agoREADME: Moved "libxml2" from the "Features" section to "Prerequisites".
Sebastian Harl [Tue, 19 Feb 2008 13:22:45 +0000 (14:22 +0100)]
README: Moved "libxml2" from the "Features" section to "Prerequisites".

D'oh!

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'pull/collectd-4.1' into collectd-4.1 collectd-4.1
Florian Forster [Tue, 19 Feb 2008 13:00:37 +0000 (14:00 +0100)]
Merge branch 'pull/collectd-4.1' into collectd-4.1

16 years agosrc/collectd.c: Write a more informative error message if looking up the FQDN fails.
Florian Forster [Tue, 19 Feb 2008 13:00:22 +0000 (14:00 +0100)]
src/collectd.c: Write a more informative error message if looking up the FQDN fails.

As requested by Micha Krause.

16 years agoexec plugin: Use `setgroups' to set the list of supplementary group IDs.
Florian Forster [Tue, 19 Feb 2008 12:55:32 +0000 (13:55 +0100)]
exec plugin: Use `setgroups' to set the list of supplementary group IDs.

Thanks to Peter Holik for suggesting this.

16 years agosrc/configfile.c: Fix another access of free'd memory.
Florian Forster [Mon, 18 Feb 2008 22:11:52 +0000 (23:11 +0100)]
src/configfile.c: Fix another access of free'd memory.

This led to a crash with the default config of the Debian package.

16 years agoliboconfig: Make sure that option-strings can always be freed.
Florian Forster [Mon, 18 Feb 2008 22:10:52 +0000 (23:10 +0100)]
liboconfig: Make sure that option-strings can always be freed.

This resolved a nasty crash when including files.

16 years agoBumped version to 4.3.0; Updated ChangeLog.
Florian Forster [Mon, 18 Feb 2008 20:24:56 +0000 (21:24 +0100)]
Bumped version to 4.3.0; Updated ChangeLog.

16 years agoexec plugin: Removed the Nagios logic from the plugin.
Florian Forster [Mon, 18 Feb 2008 20:19:32 +0000 (21:19 +0100)]
exec plugin: Removed the Nagios logic from the plugin.

Instead point users to the `exec-nagios.px' script in collectd-exec(5).

16 years agomigrate-3-4.px: Do not translate the disk names used by hddtemp.
Sebastian Harl [Sun, 17 Feb 2008 19:23:46 +0000 (20:23 +0100)]
migrate-3-4.px: Do not translate the disk names used by hddtemp.

In version 4, hddtemp still uses major/minor device numbers to identify disks.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agomigrate-3-4.px: Do not translate the disk names used by hddtemp.
Sebastian Harl [Sun, 17 Feb 2008 19:23:46 +0000 (20:23 +0100)]
migrate-3-4.px: Do not translate the disk names used by hddtemp.

In version 4, hddtemp still uses major/minor device numbers to identify disks.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.2'
Florian Forster [Mon, 18 Feb 2008 19:53:54 +0000 (20:53 +0100)]
Merge branch 'collectd-4.2'

16 years agoMerge branch 'collectd-4.1' into collectd-4.2
Florian Forster [Mon, 18 Feb 2008 19:53:44 +0000 (20:53 +0100)]
Merge branch 'collectd-4.1' into collectd-4.2

16 years agoMerge branch 'sh/hddtemp'
Florian Forster [Mon, 18 Feb 2008 19:53:32 +0000 (20:53 +0100)]
Merge branch 'sh/hddtemp'

16 years agohddtemp plugin, collectd.conf(5): Added "TranslateDevicename" config option.
Sebastian Harl [Sun, 17 Feb 2008 19:22:49 +0000 (20:22 +0100)]
hddtemp plugin, collectd.conf(5): Added "TranslateDevicename" config option.

If enabled, translate the disk names to major/minor device numbers. For
backwards compatibility this defaults to true but it it recommended to disable
it as it will probably be removed in the next major version. Any other parts
of collectd have changed in a similar way with version 4.0, so hddtemp should
do so as well.

This option is disabled in new versions of the config file.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agorrdtool plugin: Sort the list of user defined `RRATimespan's.
Florian Forster [Mon, 18 Feb 2008 19:41:38 +0000 (20:41 +0100)]
rrdtool plugin: Sort the list of user defined `RRATimespan's.

This is required by the logic calculating the RRA sized.

16 years agoMerge branch 'master' of octo@verplant.org:/var/lib/git/collectd
Florian Forster [Mon, 18 Feb 2008 17:30:10 +0000 (18:30 +0100)]
Merge branch 'master' of octo@verplant.org:/var/lib/git/collectd

16 years agoperl plugin: Do not abort while preparing the stack for a subroutine call.
Sebastian Harl [Sat, 16 Feb 2008 13:09:36 +0000 (14:09 +0100)]
perl plugin: Do not abort while preparing the stack for a subroutine call.

Else the stack would probably be left in an inconsistent case and might even
leak memory.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd.conf(5): Added a note that libvirt's RefreshInterval may be disabled.
Sebastian Harl [Sat, 16 Feb 2008 13:08:59 +0000 (14:08 +0100)]
collectd.conf(5): Added a note that libvirt's RefreshInterval may be disabled.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoREADME: Added libxml2 to the list of prerequisites.
Sebastian Harl [Sat, 16 Feb 2008 13:08:24 +0000 (14:08 +0100)]
README: Added libxml2 to the list of prerequisites.

The libvirt plugin uses this library to parse data provided by libvirt.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoREADME: Fixed a typo.
Sebastian Harl [Sat, 16 Feb 2008 13:07:47 +0000 (14:07 +0100)]
README: Fixed a typo.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoUpdated collectd.conf.in.
Sebastian Harl [Sat, 16 Feb 2008 13:07:18 +0000 (14:07 +0100)]
Updated collectd.conf.in.

 * Missing plugins and config options have been added.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocontrib/README: Removed the section about PerlLib/.
Sebastian Harl [Sat, 16 Feb 2008 13:06:25 +0000 (14:06 +0100)]
contrib/README: Removed the section about PerlLib/.

This subdirectory no longer exists - it has been moved to bindings/perl/.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMakefile.am: Create `$(localstatedir)/log' so the logfile plugin works out-of-the...
Florian Forster [Fri, 15 Feb 2008 07:04:47 +0000 (08:04 +0100)]
Makefile.am: Create `$(localstatedir)/log' so the logfile plugin works out-of-the-box.

And don't search for `.svn' directories anymore - they're long gone.

16 years agoexec plugin: Changed the format in which notifications are passed to the programs. collectd-4.3.0beta1
Florian Forster [Mon, 11 Feb 2008 11:47:18 +0000 (12:47 +0100)]
exec plugin: Changed the format in which notifications are passed to the programs.

Using a `Message:' header field restricts us to one-line messages, which is
probably not very farsighted.

16 years agoexec plugin: Disabled the `NagiosExec' option.
Florian Forster [Mon, 11 Feb 2008 11:35:02 +0000 (12:35 +0100)]
exec plugin: Disabled the `NagiosExec' option.

All references to this option have been removed from the manpages, too.

16 years agocollectd.conf(5), ChangeLog: Documented the new `Include' features.
Florian Forster [Mon, 11 Feb 2008 11:21:24 +0000 (12:21 +0100)]
collectd.conf(5), ChangeLog: Documented the new `Include' features.

16 years agosrc/configfile.c: Use wordexp(3) to expand shell wildcards if available.
Florian Forster [Mon, 11 Feb 2008 11:01:06 +0000 (12:01 +0100)]
src/configfile.c: Use wordexp(3) to expand shell wildcards if available.

16 years agocontrib/migrate-3-4.px: Handle `hddtemp' graphs correctly.
Florian Forster [Mon, 11 Feb 2008 10:18:58 +0000 (11:18 +0100)]
contrib/migrate-3-4.px: Handle `hddtemp' graphs correctly.

16 years agocontrib/exec-nagios.px: Added a Perl script which handles Nagios plugins.
Florian Forster [Sun, 10 Feb 2008 15:40:58 +0000 (16:40 +0100)]
contrib/exec-nagios.px: Added a Perl script which handles Nagios plugins.

It handles most of the Nagios plugin API, including multi-line output (a
Nagios 3 feature) and performance data. It's basic on purpose so that easy
stuff is possible but complex stuff is about as hard as rewriting the plugin ;)

16 years agocontrib/exec-munin.px: Fix a typo in the config handling functions.
Florian Forster [Sun, 10 Feb 2008 15:10:40 +0000 (16:10 +0100)]
contrib/exec-munin.px: Fix a typo in the config handling functions.

16 years agosrc/utils_ignorelist.c: Remove an annoying debug message.
Florian Forster [Sat, 9 Feb 2008 17:07:08 +0000 (18:07 +0100)]
src/utils_ignorelist.c: Remove an annoying debug message.

16 years agoconfigure: Fix a syntax error.
Florian Forster [Sat, 9 Feb 2008 17:06:48 +0000 (18:06 +0100)]
configure: Fix a syntax error.

16 years agoMerge branch 'master' of octo@verplant.org:/var/lib/git/collectd
Florian Forster [Sat, 9 Feb 2008 16:46:48 +0000 (17:46 +0100)]
Merge branch 'master' of octo@verplant.org:/var/lib/git/collectd

16 years agoconfigure: Correctly handle all cases when using AC_ARG_WITH().
Sebastian Harl [Tue, 5 Feb 2008 23:00:49 +0000 (00:00 +0100)]
configure: Correctly handle all cases when using AC_ARG_WITH().

In a lot of cases only "$withval" != "yes" and "no" had been handled when the
option had been given. Therefore, the option had been ignored if no argument
had been passed to the option, making --with-<option> and / or
--without-<option> a no-op. This patch fixes this issue.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocontrib/examples/: Added an example for a notification callback.
Sebastian Harl [Tue, 5 Feb 2008 21:26:23 +0000 (22:26 +0100)]
contrib/examples/: Added an example for a notification callback.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd(1), README: Document notifications and related plugins.
Sebastian Harl [Tue, 5 Feb 2008 21:25:06 +0000 (22:25 +0100)]
collectd(1), README: Document notifications and related plugins.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectdmon(1): Added a section about supported signals.
Sebastian Harl [Tue, 5 Feb 2008 09:45:42 +0000 (10:45 +0100)]
collectdmon(1): Added a section about supported signals.

Documented the effects of the SIGINT, SIGTERM and SIGHUP signals.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoREADME: Added "uuid" plugin to the list of available plugins.
Sebastian Harl [Tue, 5 Feb 2008 09:44:57 +0000 (10:44 +0100)]
README: Added "uuid" plugin to the list of available plugins.

 * Added an optional dependency on libhal.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoREADME: Updated package description.
Sebastian Harl [Tue, 5 Feb 2008 09:44:00 +0000 (10:44 +0100)]
README: Updated package description.

Added a note about the monitoring support (this has been copied from the
Debian package description).

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agosrc/configfile.c: Extend the `Include' statement to handle directories, too.
Florian Forster [Sat, 9 Feb 2008 16:44:34 +0000 (17:44 +0100)]
src/configfile.c: Extend the `Include' statement to handle directories, too.

Directories are included recursively. Files and directories begnning with a dot
are ignored. Symlinks are followed. You can crash collectd by looping the
symlinks.

16 years agoconfigure: Warn if librrd is not thread safe. collectd-4.3.0beta0
Sebastian Harl [Thu, 31 Jan 2008 21:21:41 +0000 (22:21 +0100)]
configure: Warn if librrd is not thread safe.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoplugin.c: Use an AVL tree to store the data sets.
Sebastian Harl [Tue, 29 Jan 2008 01:14:33 +0000 (02:14 +0100)]
plugin.c: Use an AVL tree to store the data sets.

The list of data sets is queried quite frequently but hardly ever modified.
Using an AVL tree instead of a linked list improves the search time from O(n)
to O(log n).

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoexec plugin: Fixed a possible (though very improbable) memory leak.
Sebastian Harl [Sun, 27 Jan 2008 22:26:41 +0000 (23:26 +0100)]
exec plugin: Fixed a possible (though very improbable) memory leak.

In case of an error, the program_list_and_notification_t pointer has not been
freed before calling pthread_exit() from exec_notification_one().

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoCollectd.pm: Use $interval_g instead of a hard-coded value.
Sebastian Harl [Tue, 29 Jan 2008 01:12:17 +0000 (02:12 +0100)]
Collectd.pm: Use $interval_g instead of a hard-coded value.

The hard-coded value was still legacy code from the time before the global
variables have been exported to Perl.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl.c: Unregister notifications in perl_shutdown().
Sebastian Harl [Tue, 29 Jan 2008 01:11:00 +0000 (02:11 +0100)]
perl.c: Unregister notifications in perl_shutdown().

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Fixed a bug in Collectd::plugin_unregister_data_set().
Sebastian Harl [Tue, 29 Jan 2008 01:10:13 +0000 (02:10 +0100)]
perl plugin: Fixed a bug in Collectd::plugin_unregister_data_set().

The function tried to access a nonexistent second argument.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agocollectd-perl(5): Added documentation for the notification support.
Sebastian Harl [Mon, 28 Jan 2008 11:23:55 +0000 (12:23 +0100)]
collectd-perl(5): Added documentation for the notification support.

Some minor errors have been fixed as well and the ChangeLog has been updated.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Exported plugin_dispatch_notification() to Perl.
Sebastian Harl [Mon, 28 Jan 2008 11:23:10 +0000 (12:23 +0100)]
perl plugin: Exported plugin_dispatch_notification() to Perl.

This adds the following function to collectd's Perl API:

Collectd::plugin_dispatch_notification:
  submit a notification to collectd's notification mechanism

  arguments:
  notif - notification

A notification is a reference to a hash with the following members:
  severity => $severity (default: NOTIF_FAILURE)
  time     => $time (default: time (NULL))
  message  => $msg
  host     => $host (default: hostname_g)
  plugin   => $plugin
  type     => $type
  plugin_instance => $instance
  type_instance   => $type_instance

The severity should be any of the Collectd::NOTIF_* constants.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoperl plugin: Added support to dispatch notifications to Perl plugins.
Sebastian Harl [Mon, 28 Jan 2008 11:20:29 +0000 (12:20 +0100)]
perl plugin: Added support to dispatch notifications to Perl plugins.

Perl plugin may now register a callback of type Collectd::TYPE_NOTIF which
accepts a single hash argument with the following members:

  severity
  time
  message
  host
  plugin
  plugin_instance
  type
  type_instance

Severity may be any of the following values (exported by the "notif" tag):

  Collectd::NOTIF_FAILURE
  Collectd::NOTIF_WARNING
  Collectd::NOTIF_OKAY

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoChangeLog: Describe changes to the perl plugin in more detail.
Sebastian Harl [Sun, 27 Jan 2008 22:04:13 +0000 (23:04 +0100)]
ChangeLog: Describe changes to the perl plugin in more detail.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoconfigure.in: Fixed handling of the --with-perl-bindings option.
Sebastian Harl [Sun, 27 Jan 2008 15:13:44 +0000 (16:13 +0100)]
configure.in: Fixed handling of the --with-perl-bindings option.

This option could not be disabled so far as this case has not been handled in
the configure script. This patch fixes this issue.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
16 years agoMerge branch 'collectd-4.2'
Florian Forster [Wed, 23 Jan 2008 19:54:10 +0000 (20:54 +0100)]
Merge branch 'collectd-4.2'

16 years agoMerge branch 'collectd-4.1' into collectd-4.2
Florian Forster [Wed, 23 Jan 2008 19:53:57 +0000 (20:53 +0100)]
Merge branch 'collectd-4.1' into collectd-4.2