collectd.git
9 years agobattery plugin: Import code to read metrics from sysfs.
Florian Forster [Wed, 10 Sep 2014 14:53:51 +0000 (16:53 +0200)]
battery plugin: Import code to read metrics from sysfs.

This started as a simple import of Andy Parkins' sysfsbattery plugin into
the battery plugin. Since the battery plugin is ancient and hasn't been
touched in a while, this quickly escalated to a much bigger refactoring.
Sorry!

On the other hand, this fixes a couple of bugs. For example, all metrics
were always dispatched with plugin_instance "0". This is correct for the
majority of laptops, of course, but in theory this could be wrong.

Also ACPI charging / discharging rate is reported as "current", when
modern batteries actually report "power". The sysfs code does this
correctly, ACPI still needs to be patched.

Fixes: #725

9 years agosrc/common.[ch]: Implement strtogauge().
Florian Forster [Wed, 10 Sep 2014 14:15:40 +0000 (16:15 +0200)]
src/common.[ch]: Implement strtogauge().

9 years agosrc/configfile.c: Fix the default interval setting.
Florian Forster [Tue, 9 Sep 2014 21:43:11 +0000 (23:43 +0200)]
src/configfile.c: Fix the default interval setting.

Also fixes a bug in global_option_get_time(): Values smaller than or
equal to zero are illegal and the default value should be returned.
Thanks to @anandkarthik for spotting this!

Fixes: #727

9 years agoRPM specfile: take all new plugins and dependencies in account
Marc Fournier [Mon, 8 Sep 2014 13:10:18 +0000 (15:10 +0200)]
RPM specfile: take all new plugins and dependencies in account

9 years agoMerge branch 'collectd-5.4'
Marc Fournier [Mon, 8 Sep 2014 15:32:54 +0000 (17:32 +0200)]
Merge branch 'collectd-5.4'

9 years agoRPM specfile: enable lvm plugin on RHEL7
Marc Fournier [Mon, 8 Sep 2014 15:29:14 +0000 (17:29 +0200)]
RPM specfile: enable lvm plugin on RHEL7

9 years agoMerge branch 'collectd-5.3' into collectd-5.4
Marc Fournier [Mon, 8 Sep 2014 15:21:38 +0000 (17:21 +0200)]
Merge branch 'collectd-5.3' into collectd-5.4

Conflicts:
contrib/redhat/collectd.spec

9 years agoMerge remote-tracking branch 'github/master'
Florian Forster [Mon, 8 Sep 2014 15:11:56 +0000 (17:11 +0200)]
Merge remote-tracking branch 'github/master'

9 years agoprocesses plugin: Limit the buffer size used for command line matching.
Florian Forster [Mon, 8 Sep 2014 15:07:39 +0000 (17:07 +0200)]
processes plugin: Limit the buffer size used for command line matching.

ARG_MAX is quite big on many systems, for example >100 kByte on
GNU/Linux. This is a problem for systems with tight memory constraints,
for example embedded devices.

This patch uses at most 4 kByte for this, which out to be enough for the
vast majority of users. Users with specific requirements can compile
with "CMDLINE_BUFFER_SIZE=${LOTS}" in their CPPFLAGS to override this
default.

Fixes: #652

9 years agoRPM specfile: enable netlink plugin on RHEL > 5
Marc Fournier [Mon, 8 Sep 2014 14:59:30 +0000 (16:59 +0200)]
RPM specfile: enable netlink plugin on RHEL > 5

9 years agoRPM specfile: fix bogus dates
Marc Fournier [Mon, 8 Sep 2014 14:42:14 +0000 (16:42 +0200)]
RPM specfile: fix bogus dates

modern rpmbuild versions appear to be more strict on this point.

9 years agoRPM specfile: support for RHEL7
Marc Fournier [Mon, 8 Sep 2014 14:41:21 +0000 (16:41 +0200)]
RPM specfile: support for RHEL7

9 years agoRPM specfile: add missing %files section for modbus plugin
Marc Fournier [Mon, 8 Sep 2014 12:12:51 +0000 (14:12 +0200)]
RPM specfile: add missing %files section for modbus plugin

complement to a781eb2c5

9 years agoRPM specfile: remove define accidentally re-added when handling merge conflict
Marc Fournier [Mon, 8 Sep 2014 10:49:49 +0000 (12:49 +0200)]
RPM specfile: remove define accidentally re-added when handling merge conflict

9 years agoRPM specfile: remove macro accidentally re-added when handling merge conflict
Marc Fournier [Mon, 8 Sep 2014 10:38:53 +0000 (12:38 +0200)]
RPM specfile: remove macro accidentally re-added when handling merge conflict

9 years agoRPM specfile: remove duplicate modbus block
Marc Fournier [Mon, 8 Sep 2014 10:26:55 +0000 (12:26 +0200)]
RPM specfile: remove duplicate modbus block

9 years agoimprove CollectInternalStats's documentation
Marc Fournier [Fri, 29 Aug 2014 15:07:18 +0000 (17:07 +0200)]
improve CollectInternalStats's documentation

9 years agoMerge remote-tracking branch 'origin/pr/691'
Marc Fournier [Mon, 8 Sep 2014 09:41:25 +0000 (11:41 +0200)]
Merge remote-tracking branch 'origin/pr/691'

9 years agoMerge branch 'pr-713'
Florian Forster [Mon, 8 Sep 2014 09:21:50 +0000 (11:21 +0200)]
Merge branch 'pr-713'

9 years agosrc/plugin.c: Parse "MaxReadInterval" with global_option_get_time().
Florian Forster [Mon, 8 Sep 2014 09:19:26 +0000 (11:19 +0200)]
src/plugin.c: Parse "MaxReadInterval" with global_option_get_time().

9 years agosrc/configfile.[ch]: Implement global_option_get_time().
Florian Forster [Mon, 8 Sep 2014 09:16:39 +0000 (11:16 +0200)]
src/configfile.[ch]: Implement global_option_get_time().

9 years agosrc/configfile.c: Use cf_util_get_cdtime() to parse the "Interval" settings.
Florian Forster [Mon, 8 Sep 2014 09:16:18 +0000 (11:16 +0200)]
src/configfile.c: Use cf_util_get_cdtime() to parse the "Interval" settings.

9 years agoset target: Simplify config parsing.
Florian Forster [Sun, 7 Sep 2014 06:13:19 +0000 (08:13 +0200)]
set target: Simplify config parsing.

9 years agodisk plugin: Add metric for pending I/O operations.
Florian Forster [Sat, 6 Sep 2014 09:47:37 +0000 (11:47 +0200)]
disk plugin: Add metric for pending I/O operations.

This is only supported on Linux right now.

Fixes: #705

9 years agoMerge branch 'collectd-5.4'
Florian Forster [Sat, 6 Sep 2014 09:30:20 +0000 (11:30 +0200)]
Merge branch 'collectd-5.4'

9 years agoMerge branch 'collectd-5.3' into collectd-5.4
Florian Forster [Sat, 6 Sep 2014 09:27:56 +0000 (11:27 +0200)]
Merge branch 'collectd-5.3' into collectd-5.4

Conflicts:
src/curl.c

9 years agonetwork plugin: Improve client connecting behavior.
Florian Forster [Sat, 6 Sep 2014 08:58:45 +0000 (10:58 +0200)]
network plugin: Improve client connecting behavior.

This moves the socket creation logic so it's called from
networt_send_buffer_plain(). This allows us to recover after network
failures or when collectd was started before the network was available.

Fixes: #627

9 years agonetwork plugin: Improve "Buffer too small" error message.
Florian Forster [Fri, 5 Sep 2014 13:54:48 +0000 (15:54 +0200)]
network plugin: Improve "Buffer too small" error message.

References: #724

9 years agowrite_http plugin: Don't compare pointer with numeric literal.
Florian Forster [Fri, 5 Sep 2014 05:16:20 +0000 (07:16 +0200)]
write_http plugin: Don't compare pointer with numeric literal.

Not even zero. Not even once.

References: #722

9 years agocollectd.conf(5): s/metircs/metrics/
Florian Forster [Thu, 4 Sep 2014 08:54:35 +0000 (10:54 +0200)]
collectd.conf(5): s/metircs/metrics/

9 years agocollectd.conf(5): Improve markup of the write_kafka documentation.
Florian Forster [Thu, 4 Sep 2014 05:20:14 +0000 (07:20 +0200)]
collectd.conf(5): Improve markup of the write_kafka documentation.

9 years agowrite_http plugin: Implement the "BufferSize" option.
Florian Forster [Thu, 4 Sep 2014 05:18:51 +0000 (07:18 +0200)]
write_http plugin: Implement the "BufferSize" option.

Fixes: #722

9 years agosrc/utils_match.[ch]: Implement match_value_reset().
Florian Forster [Wed, 3 Sep 2014 07:10:00 +0000 (09:10 +0200)]
src/utils_match.[ch]: Implement match_value_reset().

This is called from the curl and memcachec plugins. Previously, gauge
average, minimum and maximum values were calculated since the start of
the daemon, rather than per-interval. This is not the documented
functionality.

Fixes: #663

9 years agocurl plugin: Use the utility functions for config handling.
Florian Forster [Wed, 3 Sep 2014 05:39:27 +0000 (07:39 +0200)]
curl plugin: Use the utility functions for config handling.

9 years agoMerge remote-tracking branch 'github/collectd-5.3' into collectd-5.3
Florian Forster [Tue, 2 Sep 2014 17:51:37 +0000 (19:51 +0200)]
Merge remote-tracking branch 'github/collectd-5.3' into collectd-5.3

9 years agosrc/meta_data.c: If the meta_data_t is empty, avoid calling malloc(0).
Florian Forster [Tue, 2 Sep 2014 17:50:47 +0000 (19:50 +0200)]
src/meta_data.c: If the meta_data_t is empty, avoid calling malloc(0).

9 years agosrc/utils_format_json.c: Handle empty meta_data_t gracefully.
Florian Forster [Tue, 2 Sep 2014 17:49:11 +0000 (19:49 +0200)]
src/utils_format_json.c: Handle empty meta_data_t gracefully.

Previously, `meta != NULL` and `keys_num == 0` was possible and would
result in "{}", which is not valid JSON.

Fixes: 716

9 years agopython plugin: Don't create empty meta_data_t objects.
Florian Forster [Tue, 2 Sep 2014 17:48:10 +0000 (19:48 +0200)]
python plugin: Don't create empty meta_data_t objects.

Fixes: #716

9 years agosrc/utils_rrdcreate.c: Free "args".
Florian Forster [Tue, 2 Sep 2014 14:54:07 +0000 (16:54 +0200)]
src/utils_rrdcreate.c: Free "args".

Thanks to Yves Mettier for pointing this out!

Fixes: #661

9 years agoopenldap: properly free allocated resources on transient errors
Marc Fournier [Mon, 1 Sep 2014 11:26:38 +0000 (13:26 +0200)]
openldap: properly free allocated resources on transient errors

9 years agoopenldap: remove unused element from ldap_s struct
Marc Fournier [Mon, 1 Sep 2014 11:22:39 +0000 (13:22 +0200)]
openldap: remove unused element from ldap_s struct

9 years agoopenldap: Remove custom string/bool/int config functions.
Marc Fournier [Mon, 1 Sep 2014 11:00:00 +0000 (13:00 +0200)]
openldap: Remove custom string/bool/int config functions.

Roughly the equivalent of e4ab153f9, as this part of the code was copied
from the apache plugin.

9 years agoMerge pull request #695 from mfournier/curlopt_username-fixups
Marc Fournier [Mon, 1 Sep 2014 08:29:34 +0000 (10:29 +0200)]
Merge pull request #695 from mfournier/curlopt_username-fixups

Allow curl digest feature to build against older libcurl versions

9 years agoparse option MaxReadInterval in the plugin_init_all()
Alexey Remizov [Sun, 31 Aug 2014 17:33:06 +0000 (21:33 +0400)]
parse option MaxReadInterval in the plugin_init_all()

9 years agoapache plugin: Remove custom string/bool config functions.
Florian Forster [Sun, 31 Aug 2014 06:40:37 +0000 (08:40 +0200)]
apache plugin: Remove custom string/bool config functions.

9 years agoMerge branch 'collectd-5.3' into collectd-5.4
Marc Fournier [Fri, 29 Aug 2014 15:26:41 +0000 (17:26 +0200)]
Merge branch 'collectd-5.3' into collectd-5.4

Conflicts:
contrib/redhat/collectd.spec

9 years agoRPM specfile: update changelog without incrementing release number
Marc Fournier [Fri, 29 Aug 2014 15:20:57 +0000 (17:20 +0200)]
RPM specfile: update changelog without incrementing release number

9 years agoopenldap: initialize StartTLS option to it's default value
Marc Fournier [Wed, 20 Aug 2014 12:07:27 +0000 (14:07 +0200)]
openldap: initialize StartTLS option to it's default value

9 years agoopenldap: documentation improvements
Marc Fournier [Wed, 20 Aug 2014 11:58:12 +0000 (13:58 +0200)]
openldap: documentation improvements

9 years agoopenldap: coding style consistency
Marc Fournier [Wed, 20 Aug 2014 10:28:09 +0000 (12:28 +0200)]
openldap: coding style consistency

9 years agoopenldap: prefer using ldap_err2string() over sstrerror()
Marc Fournier [Wed, 20 Aug 2014 10:27:21 +0000 (12:27 +0200)]
openldap: prefer using ldap_err2string() over sstrerror()

9 years agoopenldap: add missing support for "Timeout" config option
Marc Fournier [Wed, 20 Aug 2014 10:13:31 +0000 (12:13 +0200)]
openldap: add missing support for "Timeout" config option

9 years agoopenldap: initialize LDAP library before collectd goes multi-threaded
Marc Fournier [Wed, 20 Aug 2014 08:13:14 +0000 (10:13 +0200)]
openldap: initialize LDAP library before collectd goes multi-threaded

9 years agoopenldap: terminate attrs array with NULL
Marc Fournier [Tue, 19 Aug 2014 11:54:53 +0000 (13:54 +0200)]
openldap: terminate attrs array with NULL

... as mentioned in ldap_search_ext_s(3). This fixes a segfault when
building with -O2.

9 years agoopenldap: use ldap_unbind_ext_s() to avoid memory leak
Marc Fournier [Tue, 1 Jul 2014 15:31:07 +0000 (17:31 +0200)]
openldap: use ldap_unbind_ext_s() to avoid memory leak

... as ldap_destroy() is only available in newer libldap versions.

9 years agoopenldap: revert change leading to use of uninitialised variable
Marc Fournier [Tue, 1 Jul 2014 15:29:45 +0000 (17:29 +0200)]
openldap: revert change leading to use of uninitialised variable

this was preventing build with -Wall

9 years agoopenldap: move config-handling functions after ldap_read_host()
Marc Fournier [Tue, 1 Jul 2014 12:49:30 +0000 (14:49 +0200)]
openldap: move config-handling functions after ldap_read_host()

This prevents the need for a dummy ldap_read_host() declaration.

9 years agoopenldap: coding style consistency
Marc Fournier [Tue, 1 Jul 2014 12:47:24 +0000 (14:47 +0200)]
openldap: coding style consistency

9 years agoopenldap: fix double-free error on shutdown
Marc Fournier [Tue, 1 Jul 2014 12:32:27 +0000 (14:32 +0200)]
openldap: fix double-free error on shutdown

This is already handled by ldap_unbind_ext_s() on line 739

9 years agoopenldap: prepend function names with ldap_ to avoid confusion with apache plugin
Marc Fournier [Tue, 1 Jul 2014 12:12:05 +0000 (14:12 +0200)]
openldap: prepend function names with ldap_ to avoid confusion with apache plugin

9 years agoopenldap: monitor every BDB-based database's cache
Marc Fournier [Tue, 1 Jul 2014 12:04:10 +0000 (14:04 +0200)]
openldap: monitor every BDB-based database's cache

9 years agoopenldap: add threads monitoring
Marc Fournier [Mon, 30 Jun 2014 16:03:47 +0000 (18:03 +0200)]
openldap: add threads monitoring

9 years agoopenldap: fix leak when reading from server fails
Marc Fournier [Mon, 30 Jun 2014 14:42:54 +0000 (16:42 +0200)]
openldap: fix leak when reading from server fails

9 years agoopenldap: fix typo preventing PDU stats from getting collected
Marc Fournier [Mon, 30 Jun 2014 14:40:20 +0000 (16:40 +0200)]
openldap: fix typo preventing PDU stats from getting collected

9 years agoopenldap: note starttls in the doc
Kimo Rosenbaum [Tue, 18 Jan 2011 21:46:35 +0000 (13:46 -0800)]
openldap: note starttls in the doc

9 years agonew plugin: openldap
Kimo Rosenbaum [Tue, 18 Jan 2011 21:35:23 +0000 (13:35 -0800)]
new plugin: openldap

9 years agosrc/collectd.h: Enable __attribute__() for clang, too.
Florian Forster [Fri, 29 Aug 2014 09:14:31 +0000 (11:14 +0200)]
src/collectd.h: Enable __attribute__() for clang, too.

9 years agoGenericJMXConfConnection: Remove unused imports.
Florian Forster [Thu, 28 Aug 2014 18:55:45 +0000 (20:55 +0200)]
GenericJMXConfConnection: Remove unused imports.

9 years agojava plugin: Make sure cjni_thread_detach() is called on all paths.
Florian Forster [Thu, 28 Aug 2014 18:41:25 +0000 (20:41 +0200)]
java plugin: Make sure cjni_thread_detach() is called on all paths.

Each call to cjni_thread_attach() much be accompanied by
a call to cjni_thread_detach(). Some error handling cases were missing
the call, potentially locking the plugin up.

9 years agocollectd.conf(5): Improve AutoLoadPlugin documentation.
Florian Forster [Fri, 29 Aug 2014 05:00:33 +0000 (07:00 +0200)]
collectd.conf(5): Improve AutoLoadPlugin documentation.

Make it clear that plugins without a <Plugin /> block will still need a
LoadPlugin line.

References: #715

9 years agocollectd.conf(5): Improve documentation of LoadPlugin.
Florian Forster [Wed, 27 Aug 2014 11:04:59 +0000 (13:04 +0200)]
collectd.conf(5): Improve documentation of LoadPlugin.

Mention AutoLoadPlugin in the relevant places. Add a <Plugin /> block
for the "df" plugin to make it easier to spot that it is preceded by a
<LoadPlugin /> *block*.

Fixes: #715

9 years agorenamed the option to CollectInternalStats; renamed 'internal' to 'collectd'; no...
Yves Mettier [Tue, 26 Aug 2014 11:02:49 +0000 (13:02 +0200)]
renamed the option to CollectInternalStats; renamed 'internal' to 'collectd'; no more lock when not recording internal stats

9 years agodocument MaxReadInterval option
Alexey Remizov [Mon, 25 Aug 2014 14:05:25 +0000 (18:05 +0400)]
document MaxReadInterval option

9 years agonb_values missing in types.db; renaming as cache_size
Yves Mettier [Mon, 25 Aug 2014 11:47:33 +0000 (13:47 +0200)]
nb_values missing in types.db; renaming as cache_size

9 years agorename option MaxEffectiveInterval -> MaxReadInterval
Alexey Remizov [Mon, 25 Aug 2014 07:58:24 +0000 (11:58 +0400)]
rename option MaxEffectiveInterval -> MaxReadInterval

9 years agoMerge branch 'feature/ZOL'
Marc Fournier [Fri, 22 Aug 2014 21:22:34 +0000 (23:22 +0200)]
Merge branch 'feature/ZOL'

Conflicts:
configure.ac

9 years agoEL <6 provide perl-ExtUtils-Embed with base perl
Kevin Bowling [Thu, 14 Aug 2014 09:30:45 +0000 (02:30 -0700)]
EL <6 provide perl-ExtUtils-Embed with base perl

Conflicts:
contrib/redhat/collectd.spec

9 years agoallow to configure the maximum effective interval between attempts to read data by...
Alexey Remizov [Fri, 22 Aug 2014 07:02:47 +0000 (11:02 +0400)]
allow to configure the maximum effective interval between attempts to read data by plugins

9 years agoMerge remote-tracking branch 'github/pr/706'
Florian Forster [Fri, 22 Aug 2014 05:23:28 +0000 (07:23 +0200)]
Merge remote-tracking branch 'github/pr/706'

Conflicts:
src/write_riemann.c

9 years agoSmall naming conventions fixes, let the user to choose its delimiter
Moshe Zada [Thu, 21 Aug 2014 12:23:27 +0000 (15:23 +0300)]
Small naming conventions fixes, let the user to choose its delimiter

9 years agos/appended/used/ according to PR 706
Moshe Zada [Thu, 21 Aug 2014 06:06:31 +0000 (09:06 +0300)]
s/appended/used/ according to PR 706

9 years agoStatsd: support samplerate field in timing metric types
John Leach [Mon, 18 Aug 2014 20:36:35 +0000 (21:36 +0100)]
Statsd: support samplerate field in timing metric types

Fixes "Unable to parse line" bug, often seen receiving stats from
OpenStack Swift. Should fix GH issue #461

9 years agoMerge remote-tracking branch 'github/pr/711'
Florian Forster [Thu, 21 Aug 2014 05:47:03 +0000 (07:47 +0200)]
Merge remote-tracking branch 'github/pr/711'

9 years agoMerge pull request #712 from tas50/master
Marc Fournier [Wed, 20 Aug 2014 19:13:34 +0000 (21:13 +0200)]
Merge pull request #712 from tas50/master

Fix spelling and split words where appropriate in readme / authors

9 years agoFix spelling and split words where appropriate in readme / authors
Tim Smith [Wed, 20 Aug 2014 19:04:37 +0000 (12:04 -0700)]
Fix spelling and split words where appropriate in readme / authors

9 years agoStatsd: support samplerate field in timing metric types
John Leach [Mon, 18 Aug 2014 20:36:35 +0000 (21:36 +0100)]
Statsd: support samplerate field in timing metric types

Fixes "Unable to parse line" bug, often seen receiving stats from
OpenStack Swift. Should fix GH issue #461

9 years agocollectd.conf: Fix default packet size of the network plugin.
Florian Forster [Mon, 18 Aug 2014 07:58:34 +0000 (09:58 +0200)]
collectd.conf: Fix default packet size of the network plugin.

Fixes: #710

9 years agoMerge branch 'collectd-5.4'
Florian Forster [Mon, 18 Aug 2014 07:50:34 +0000 (09:50 +0200)]
Merge branch 'collectd-5.4'

Conflicts:
configure.ac
src/curl_json.c
src/lvm.c
src/write_riemann.c

9 years agoMerge branch 'collectd-5.3' into collectd-5.4
Florian Forster [Mon, 18 Aug 2014 07:35:04 +0000 (09:35 +0200)]
Merge branch 'collectd-5.3' into collectd-5.4

Conflicts:
contrib/redhat/collectd.spec

9 years agoMerge branch 'collectd-4.10' into collectd-5.3
Florian Forster [Mon, 18 Aug 2014 07:33:29 +0000 (09:33 +0200)]
Merge branch 'collectd-4.10' into collectd-5.3

9 years agocurl_xml plugin: Fixed tautological pointer comparison error.
Arthur Marble [Sun, 17 Aug 2014 22:34:04 +0000 (17:34 -0500)]
curl_xml plugin: Fixed tautological pointer comparison error.

Fixes: http://bugs.debian.org/758481
Signed-off-by: Florian Forster <octo@collectd.org>
9 years agorename prefix variable to eventServicePrefix
~/.gitconfig [Sun, 17 Aug 2014 14:19:55 +0000 (17:19 +0300)]
rename prefix variable to eventServicePrefix

9 years agocheck the status of cf_util_get_string
~/.gitconfig [Sun, 17 Aug 2014 14:16:34 +0000 (17:16 +0300)]
check the status of cf_util_get_string

9 years agoignore EventServicePrefix when its empty ("")
~/.gitconfig [Sun, 17 Aug 2014 08:45:19 +0000 (11:45 +0300)]
ignore EventServicePrefix when its empty ("")

9 years agoAdd documentation about the plugin in the pod file
~/.gitconfig [Sun, 17 Aug 2014 07:01:44 +0000 (10:01 +0300)]
Add documentation about the plugin in the pod file

9 years agoFix indentation, change Prefix to EventServicePrefix
~/.gitconfig [Fri, 15 Aug 2014 18:46:02 +0000 (21:46 +0300)]
Fix indentation, change Prefix to EventServicePrefix

9 years agoMerge remote-tracking branch 'github/pr/703'
Florian Forster [Thu, 14 Aug 2014 15:49:52 +0000 (17:49 +0200)]
Merge remote-tracking branch 'github/pr/703'

9 years agohandle prefix=null
~/.gitconfig [Thu, 14 Aug 2014 14:37:10 +0000 (17:37 +0300)]
handle prefix=null

9 years agorefactor prefix feature - cast directly to service_buffer
~/.gitconfig [Thu, 14 Aug 2014 13:50:24 +0000 (16:50 +0300)]
refactor prefix feature - cast directly to service_buffer

9 years ago[METRICS-383] Review fixes for octo
Kevin Bowling [Thu, 14 Aug 2014 09:21:17 +0000 (02:21 -0700)]
[METRICS-383] Review fixes for octo