From 6188d7d378e3598f8794c03530bb12f335235f4c Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Thu, 24 Nov 2016 10:16:00 +0100 Subject: [PATCH] virt plugin: Disable tests momentarily Old libvirts (<= 0.10.z, such as the version shipped on debian wheezy) depend on libnl-1. There is a small memory leak caused by the initialization of the library, and we have no means to avoid it. This causes valgrind to complain in the tests, creating a false positive. Anyway, libvirt switched to libnl-3, which should also fix this leak. The simplest solution is just to disable those tests until we can depend on libnl-3 enabled libvirt. --- src/Makefile.am | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0601ce9f..a389b3c4 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1284,9 +1284,12 @@ test_plugin_virt_CPPFLAGS = $(AM_CPPFLAGS) \ test_plugin_virt_LDFLAGS = $(PLUGIN_LDFLAGS) test_plugin_virt_LDADD = daemon/libplugin_mock.la \ $(BUILD_WITH_LIBVIRT_LIBS) $(BUILD_WITH_LIBXML2_LIBS) -check_PROGRAMS += test_plugin_virt -TESTS += test_plugin_virt - +# TODO: enable once we support only modern libvirts which depends on libnl-3 +# the libvirt on wheezy is linked in libnl v1, and there is a small leak here, +# triggered by the library initialization. There are no means to avoid it, +# and libvirt switched to libnl3 anyway +#check_PROGRAMS += test_plugin_virt +#TESTS += test_plugin_virt endif if BUILD_PLUGIN_VMEM -- 2.11.0