X-Git-Url: https://git.octo.it/?p=collectd.git;a=blobdiff_plain;f=src%2Fcpu.c;h=09d60fe469695882ecb803863b0e9417bb9e8b35;hp=8480f11a624e3e83298066567f308d172f3ef0cf;hb=54619dc85fd308b21ed09a0271e5c7383c7921b9;hpb=5a32acd88719481cc22aaecd36f3cbc11f3a3489 diff --git a/src/cpu.c b/src/cpu.c index 8480f11a..09d60fe4 100644 --- a/src/cpu.c +++ b/src/cpu.c @@ -29,8 +29,8 @@ #include "collectd.h" -#include "common.h" #include "plugin.h" +#include "utils/common/common.h" #ifdef HAVE_MACH_KERN_RETURN_H #include @@ -183,23 +183,23 @@ static int pnumcpu; struct cpu_state_s { value_to_rate_state_t conv; gauge_t rate; - _Bool has_value; + bool has_value; }; typedef struct cpu_state_s cpu_state_t; -static cpu_state_t *cpu_states = NULL; -static size_t cpu_states_num = 0; /* #cpu_states allocated */ +static cpu_state_t *cpu_states; +static size_t cpu_states_num; /* #cpu_states allocated */ /* Highest CPU number in the current iteration. Used by the dispatch logic to * determine how many CPUs there were. Reset to 0 by cpu_reset(). */ -static size_t global_cpu_num = 0; +static size_t global_cpu_num; -static _Bool report_by_cpu = 1; -static _Bool report_by_state = 1; -static _Bool report_percent = 0; -static _Bool report_num_cpu = 0; -static _Bool report_guest = 0; -static _Bool subtract_guest = 1; +static bool report_by_cpu = true; +static bool report_by_state = true; +static bool report_percent; +static bool report_num_cpu; +static bool report_guest; +static bool subtract_guest = true; static const char *config_keys[] = {"ReportByCpu", "ReportByState", "ReportNumCpu", "ValuesPercentage", @@ -209,17 +209,17 @@ static int config_keys_num = STATIC_ARRAY_SIZE(config_keys); static int cpu_config(char const *key, char const *value) /* {{{ */ { if (strcasecmp(key, "ReportByCpu") == 0) - report_by_cpu = IS_TRUE(value) ? 1 : 0; + report_by_cpu = IS_TRUE(value); else if (strcasecmp(key, "ValuesPercentage") == 0) - report_percent = IS_TRUE(value) ? 1 : 0; + report_percent = IS_TRUE(value); else if (strcasecmp(key, "ReportByState") == 0) - report_by_state = IS_TRUE(value) ? 1 : 0; + report_by_state = IS_TRUE(value); else if (strcasecmp(key, "ReportNumCpu") == 0) - report_num_cpu = IS_TRUE(value) ? 1 : 0; + report_num_cpu = IS_TRUE(value); else if (strcasecmp(key, "ReportGuestState") == 0) - report_guest = IS_TRUE(value) ? 1 : 0; + report_guest = IS_TRUE(value); else if (strcasecmp(key, "SubtractGuestState") == 0) - subtract_guest = IS_TRUE(value) ? 1 : 0; + subtract_guest = IS_TRUE(value); else return -1; @@ -251,7 +251,7 @@ static int init(void) { INFO("cpu plugin: Found %i processor%s.", (int)cpu_list_len, cpu_list_len == 1 ? "" : "s"); -/* #endif PROCESSOR_CPU_LOAD_INFO */ + /* #endif PROCESSOR_CPU_LOAD_INFO */ #elif defined(HAVE_LIBKSTAT) kstat_t *ksp_chain; @@ -267,7 +267,7 @@ static int init(void) { ksp_chain = ksp_chain->ks_next) if (strncmp(ksp_chain->ks_module, "cpu_stat", 8) == 0) ksp[numcpu++] = ksp_chain; -/* #endif HAVE_LIBKSTAT */ + /* #endif HAVE_LIBKSTAT */ #elif CAN_USE_SYSCTL size_t numcpu_size; @@ -282,7 +282,7 @@ static int init(void) { WARNING("cpu plugin: sysctl: %s", STRERRNO); return -1; } -/* #endif CAN_USE_SYSCTL */ + /* #endif CAN_USE_SYSCTL */ #elif defined(HAVE_SYSCTLBYNAME) size_t numcpu_size; @@ -307,7 +307,7 @@ static int init(void) { "%i)", numcpu); #endif -/* #endif HAVE_SYSCTLBYNAME */ + /* #endif HAVE_SYSCTLBYNAME */ #elif defined(HAVE_LIBSTATGRAB) /* nothing to initialize */ @@ -431,7 +431,7 @@ static void aggregate(gauge_t *sum_by_state) /* {{{ */ } if (!isnan(this_cpu_states[COLLECTD_CPU_STATE_ACTIVE].rate)) - this_cpu_states[COLLECTD_CPU_STATE_ACTIVE].has_value = 1; + this_cpu_states[COLLECTD_CPU_STATE_ACTIVE].has_value = true; RATE_ADD(sum_by_state[COLLECTD_CPU_STATE_ACTIVE], this_cpu_states[COLLECTD_CPU_STATE_ACTIVE].rate); @@ -505,7 +505,7 @@ static void cpu_commit_num_cpu(gauge_t value) /* {{{ */ static void cpu_reset(void) /* {{{ */ { for (size_t i = 0; i < cpu_states_num; i++) - cpu_states[i].has_value = 0; + cpu_states[i].has_value = false; global_cpu_num = 0; } /* }}} void cpu_reset */ @@ -588,7 +588,7 @@ static int cpu_stage(size_t cpu_num, size_t state, derive_t d, return status; s->rate = rate; - s->has_value = 1; + s->has_value = true; return 0; } /* }}} int cpu_stage */ @@ -630,7 +630,7 @@ static int cpu_read(void) { cpu_stage(cpu, COLLECTD_CPU_STATE_IDLE, (derive_t)cpu_info.cpu_ticks[CPU_STATE_IDLE], now); } -/* }}} #endif PROCESSOR_CPU_LOAD_INFO */ + /* }}} #endif PROCESSOR_CPU_LOAD_INFO */ #elif defined(KERNEL_LINUX) /* {{{ */ int cpu; @@ -708,7 +708,7 @@ static int cpu_read(void) { cpu_stage(cpu, COLLECTD_CPU_STATE_NICE, (derive_t)nice_value, now); } fclose(fh); -/* }}} #endif defined(KERNEL_LINUX) */ + /* }}} #endif defined(KERNEL_LINUX) */ #elif defined(HAVE_LIBKSTAT) /* {{{ */ static cpu_stat_t cs; @@ -729,7 +729,7 @@ static int cpu_read(void) { cpu_stage(ksp[cpu]->ks_instance, COLLECTD_CPU_STATE_WAIT, (derive_t)cs.cpu_sysinfo.cpu[CPU_WAIT], now); } -/* }}} #endif defined(HAVE_LIBKSTAT) */ + /* }}} #endif defined(HAVE_LIBKSTAT) */ #elif CAN_USE_SYSCTL /* {{{ */ uint64_t cpuinfo[numcpu][CPUSTATES]; @@ -786,10 +786,10 @@ static int cpu_read(void) { cpu_stage(i, COLLECTD_CPU_STATE_INTERRUPT, (derive_t)cpuinfo[i][CP_INTR], now); } -/* }}} #endif CAN_USE_SYSCTL */ + /* }}} #endif CAN_USE_SYSCTL */ #elif defined(HAVE_SYSCTLBYNAME) && defined(HAVE_SYSCTL_KERN_CP_TIMES) /* {{{ \ - */ + */ long cpuinfo[maxcpu][CPUSTATES]; size_t cpuinfo_size; @@ -809,7 +809,7 @@ static int cpu_read(void) { cpu_stage(i, COLLECTD_CPU_STATE_INTERRUPT, (derive_t)cpuinfo[i][CP_INTR], now); } -/* }}} #endif HAVE_SYSCTL_KERN_CP_TIMES */ + /* }}} #endif HAVE_SYSCTL_KERN_CP_TIMES */ #elif defined(HAVE_SYSCTLBYNAME) /* {{{ */ long cpuinfo[CPUSTATES]; @@ -827,7 +827,7 @@ static int cpu_read(void) { cpu_stage(0, COLLECTD_CPU_STATE_SYSTEM, (derive_t)cpuinfo[CP_SYS], now); cpu_stage(0, COLLECTD_CPU_STATE_IDLE, (derive_t)cpuinfo[CP_IDLE], now); cpu_stage(0, COLLECTD_CPU_STATE_INTERRUPT, (derive_t)cpuinfo[CP_INTR], now); -/* }}} #endif HAVE_SYSCTLBYNAME */ + /* }}} #endif HAVE_SYSCTLBYNAME */ #elif defined(HAVE_LIBSTATGRAB) /* {{{ */ sg_cpu_stats *cs; @@ -844,7 +844,7 @@ static int cpu_read(void) { cpu_state(0, COLLECTD_CPU_STATE_SYSTEM, (derive_t)cs->kernel); cpu_state(0, COLLECTD_CPU_STATE_USER, (derive_t)cs->user); cpu_state(0, COLLECTD_CPU_STATE_WAIT, (derive_t)cs->iowait); -/* }}} #endif HAVE_LIBSTATGRAB */ + /* }}} #endif HAVE_LIBSTATGRAB */ #elif defined(HAVE_PERFSTAT) /* {{{ */ perfstat_id_t id;