X-Git-Url: https://git.octo.it/?p=collectd.git;a=blobdiff_plain;f=src%2Fdaemon%2Fcollectd.c;h=9ec09347267f474c846d4807ceb065f9800ce493;hp=4df11bcf8f8491e732bd654e7443ad919a594a65;hb=1159cb5d383c55a80a0db100b8f7aadcf44740a5;hpb=065dbc0d449f7b0e8986635db0f9c481de64789d diff --git a/src/daemon/collectd.c b/src/daemon/collectd.c index 4df11bcf..9ec09347 100644 --- a/src/daemon/collectd.c +++ b/src/daemon/collectd.c @@ -76,10 +76,11 @@ static void sig_usr1_handler(int __attribute__((unused)) signal) { } static int init_hostname(void) { - const char *str; - - struct addrinfo *ai_list; - int status; + const char *str = global_option_get("Hostname"); + if ((str != NULL) && (str[0] != 0)) { + hostname_set(str); + return 0; + } long hostname_len = sysconf(_SC_HOST_NAME_MAX); if (hostname_len == -1) { @@ -87,25 +88,22 @@ static int init_hostname(void) { } char hostname[hostname_len]; - str = global_option_get("Hostname"); - if ((str != NULL) && (str[0] != 0)) { - hostname_set(str); - return 0; - } - if (gethostname(hostname, hostname_len) != 0) { fprintf(stderr, "`gethostname' failed and no " "hostname was configured.\n"); return -1; } + hostname_set(hostname); + str = global_option_get("FQDNLookup"); if (IS_FALSE(str)) return 0; + struct addrinfo *ai_list; struct addrinfo ai_hints = {.ai_flags = AI_CANONNAME}; - status = getaddrinfo(hostname, NULL, &ai_hints, &ai_list); + int status = getaddrinfo(hostname, NULL, &ai_hints, &ai_list); if (status != 0) { ERROR("Looking up \"%s\" failed. You have set the " "\"FQDNLookup\" option, but I cannot resolve " @@ -463,12 +461,11 @@ void read_cmdline(int argc, char **argv, struct cmdline_config *config) { /* read options */ while (1) { int c; - c = getopt(argc, argv, - "htTC:" + c = getopt(argc, argv, "htTC:" #if COLLECT_DAEMON - "fP:" + "fP:" #endif - ); + ); if (c == -1) break; @@ -553,9 +550,7 @@ int main(int argc, char **argv) { int exit_status = 0; struct cmdline_config config = { - .daemonize = 1, - .create_basedir = 1, - .configfile = CONFIGFILE, + .daemonize = 1, .create_basedir = 1, .configfile = CONFIGFILE, }; read_cmdline(argc, argv, &config); @@ -588,7 +583,7 @@ int main(int argc, char **argv) { #ifdef KERNEL_LINUX && notify_upstart() == 0 && notify_systemd() == 0 #endif - ) { + ) { int status; if ((pid = fork()) == -1) {