X-Git-Url: https://git.octo.it/?p=collectd.git;a=blobdiff_plain;f=src%2Fhddtemp.c;h=80daf15b7ef8e491f515dc166c6c9b22eceab2a3;hp=3af9c0fa640433ff89cd3cc8e6cfb98e7372da5a;hb=d486225f89ea52d8ed2b4242eba2ad94c409f837;hpb=b165cd13cd30a30ac830df1f6f6fbd52474a6f64 diff --git a/src/hddtemp.c b/src/hddtemp.c index 3af9c0fa..80daf15b 100644 --- a/src/hddtemp.c +++ b/src/hddtemp.c @@ -53,7 +53,7 @@ static const char *config_keys[] = {"Host", "Port"}; static int config_keys_num = STATIC_ARRAY_SIZE(config_keys); -static char *hddtemp_host = NULL; +static char *hddtemp_host; static char hddtemp_port[16]; /* @@ -108,10 +108,8 @@ static char *hddtemp_query_daemon(void) { .ai_socktype = SOCK_STREAM}; if ((ai_return = getaddrinfo(host, port, &ai_hints, &ai_list)) != 0) { - char errbuf[1024]; ERROR("hddtemp plugin: getaddrinfo (%s, %s): %s", host, port, - (ai_return == EAI_SYSTEM) ? sstrerror(errno, errbuf, sizeof(errbuf)) - : gai_strerror(ai_return)); + (ai_return == EAI_SYSTEM) ? STRERRNO : gai_strerror(ai_return)); return NULL; } @@ -121,17 +119,13 @@ static char *hddtemp_query_daemon(void) { /* create our socket descriptor */ fd = socket(ai_ptr->ai_family, ai_ptr->ai_socktype, ai_ptr->ai_protocol); if (fd < 0) { - char errbuf[1024]; - ERROR("hddtemp plugin: socket: %s", - sstrerror(errno, errbuf, sizeof(errbuf))); + ERROR("hddtemp plugin: socket: %s", STRERRNO); continue; } /* connect to the hddtemp daemon */ if (connect(fd, (struct sockaddr *)ai_ptr->ai_addr, ai_ptr->ai_addrlen)) { - char errbuf[1024]; - INFO("hddtemp plugin: connect (%s, %s) failed: %s", host, port, - sstrerror(errno, errbuf, sizeof(errbuf))); + INFO("hddtemp plugin: connect (%s, %s) failed: %s", host, port, STRERRNO); close(fd); fd = -1; continue; @@ -177,13 +171,11 @@ static char *hddtemp_query_daemon(void) { if (status == 0) { break; } else if (status == -1) { - char errbuf[1024]; if ((errno == EAGAIN) || (errno == EINTR)) continue; - ERROR("hddtemp plugin: Error reading from socket: %s", - sstrerror(errno, errbuf, sizeof(errbuf))); + ERROR("hddtemp plugin: Error reading from socket: %s", STRERRNO); close(fd); free(buffer); return NULL; @@ -214,7 +206,7 @@ static int hddtemp_config(const char *key, const char *value) { } else if (strcasecmp(key, "Port") == 0) { int port = (int)(atof(value)); if ((port > 0) && (port <= 65535)) - ssnprintf(hddtemp_port, sizeof(hddtemp_port), "%i", port); + snprintf(hddtemp_port, sizeof(hddtemp_port), "%i", port); else sstrncpy(hddtemp_port, value, sizeof(hddtemp_port)); } else {