X-Git-Url: https://git.octo.it/?p=collectd.git;a=blobdiff_plain;f=src%2Fload.c;h=858d9beacdf01536e49a8d8e825b4be97423a75f;hp=c7388605eb7dc0f765e2f3e4923cc012685c8aa9;hb=d486225f89ea52d8ed2b4242eba2ad94c409f837;hpb=004074af297a219208fa9e903db8c5dcdd7e1950 diff --git a/src/load.c b/src/load.c index c7388605..858d9bea 100644 --- a/src/load.c +++ b/src/load.c @@ -55,7 +55,7 @@ #include #endif /* HAVE_PERFSTAT */ -static _Bool report_relative_load = 0; +static bool report_relative_load; static const char *config_keys[] = {"ReportRelative"}; static int config_keys_num = STATIC_ARRAY_SIZE(config_keys); @@ -63,23 +63,21 @@ static int config_keys_num = STATIC_ARRAY_SIZE(config_keys); static int load_config(const char *key, const char *value) { if (strcasecmp(key, "ReportRelative") == 0) #ifdef _SC_NPROCESSORS_ONLN - report_relative_load = IS_TRUE(value) ? 1 : 0; + report_relative_load = IS_TRUE(value); #else WARNING("load plugin: The \"ReportRelative\" configuration " "is not available, because I can't determine the " "number of CPUS on this system. Sorry."); #endif - return (-1); + return -1; } static void load_submit(gauge_t snum, gauge_t mnum, gauge_t lnum) { int cores = 0; - char errbuf[1024]; #ifdef _SC_NPROCESSORS_ONLN if (report_relative_load) { if ((cores = sysconf(_SC_NPROCESSORS_ONLN)) < 1) { - WARNING("load: sysconf failed : %s", - sstrerror(errno, errbuf, sizeof(errbuf))); + WARNING("load: sysconf failed : %s", STRERRNO); } } #endif @@ -114,9 +112,7 @@ static int load_read(void) { if (getloadavg(load, 3) == 3) load_submit(load[LOADAVG_1MIN], load[LOADAVG_5MIN], load[LOADAVG_15MIN]); else { - char errbuf[1024]; - WARNING("load: getloadavg failed: %s", - sstrerror(errno, errbuf, sizeof(errbuf))); + WARNING("load: getloadavg failed: %s", STRERRNO); } /* #endif HAVE_GETLOADAVG */ @@ -129,27 +125,24 @@ static int load_read(void) { int numfields; if ((loadavg = fopen("/proc/loadavg", "r")) == NULL) { - char errbuf[1024]; - WARNING("load: fopen: %s", sstrerror(errno, errbuf, sizeof(errbuf))); - return (-1); + WARNING("load: fopen: %s", STRERRNO); + return -1; } if (fgets(buffer, 16, loadavg) == NULL) { - char errbuf[1024]; - WARNING("load: fgets: %s", sstrerror(errno, errbuf, sizeof(errbuf))); + WARNING("load: fgets: %s", STRERRNO); fclose(loadavg); - return (-1); + return -1; } if (fclose(loadavg)) { - char errbuf[1024]; - WARNING("load: fclose: %s", sstrerror(errno, errbuf, sizeof(errbuf))); + WARNING("load: fclose: %s", STRERRNO); } numfields = strsplit(buffer, fields, 8); if (numfields < 3) - return (-1); + return -1; snum = atof(fields[0]); mnum = atof(fields[1]); @@ -177,10 +170,8 @@ static int load_read(void) { if (perfstat_cpu_total(NULL, &cputotal, sizeof(perfstat_cpu_total_t), 1) < 0) { - char errbuf[1024]; - WARNING("load: perfstat_cpu : %s", - sstrerror(errno, errbuf, sizeof(errbuf))); - return (-1); + WARNING("load: perfstat_cpu : %s", STRERRNO); + return -1; } snum = (float)cputotal.loadavg[0] / (float)(1 << SBITS); @@ -193,7 +184,7 @@ static int load_read(void) { #error "No applicable input method." #endif - return (0); + return 0; } void module_register(void) {