X-Git-Url: https://git.octo.it/?p=collectd.git;a=blobdiff_plain;f=src%2Fsmart.c;h=373839e13fb7ea565cdcf68685c7b0b5d985cc0a;hp=285eb860e480d7c5944658e793ca9b0a25088768;hb=936c450a86c841eea89888c8550c9118fae90c25;hpb=77ad300d75ce59bf4d49d839a2af72e90590033c diff --git a/src/smart.c b/src/smart.c index 285eb860..373839e1 100644 --- a/src/smart.c +++ b/src/smart.c @@ -33,74 +33,58 @@ #include #include -static const char *config_keys[] = -{ - "Disk", - "IgnoreSelected", - "IgnoreSleepMode", - "UseSerial" -}; +static const char *config_keys[] = {"Disk", "IgnoreSelected", "IgnoreSleepMode", + "UseSerial"}; -static int config_keys_num = STATIC_ARRAY_SIZE (config_keys); +static int config_keys_num = STATIC_ARRAY_SIZE(config_keys); static ignorelist_t *ignorelist = NULL; static int ignore_sleep_mode = 0; static int use_serial = 0; -static int smart_config (const char *key, const char *value) -{ +static int smart_config(const char *key, const char *value) { if (ignorelist == NULL) - ignorelist = ignorelist_create (/* invert = */ 1); + ignorelist = ignorelist_create(/* invert = */ 1); if (ignorelist == NULL) return (1); - if (strcasecmp ("Disk", key) == 0) - { - ignorelist_add (ignorelist, value); - } - else if (strcasecmp ("IgnoreSelected", key) == 0) - { + if (strcasecmp("Disk", key) == 0) { + ignorelist_add(ignorelist, value); + } else if (strcasecmp("IgnoreSelected", key) == 0) { int invert = 1; - if (IS_TRUE (value)) + if (IS_TRUE(value)) invert = 0; - ignorelist_set_invert (ignorelist, invert); - } - else if (strcasecmp ("IgnoreSleepMode", key) == 0) - { - if (IS_TRUE (value)) + ignorelist_set_invert(ignorelist, invert); + } else if (strcasecmp("IgnoreSleepMode", key) == 0) { + if (IS_TRUE(value)) ignore_sleep_mode = 1; - } - else if (strcasecmp ("UseSerial", key) == 0) - { - if (IS_TRUE (value)) + } else if (strcasecmp("UseSerial", key) == 0) { + if (IS_TRUE(value)) use_serial = 1; - } - else - { + } else { return (-1); } return (0); } /* int smart_config */ -static void smart_submit (const char *dev, const char *type, - const char *type_inst, double value) -{ - value_list_t vl = VALUE_LIST_INIT; +static void smart_submit(const char *dev, const char *type, + const char *type_inst, double value) { + value_list_t vl = VALUE_LIST_INIT; - vl.values = &(value_t) { .gauge = value }; - vl.values_len = 1; - sstrncpy (vl.plugin, "smart", sizeof (vl.plugin)); - sstrncpy (vl.plugin_instance, dev, sizeof (vl.plugin_instance)); - sstrncpy (vl.type, type, sizeof (vl.type)); - sstrncpy (vl.type_instance, type_inst, sizeof (vl.type_instance)); + vl.values = &(value_t){.gauge = value}; + vl.values_len = 1; + sstrncpy(vl.plugin, "smart", sizeof(vl.plugin)); + sstrncpy(vl.plugin_instance, dev, sizeof(vl.plugin_instance)); + sstrncpy(vl.type, type, sizeof(vl.type)); + sstrncpy(vl.type_instance, type_inst, sizeof(vl.type_instance)); - plugin_dispatch_values (&vl); + plugin_dispatch_values(&vl); } -static void smart_handle_disk_attribute(SkDisk *d, const SkSmartAttributeParsedData *a, - void* userdata) -{ +static void smart_handle_disk_attribute(SkDisk *d, + const SkSmartAttributeParsedData *a, + void *userdata) { const char *dev = userdata; if (!a->current_value_valid || !a->worst_value_valid) @@ -108,43 +92,35 @@ static void smart_handle_disk_attribute(SkDisk *d, const SkSmartAttributeParsedD value_list_t vl = VALUE_LIST_INIT; value_t values[] = { - { .gauge = a->current_value }, - { .gauge = a->worst_value }, - { .gauge = a->threshold_valid ? a->threshold : 0 }, - { .gauge = a->pretty_value }, + {.gauge = a->current_value}, + {.gauge = a->worst_value}, + {.gauge = a->threshold_valid ? a->threshold : 0}, + {.gauge = a->pretty_value}, }; vl.values = values; - vl.values_len = STATIC_ARRAY_SIZE (values); - sstrncpy (vl.plugin, "smart", sizeof (vl.plugin)); - sstrncpy (vl.plugin_instance, dev, sizeof (vl.plugin_instance)); - sstrncpy (vl.type, "smart_attribute", sizeof (vl.type)); - sstrncpy (vl.type_instance, a->name, sizeof (vl.type_instance)); - - plugin_dispatch_values (&vl); - - if (a->threshold_valid && a->current_value <= a->threshold) - { - notification_t notif = { NOTIF_WARNING, - cdtime (), - "", - "", - "smart", "", - "smart_attribute", - "", - NULL }; - sstrncpy (notif.host, hostname_g, sizeof (notif.host)); - sstrncpy (notif.plugin_instance, dev, sizeof (notif.plugin_instance)); - sstrncpy (notif.type_instance, a->name, sizeof (notif.type_instance)); - ssnprintf (notif.message, sizeof (notif.message), - "attribute %s is below allowed threshold (%d < %d)", - a->name, a->current_value, a->threshold); - plugin_dispatch_notification (¬if); + vl.values_len = STATIC_ARRAY_SIZE(values); + sstrncpy(vl.plugin, "smart", sizeof(vl.plugin)); + sstrncpy(vl.plugin_instance, dev, sizeof(vl.plugin_instance)); + sstrncpy(vl.type, "smart_attribute", sizeof(vl.type)); + sstrncpy(vl.type_instance, a->name, sizeof(vl.type_instance)); + + plugin_dispatch_values(&vl); + + if (a->threshold_valid && a->current_value <= a->threshold) { + notification_t notif = {NOTIF_WARNING, cdtime(), "", "", "smart", "", + "smart_attribute", "", NULL}; + sstrncpy(notif.host, hostname_g, sizeof(notif.host)); + sstrncpy(notif.plugin_instance, dev, sizeof(notif.plugin_instance)); + sstrncpy(notif.type_instance, a->name, sizeof(notif.type_instance)); + ssnprintf(notif.message, sizeof(notif.message), + "attribute %s is below allowed threshold (%d < %d)", a->name, + a->current_value, a->threshold); + plugin_dispatch_notification(¬if); } } -static void smart_handle_disk (const char *dev, const char *serial) -{ +static void smart_handle_disk(const char *dev, const char *serial) { SkDisk *d = NULL; SkBool awake = FALSE; SkBool available = FALSE; @@ -152,105 +128,82 @@ static void smart_handle_disk (const char *dev, const char *serial) const SkSmartParsedData *spd; uint64_t poweron, powercycles, badsectors, temperature; - if (use_serial && serial) - { + if (use_serial && serial) { shortname = serial; - } - else - { + } else { shortname = strrchr(dev, '/'); - if (!shortname) return; + if (!shortname) + return; shortname++; } - if (ignorelist_match (ignorelist, shortname) != 0) { - DEBUG ("smart plugin: ignoring %s.", dev); + if (ignorelist_match(ignorelist, shortname) != 0) { + DEBUG("smart plugin: ignoring %s.", dev); return; } - DEBUG ("smart plugin: checking SMART status of %s.", - dev); + DEBUG("smart plugin: checking SMART status of %s.", dev); - if (sk_disk_open (dev, &d) < 0) - { - ERROR ("smart plugin: unable to open %s.", dev); + if (sk_disk_open(dev, &d) < 0) { + ERROR("smart plugin: unable to open %s.", dev); return; } - if (sk_disk_identify_is_available (d, &available) < 0 || !available) - { - DEBUG ("smart plugin: disk %s cannot be identified.", dev); + if (sk_disk_identify_is_available(d, &available) < 0 || !available) { + DEBUG("smart plugin: disk %s cannot be identified.", dev); goto end; } - if (sk_disk_smart_is_available (d, &available) < 0 || !available) - { - DEBUG ("smart plugin: disk %s has no SMART support.", dev); + if (sk_disk_smart_is_available(d, &available) < 0 || !available) { + DEBUG("smart plugin: disk %s has no SMART support.", dev); goto end; } - if (!ignore_sleep_mode) - { - if (sk_disk_check_sleep_mode (d, &awake) < 0 || !awake) - { - DEBUG ("smart plugin: disk %s is sleeping.", dev); + if (!ignore_sleep_mode) { + if (sk_disk_check_sleep_mode(d, &awake) < 0 || !awake) { + DEBUG("smart plugin: disk %s is sleeping.", dev); goto end; } } - if (sk_disk_smart_read_data (d) < 0) - { - ERROR ("smart plugin: unable to get SMART data for disk %s.", dev); + if (sk_disk_smart_read_data(d) < 0) { + ERROR("smart plugin: unable to get SMART data for disk %s.", dev); goto end; } - if (sk_disk_smart_parse (d, &spd) < 0) - { - ERROR ("smart plugin: unable to parse SMART data for disk %s.", dev); + if (sk_disk_smart_parse(d, &spd) < 0) { + ERROR("smart plugin: unable to parse SMART data for disk %s.", dev); goto end; } /* Get some specific values */ - if (sk_disk_smart_get_power_on (d, &poweron) < 0) - { - WARNING ("smart plugin: unable to get milliseconds since power on for %s.", - dev); - } - else - smart_submit (shortname, "smart_poweron", "", poweron / 1000.); - - if (sk_disk_smart_get_power_cycle (d, &powercycles) < 0) - { - WARNING ("smart plugin: unable to get number of power cycles for %s.", - dev); - } - else - smart_submit (shortname, "smart_powercycles", "", powercycles); - - if (sk_disk_smart_get_bad (d, &badsectors) < 0) - { - WARNING ("smart plugin: unable to get number of bad sectors for %s.", - dev); - } - else - smart_submit (shortname, "smart_badsectors", "", badsectors); - - if (sk_disk_smart_get_temperature (d, &temperature) < 0) - { - WARNING ("smart plugin: unable to get temperature for %s.", - dev); - } - else - smart_submit (shortname, "smart_temperature", "", temperature / 1000. - 273.15); + if (sk_disk_smart_get_power_on(d, &poweron) < 0) { + WARNING("smart plugin: unable to get milliseconds since power on for %s.", + dev); + } else + smart_submit(shortname, "smart_poweron", "", poweron / 1000.); + + if (sk_disk_smart_get_power_cycle(d, &powercycles) < 0) { + WARNING("smart plugin: unable to get number of power cycles for %s.", dev); + } else + smart_submit(shortname, "smart_powercycles", "", powercycles); + + if (sk_disk_smart_get_bad(d, &badsectors) < 0) { + WARNING("smart plugin: unable to get number of bad sectors for %s.", dev); + } else + smart_submit(shortname, "smart_badsectors", "", badsectors); + + if (sk_disk_smart_get_temperature(d, &temperature) < 0) { + WARNING("smart plugin: unable to get temperature for %s.", dev); + } else + smart_submit(shortname, "smart_temperature", "", + temperature / 1000. - 273.15); /* Grab all attributes */ if (sk_disk_smart_parse_attributes(d, smart_handle_disk_attribute, - (char *)shortname) < 0) - { - ERROR ("smart plugin: unable to handle SMART attributes for %s.", - dev); + (char *)shortname) < 0) { + ERROR("smart plugin: unable to handle SMART attributes for %s.", dev); } end: sk_disk_free(d); } -static int smart_read (void) -{ +static int smart_read(void) { struct udev *handle_udev; struct udev_enumerate *enumerate; struct udev_list_entry *devices, *dev_list_entry; @@ -258,38 +211,34 @@ static int smart_read (void) /* Use udev to get a list of disks */ handle_udev = udev_new(); - if (!handle_udev) - { - ERROR ("smart plugin: unable to initialize udev."); + if (!handle_udev) { + ERROR("smart plugin: unable to initialize udev."); return (-1); } - enumerate = udev_enumerate_new (handle_udev); - udev_enumerate_add_match_subsystem (enumerate, "block"); - udev_enumerate_add_match_property (enumerate, "DEVTYPE", "disk"); - udev_enumerate_scan_devices (enumerate); - devices = udev_enumerate_get_list_entry (enumerate); - udev_list_entry_foreach (dev_list_entry, devices) - { + enumerate = udev_enumerate_new(handle_udev); + udev_enumerate_add_match_subsystem(enumerate, "block"); + udev_enumerate_add_match_property(enumerate, "DEVTYPE", "disk"); + udev_enumerate_scan_devices(enumerate); + devices = udev_enumerate_get_list_entry(enumerate); + udev_list_entry_foreach(dev_list_entry, devices) { const char *path, *devpath, *serial; - path = udev_list_entry_get_name (dev_list_entry); - dev = udev_device_new_from_syspath (handle_udev, path); - devpath = udev_device_get_devnode (dev); - serial = udev_device_get_property_value (dev, "ID_SERIAL"); + path = udev_list_entry_get_name(dev_list_entry); + dev = udev_device_new_from_syspath(handle_udev, path); + devpath = udev_device_get_devnode(dev); + serial = udev_device_get_property_value(dev, "ID_SERIAL"); /* Query status with libatasmart */ - smart_handle_disk (devpath, serial); - udev_device_unref (dev); + smart_handle_disk(devpath, serial); + udev_device_unref(dev); } - udev_enumerate_unref (enumerate); - udev_unref (handle_udev); + udev_enumerate_unref(enumerate); + udev_unref(handle_udev); return (0); } /* int smart_read */ -void module_register (void) -{ - plugin_register_config ("smart", smart_config, - config_keys, config_keys_num); - plugin_register_read ("smart", smart_read); +void module_register(void) { + plugin_register_config("smart", smart_config, config_keys, config_keys_num); + plugin_register_read("smart", smart_read); } /* void module_register */