X-Git-Url: https://git.octo.it/?p=collectd.git;a=blobdiff_plain;f=src%2Fthreshold.c;h=790013344b964288cb8826eb1118b6237d51b147;hp=45ee3b4d02c61b722419577ee607580dcdb4cb26;hb=da11ce02eb202b3e01d3e2d1b40f248a84430973;hpb=f7b05ebf3311b4c6cb5289f1f7cd8ee02918ef92

diff --git a/src/threshold.c b/src/threshold.c
index 45ee3b4d..79001334 100644
--- a/src/threshold.c
+++ b/src/threshold.c
@@ -24,15 +24,13 @@
  **/
 
 #include "collectd.h"
+
 #include "common.h"
 #include "plugin.h"
 #include "utils_avltree.h"
 #include "utils_cache.h"
 #include "utils_threshold.h"
 
-#include <assert.h>
-#include <pthread.h>
-
 /*
  * Threshold management
  * ====================
@@ -47,70 +45,62 @@
  * structure is copied and may be destroyed after this call. Returns zero on
  * success, non-zero otherwise.
  */
-static int ut_threshold_add (const threshold_t *th)
-{ /* {{{ */
+static int ut_threshold_add(const threshold_t *th) { /* {{{ */
   char name[6 * DATA_MAX_NAME_LEN];
   char *name_copy;
   threshold_t *th_copy;
   threshold_t *th_ptr;
   int status = 0;
 
-  if (format_name (name, sizeof (name), th->host,
-	th->plugin, th->plugin_instance,
-	th->type, th->type_instance) != 0)
-  {
-    ERROR ("ut_threshold_add: format_name failed.");
-    return (-1);
+  if (format_name(name, sizeof(name), th->host, th->plugin, th->plugin_instance,
+                  th->type, th->type_instance) != 0) {
+    ERROR("ut_threshold_add: format_name failed.");
+    return -1;
   }
 
-  name_copy = strdup (name);
-  if (name_copy == NULL)
-  {
-    ERROR ("ut_threshold_add: strdup failed.");
-    return (-1);
+  name_copy = strdup(name);
+  if (name_copy == NULL) {
+    ERROR("ut_threshold_add: strdup failed.");
+    return -1;
   }
 
-  th_copy = (threshold_t *) malloc (sizeof (threshold_t));
-  if (th_copy == NULL)
-  {
-    sfree (name_copy);
-    ERROR ("ut_threshold_add: malloc failed.");
-    return (-1);
+  th_copy = malloc(sizeof(*th_copy));
+  if (th_copy == NULL) {
+    sfree(name_copy);
+    ERROR("ut_threshold_add: malloc failed.");
+    return -1;
   }
-  memcpy (th_copy, th, sizeof (threshold_t));
-  th_ptr = NULL;
+  memcpy(th_copy, th, sizeof(threshold_t));
 
-  DEBUG ("ut_threshold_add: Adding entry `%s'", name);
+  DEBUG("ut_threshold_add: Adding entry `%s'", name);
 
-  pthread_mutex_lock (&threshold_lock);
+  pthread_mutex_lock(&threshold_lock);
 
-  th_ptr = threshold_get (th->host, th->plugin, th->plugin_instance,
-      th->type, th->type_instance);
+  th_ptr = threshold_get(th->host, th->plugin, th->plugin_instance, th->type,
+                         th->type_instance);
 
   while ((th_ptr != NULL) && (th_ptr->next != NULL))
     th_ptr = th_ptr->next;
 
   if (th_ptr == NULL) /* no such threshold yet */
   {
-    status = c_avl_insert (threshold_tree, name_copy, th_copy);
-  }
-  else /* th_ptr points to the last threshold in the list */
+    status = c_avl_insert(threshold_tree, name_copy, th_copy);
+  } else /* th_ptr points to the last threshold in the list */
   {
     th_ptr->next = th_copy;
     /* name_copy isn't needed */
-    sfree (name_copy);
+    sfree(name_copy);
   }
 
-  pthread_mutex_unlock (&threshold_lock);
+  pthread_mutex_unlock(&threshold_lock);
 
-  if (status != 0)
-  {
-    ERROR ("ut_threshold_add: c_avl_insert (%s) failed.", name);
-    sfree (name_copy);
-    sfree (th_copy);
+  if (status != 0) {
+    ERROR("ut_threshold_add: c_avl_insert (%s) failed.", name);
+    sfree(name_copy);
+    sfree(th_copy);
   }
 
-  return (status);
+  return status;
 } /* }}} int ut_threshold_add */
 
 /*
@@ -119,126 +109,107 @@ static int ut_threshold_add (const threshold_t *th)
  * The following approximately two hundred functions are used to handle the
  * configuration and fill the threshold list.
  * {{{ */
-static int ut_config_type_datasource (threshold_t *th, oconfig_item_t *ci)
-{
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_STRING))
-  {
-    WARNING ("threshold values: The `DataSource' option needs exactly one "
-	"string argument.");
-    return (-1);
+static int ut_config_type_datasource(threshold_t *th, oconfig_item_t *ci) {
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_STRING)) {
+    WARNING("threshold values: The `DataSource' option needs exactly one "
+            "string argument.");
+    return -1;
   }
 
-  sstrncpy (th->data_source, ci->values[0].value.string,
-      sizeof (th->data_source));
+  sstrncpy(th->data_source, ci->values[0].value.string,
+           sizeof(th->data_source));
 
-  return (0);
+  return 0;
 } /* int ut_config_type_datasource */
 
-static int ut_config_type_instance (threshold_t *th, oconfig_item_t *ci)
-{
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_STRING))
-  {
-    WARNING ("threshold values: The `Instance' option needs exactly one "
-	"string argument.");
-    return (-1);
+static int ut_config_type_instance(threshold_t *th, oconfig_item_t *ci) {
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_STRING)) {
+    WARNING("threshold values: The `Instance' option needs exactly one "
+            "string argument.");
+    return -1;
   }
 
-  sstrncpy (th->type_instance, ci->values[0].value.string,
-      sizeof (th->type_instance));
+  sstrncpy(th->type_instance, ci->values[0].value.string,
+           sizeof(th->type_instance));
 
-  return (0);
+  return 0;
 } /* int ut_config_type_instance */
 
-static int ut_config_type_max (threshold_t *th, oconfig_item_t *ci)
-{
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_NUMBER))
-  {
-    WARNING ("threshold values: The `%s' option needs exactly one "
-	"number argument.", ci->key);
-    return (-1);
+static int ut_config_type_max(threshold_t *th, oconfig_item_t *ci) {
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_NUMBER)) {
+    WARNING("threshold values: The `%s' option needs exactly one "
+            "number argument.",
+            ci->key);
+    return -1;
   }
 
-  if (strcasecmp (ci->key, "WarningMax") == 0)
+  if (strcasecmp(ci->key, "WarningMax") == 0)
     th->warning_max = ci->values[0].value.number;
   else
     th->failure_max = ci->values[0].value.number;
 
-  return (0);
+  return 0;
 } /* int ut_config_type_max */
 
-static int ut_config_type_min (threshold_t *th, oconfig_item_t *ci)
-{
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_NUMBER))
-  {
-    WARNING ("threshold values: The `%s' option needs exactly one "
-	"number argument.", ci->key);
-    return (-1);
+static int ut_config_type_min(threshold_t *th, oconfig_item_t *ci) {
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_NUMBER)) {
+    WARNING("threshold values: The `%s' option needs exactly one "
+            "number argument.",
+            ci->key);
+    return -1;
   }
 
-  if (strcasecmp (ci->key, "WarningMin") == 0)
+  if (strcasecmp(ci->key, "WarningMin") == 0)
     th->warning_min = ci->values[0].value.number;
   else
     th->failure_min = ci->values[0].value.number;
 
-  return (0);
+  return 0;
 } /* int ut_config_type_min */
 
-static int ut_config_type_hits (threshold_t *th, oconfig_item_t *ci)
-{
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_NUMBER))
-  {
-    WARNING ("threshold values: The `%s' option needs exactly one "
-      "number argument.", ci->key);
-    return (-1);
+static int ut_config_type_hits(threshold_t *th, oconfig_item_t *ci) {
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_NUMBER)) {
+    WARNING("threshold values: The `%s' option needs exactly one "
+            "number argument.",
+            ci->key);
+    return -1;
   }
 
   th->hits = ci->values[0].value.number;
 
-  return (0);
+  return 0;
 } /* int ut_config_type_hits */
 
-static int ut_config_type_hysteresis (threshold_t *th, oconfig_item_t *ci)
-{
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_NUMBER))
-  {
-    WARNING ("threshold values: The `%s' option needs exactly one "
-      "number argument.", ci->key);
-    return (-1);
+static int ut_config_type_hysteresis(threshold_t *th, oconfig_item_t *ci) {
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_NUMBER)) {
+    WARNING("threshold values: The `%s' option needs exactly one "
+            "number argument.",
+            ci->key);
+    return -1;
   }
 
   th->hysteresis = ci->values[0].value.number;
 
-  return (0);
+  return 0;
 } /* int ut_config_type_hysteresis */
 
-static int ut_config_type (const threshold_t *th_orig, oconfig_item_t *ci)
-{
-  int i;
+static int ut_config_type(const threshold_t *th_orig, oconfig_item_t *ci) {
   threshold_t th;
   int status = 0;
 
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_STRING))
-  {
-    WARNING ("threshold values: The `Type' block needs exactly one string "
-	"argument.");
-    return (-1);
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_STRING)) {
+    WARNING("threshold values: The `Type' block needs exactly one string "
+            "argument.");
+    return -1;
   }
 
-  if (ci->children_num < 1)
-  {
-    WARNING ("threshold values: The `Type' block needs at least one option.");
-    return (-1);
+  if (ci->children_num < 1) {
+    WARNING("threshold values: The `Type' block needs at least one option.");
+    return -1;
   }
 
-  memcpy (&th, th_orig, sizeof (th));
-  sstrncpy (th.type, ci->values[0].value.string, sizeof (th.type));
+  memcpy(&th, th_orig, sizeof(th));
+  sstrncpy(th.type, ci->values[0].value.string, sizeof(th.type));
 
   th.warning_min = NAN;
   th.warning_max = NAN;
@@ -248,38 +219,37 @@ static int ut_config_type (const threshold_t *th_orig, oconfig_item_t *ci)
   th.hysteresis = 0;
   th.flags = UT_FLAG_INTERESTING; /* interesting by default */
 
-  for (i = 0; i < ci->children_num; i++)
-  {
+  for (int i = 0; i < ci->children_num; i++) {
     oconfig_item_t *option = ci->children + i;
 
-    if (strcasecmp ("Instance", option->key) == 0)
-      status = ut_config_type_instance (&th, option);
-    else if (strcasecmp ("DataSource", option->key) == 0)
-      status = ut_config_type_datasource (&th, option);
-    else if ((strcasecmp ("WarningMax", option->key) == 0)
-	|| (strcasecmp ("FailureMax", option->key) == 0))
-      status = ut_config_type_max (&th, option);
-    else if ((strcasecmp ("WarningMin", option->key) == 0)
-	|| (strcasecmp ("FailureMin", option->key) == 0))
-      status = ut_config_type_min (&th, option);
-    else if (strcasecmp ("Interesting", option->key) == 0)
-      status = cf_util_get_flag (option, &th.flags, UT_FLAG_INTERESTING);
-    else if (strcasecmp ("Invert", option->key) == 0)
-      status = cf_util_get_flag (option, &th.flags, UT_FLAG_INVERT);
-    else if (strcasecmp ("Persist", option->key) == 0)
-      status = cf_util_get_flag (option, &th.flags, UT_FLAG_PERSIST);
-    else if (strcasecmp ("PersistOK", option->key) == 0)
-      status = cf_util_get_flag (option, &th.flags, UT_FLAG_PERSIST_OK);
-    else if (strcasecmp ("Percentage", option->key) == 0)
-      status = cf_util_get_flag (option, &th.flags, UT_FLAG_PERCENTAGE);
-    else if (strcasecmp ("Hits", option->key) == 0)
-      status = ut_config_type_hits (&th, option);
-    else if (strcasecmp ("Hysteresis", option->key) == 0)
-      status = ut_config_type_hysteresis (&th, option);
-    else
-    {
-      WARNING ("threshold values: Option `%s' not allowed inside a `Type' "
-	  "block.", option->key);
+    if (strcasecmp("Instance", option->key) == 0)
+      status = ut_config_type_instance(&th, option);
+    else if (strcasecmp("DataSource", option->key) == 0)
+      status = ut_config_type_datasource(&th, option);
+    else if ((strcasecmp("WarningMax", option->key) == 0) ||
+             (strcasecmp("FailureMax", option->key) == 0))
+      status = ut_config_type_max(&th, option);
+    else if ((strcasecmp("WarningMin", option->key) == 0) ||
+             (strcasecmp("FailureMin", option->key) == 0))
+      status = ut_config_type_min(&th, option);
+    else if (strcasecmp("Interesting", option->key) == 0)
+      status = cf_util_get_flag(option, &th.flags, UT_FLAG_INTERESTING);
+    else if (strcasecmp("Invert", option->key) == 0)
+      status = cf_util_get_flag(option, &th.flags, UT_FLAG_INVERT);
+    else if (strcasecmp("Persist", option->key) == 0)
+      status = cf_util_get_flag(option, &th.flags, UT_FLAG_PERSIST);
+    else if (strcasecmp("PersistOK", option->key) == 0)
+      status = cf_util_get_flag(option, &th.flags, UT_FLAG_PERSIST_OK);
+    else if (strcasecmp("Percentage", option->key) == 0)
+      status = cf_util_get_flag(option, &th.flags, UT_FLAG_PERCENTAGE);
+    else if (strcasecmp("Hits", option->key) == 0)
+      status = ut_config_type_hits(&th, option);
+    else if (strcasecmp("Hysteresis", option->key) == 0)
+      status = ut_config_type_hysteresis(&th, option);
+    else {
+      WARNING("threshold values: Option `%s' not allowed inside a `Type' "
+              "block.",
+              option->key);
       status = -1;
     }
 
@@ -287,66 +257,56 @@ static int ut_config_type (const threshold_t *th_orig, oconfig_item_t *ci)
       break;
   }
 
-  if (status == 0)
-  {
-    status = ut_threshold_add (&th);
+  if (status == 0) {
+    status = ut_threshold_add(&th);
   }
 
-  return (status);
+  return status;
 } /* int ut_config_type */
 
-static int ut_config_plugin_instance (threshold_t *th, oconfig_item_t *ci)
-{
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_STRING))
-  {
-    WARNING ("threshold values: The `Instance' option needs exactly one "
-	"string argument.");
-    return (-1);
+static int ut_config_plugin_instance(threshold_t *th, oconfig_item_t *ci) {
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_STRING)) {
+    WARNING("threshold values: The `Instance' option needs exactly one "
+            "string argument.");
+    return -1;
   }
 
-  sstrncpy (th->plugin_instance, ci->values[0].value.string,
-      sizeof (th->plugin_instance));
+  sstrncpy(th->plugin_instance, ci->values[0].value.string,
+           sizeof(th->plugin_instance));
 
-  return (0);
+  return 0;
 } /* int ut_config_plugin_instance */
 
-static int ut_config_plugin (const threshold_t *th_orig, oconfig_item_t *ci)
-{
-  int i;
+static int ut_config_plugin(const threshold_t *th_orig, oconfig_item_t *ci) {
   threshold_t th;
   int status = 0;
 
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_STRING))
-  {
-    WARNING ("threshold values: The `Plugin' block needs exactly one string "
-	"argument.");
-    return (-1);
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_STRING)) {
+    WARNING("threshold values: The `Plugin' block needs exactly one string "
+            "argument.");
+    return -1;
   }
 
-  if (ci->children_num < 1)
-  {
-    WARNING ("threshold values: The `Plugin' block needs at least one nested "
-	"block.");
-    return (-1);
+  if (ci->children_num < 1) {
+    WARNING("threshold values: The `Plugin' block needs at least one nested "
+            "block.");
+    return -1;
   }
 
-  memcpy (&th, th_orig, sizeof (th));
-  sstrncpy (th.plugin, ci->values[0].value.string, sizeof (th.plugin));
+  memcpy(&th, th_orig, sizeof(th));
+  sstrncpy(th.plugin, ci->values[0].value.string, sizeof(th.plugin));
 
-  for (i = 0; i < ci->children_num; i++)
-  {
+  for (int i = 0; i < ci->children_num; i++) {
     oconfig_item_t *option = ci->children + i;
 
-    if (strcasecmp ("Type", option->key) == 0)
-      status = ut_config_type (&th, option);
-    else if (strcasecmp ("Instance", option->key) == 0)
-      status = ut_config_plugin_instance (&th, option);
-    else
-    {
-      WARNING ("threshold values: Option `%s' not allowed inside a `Plugin' "
-	  "block.", option->key);
+    if (strcasecmp("Type", option->key) == 0)
+      status = ut_config_type(&th, option);
+    else if (strcasecmp("Instance", option->key) == 0)
+      status = ut_config_plugin_instance(&th, option);
+    else {
+      WARNING("threshold values: Option `%s' not allowed inside a `Plugin' "
+              "block.",
+              option->key);
       status = -1;
     }
 
@@ -354,45 +314,39 @@ static int ut_config_plugin (const threshold_t *th_orig, oconfig_item_t *ci)
       break;
   }
 
-  return (status);
+  return status;
 } /* int ut_config_plugin */
 
-static int ut_config_host (const threshold_t *th_orig, oconfig_item_t *ci)
-{
-  int i;
+static int ut_config_host(const threshold_t *th_orig, oconfig_item_t *ci) {
   threshold_t th;
   int status = 0;
 
-  if ((ci->values_num != 1)
-      || (ci->values[0].type != OCONFIG_TYPE_STRING))
-  {
-    WARNING ("threshold values: The `Host' block needs exactly one string "
-	"argument.");
-    return (-1);
+  if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_STRING)) {
+    WARNING("threshold values: The `Host' block needs exactly one string "
+            "argument.");
+    return -1;
   }
 
-  if (ci->children_num < 1)
-  {
-    WARNING ("threshold values: The `Host' block needs at least one nested "
-	"block.");
-    return (-1);
+  if (ci->children_num < 1) {
+    WARNING("threshold values: The `Host' block needs at least one nested "
+            "block.");
+    return -1;
   }
 
-  memcpy (&th, th_orig, sizeof (th));
-  sstrncpy (th.host, ci->values[0].value.string, sizeof (th.host));
+  memcpy(&th, th_orig, sizeof(th));
+  sstrncpy(th.host, ci->values[0].value.string, sizeof(th.host));
 
-  for (i = 0; i < ci->children_num; i++)
-  {
+  for (int i = 0; i < ci->children_num; i++) {
     oconfig_item_t *option = ci->children + i;
 
-    if (strcasecmp ("Type", option->key) == 0)
-      status = ut_config_type (&th, option);
-    else if (strcasecmp ("Plugin", option->key) == 0)
-      status = ut_config_plugin (&th, option);
-    else
-    {
-      WARNING ("threshold values: Option `%s' not allowed inside a `Host' "
-	  "block.", option->key);
+    if (strcasecmp("Type", option->key) == 0)
+      status = ut_config_type(&th, option);
+    else if (strcasecmp("Plugin", option->key) == 0)
+      status = ut_config_plugin(&th, option);
+    else {
+      WARNING("threshold values: Option `%s' not allowed inside a `Host' "
+              "block.",
+              option->key);
       status = -1;
     }
 
@@ -400,7 +354,7 @@ static int ut_config_host (const threshold_t *th_orig, oconfig_item_t *ci)
       break;
   }
 
-  return (status);
+  return status;
 } /* int ut_config_host */
 /*
  * End of the functions used to configure threshold values.
@@ -414,13 +368,9 @@ static int ut_config_host (const threshold_t *th_orig, oconfig_item_t *ci)
  * if appropriate.
  * Does not fail.
  */
-static int ut_report_state (const data_set_t *ds,
-    const value_list_t *vl,
-    const threshold_t *th,
-    const gauge_t *values,
-    int ds_index,
-    int state)
-{ /* {{{ */
+static int ut_report_state(const data_set_t *ds, const value_list_t *vl,
+                           const threshold_t *th, const gauge_t *values,
+                           int ds_index, int state) { /* {{{ */
   int state_old;
   notification_t n;
 
@@ -430,41 +380,40 @@ static int ut_report_state (const data_set_t *ds,
   int status;
 
   /* Check if hits matched */
-  if ( (th->hits != 0) )
-  {
-    int hits = uc_get_hits(ds,vl);
+  if ((th->hits != 0)) {
+    int hits = uc_get_hits(ds, vl);
     /* STATE_OKAY resets hits unless PERSIST_OK flag is set. Hits resets if
      * threshold is hit. */
-    if ( ( (state == STATE_OKAY) && ((th->flags & UT_FLAG_PERSIST_OK) == 0) ) || (hits > th->hits) )
-    {
-        DEBUG("ut_report_state: reset uc_get_hits = 0");
-        uc_set_hits(ds,vl,0); /* reset hit counter and notify */
+    if (((state == STATE_OKAY) && ((th->flags & UT_FLAG_PERSIST_OK) == 0)) ||
+        (hits > th->hits)) {
+      DEBUG("ut_report_state: reset uc_get_hits = 0");
+      uc_set_hits(ds, vl, 0); /* reset hit counter and notify */
     } else {
-      DEBUG("ut_report_state: th->hits = %d, uc_get_hits = %d",th->hits,uc_get_hits(ds,vl));
-      (void) uc_inc_hits(ds,vl,1); /* increase hit counter */
-      return (0);
+      DEBUG("ut_report_state: th->hits = %d, uc_get_hits = %d", th->hits,
+            uc_get_hits(ds, vl));
+      (void)uc_inc_hits(ds, vl, 1); /* increase hit counter */
+      return 0;
     }
   } /* end check hits */
 
-  state_old = uc_get_state (ds, vl);
+  state_old = uc_get_state(ds, vl);
 
   /* If the state didn't change, report if `persistent' is specified. If the
    * state is `okay', then only report if `persist_ok` flag is set. */
-  if (state == state_old)
-  {
+  if (state == state_old) {
     if ((th->flags & UT_FLAG_PERSIST) == 0)
-      return (0);
-    else if ( (state == STATE_OKAY) && ((th->flags & UT_FLAG_PERSIST_OK) == 0) )
-      return (0);
+      return 0;
+    else if ((state == STATE_OKAY) && ((th->flags & UT_FLAG_PERSIST_OK) == 0))
+      return 0;
   }
 
   if (state != state_old)
-    uc_set_state (ds, vl, state);
+    uc_set_state(ds, vl, state);
 
-  NOTIFICATION_INIT_VL (&n, vl);
+  NOTIFICATION_INIT_VL(&n, vl);
 
   buf = n.message;
-  bufsize = sizeof (n.message);
+  bufsize = sizeof(n.message);
 
   if (state == STATE_OKAY)
     n.severity = NOTIF_OKAY;
@@ -475,90 +424,73 @@ static int ut_report_state (const data_set_t *ds,
 
   n.time = vl->time;
 
-  status = ssnprintf (buf, bufsize, "Host %s, plugin %s",
-      vl->host, vl->plugin);
+  status = snprintf(buf, bufsize, "Host %s, plugin %s", vl->host, vl->plugin);
   buf += status;
   bufsize -= status;
 
-  if (vl->plugin_instance[0] != '\0')
-  {
-    status = ssnprintf (buf, bufsize, " (instance %s)",
-	vl->plugin_instance);
+  if (vl->plugin_instance[0] != '\0') {
+    status = snprintf(buf, bufsize, " (instance %s)", vl->plugin_instance);
     buf += status;
     bufsize -= status;
   }
 
-  status = ssnprintf (buf, bufsize, " type %s", vl->type);
+  status = snprintf(buf, bufsize, " type %s", vl->type);
   buf += status;
   bufsize -= status;
 
-  if (vl->type_instance[0] != '\0')
-  {
-    status = ssnprintf (buf, bufsize, " (instance %s)",
-	vl->type_instance);
+  if (vl->type_instance[0] != '\0') {
+    status = snprintf(buf, bufsize, " (instance %s)", vl->type_instance);
     buf += status;
     bufsize -= status;
   }
 
-  plugin_notification_meta_add_string (&n, "DataSource",
-      ds->ds[ds_index].name);
-  plugin_notification_meta_add_double (&n, "CurrentValue", values[ds_index]);
-  plugin_notification_meta_add_double (&n, "WarningMin", th->warning_min);
-  plugin_notification_meta_add_double (&n, "WarningMax", th->warning_max);
-  plugin_notification_meta_add_double (&n, "FailureMin", th->failure_min);
-  plugin_notification_meta_add_double (&n, "FailureMax", th->failure_max);
+  plugin_notification_meta_add_string(&n, "DataSource", ds->ds[ds_index].name);
+  plugin_notification_meta_add_double(&n, "CurrentValue", values[ds_index]);
+  plugin_notification_meta_add_double(&n, "WarningMin", th->warning_min);
+  plugin_notification_meta_add_double(&n, "WarningMax", th->warning_max);
+  plugin_notification_meta_add_double(&n, "FailureMin", th->failure_min);
+  plugin_notification_meta_add_double(&n, "FailureMax", th->failure_max);
 
   /* Send an okay notification */
-  if (state == STATE_OKAY)
-  {
+  if (state == STATE_OKAY) {
     if (state_old == STATE_MISSING)
-      ssnprintf (buf, bufsize, ": Value is no longer missing.");
+      snprintf(buf, bufsize, ": Value is no longer missing.");
     else
-      ssnprintf (buf, bufsize,
-          ": All data sources are within range again. "
-          "Current value of \"%s\" is %f.",
-          ds->ds[ds_index].name, values[ds_index]);
-  }
-  else
-  {
+      snprintf(buf, bufsize, ": All data sources are within range again. "
+                             "Current value of \"%s\" is %f.",
+               ds->ds[ds_index].name, values[ds_index]);
+  } else {
     double min;
     double max;
 
     min = (state == STATE_ERROR) ? th->failure_min : th->warning_min;
     max = (state == STATE_ERROR) ? th->failure_max : th->warning_max;
 
-    if (th->flags & UT_FLAG_INVERT)
-    {
-      if (!isnan (min) && !isnan (max))
-      {
-        ssnprintf (buf, bufsize, ": Data source \"%s\" is currently "
-            "%f. That is within the %s region of %f%s and %f%s.",
-            ds->ds[ds_index].name, values[ds_index],
-            (state == STATE_ERROR) ? "failure" : "warning",
-            min, ((th->flags & UT_FLAG_PERCENTAGE) != 0) ? "%" : "",
-            max, ((th->flags & UT_FLAG_PERCENTAGE) != 0) ? "%" : "");
+    if (th->flags & UT_FLAG_INVERT) {
+      if (!isnan(min) && !isnan(max)) {
+        snprintf(buf, bufsize,
+                 ": Data source \"%s\" is currently "
+                 "%f. That is within the %s region of %f%s and %f%s.",
+                 ds->ds[ds_index].name, values[ds_index],
+                 (state == STATE_ERROR) ? "failure" : "warning", min,
+                 ((th->flags & UT_FLAG_PERCENTAGE) != 0) ? "%" : "", max,
+                 ((th->flags & UT_FLAG_PERCENTAGE) != 0) ? "%" : "");
+      } else {
+        snprintf(buf, bufsize, ": Data source \"%s\" is currently "
+                               "%f. That is %s the %s threshold of %f%s.",
+                 ds->ds[ds_index].name, values[ds_index],
+                 isnan(min) ? "below" : "above",
+                 (state == STATE_ERROR) ? "failure" : "warning",
+                 isnan(min) ? max : min,
+                 ((th->flags & UT_FLAG_PERCENTAGE) != 0) ? "%" : "");
       }
-      else
-      {
-        ssnprintf (buf, bufsize, ": Data source \"%s\" is currently "
-            "%f. That is %s the %s threshold of %f%s.",
-            ds->ds[ds_index].name, values[ds_index],
-            isnan (min) ? "below" : "above",
-            (state == STATE_ERROR) ? "failure" : "warning",
-            isnan (min) ? max : min,
-            ((th->flags & UT_FLAG_PERCENTAGE) != 0) ? "%" : "");
-      }
-    }
-    else if (th->flags & UT_FLAG_PERCENTAGE)
-    {
+    } else if (th->flags & UT_FLAG_PERCENTAGE) {
       gauge_t value;
       gauge_t sum;
-      int i;
 
       sum = 0.0;
-      for (i = 0; i < vl->values_len; i++)
-      {
-        if (isnan (values[i]))
+      for (size_t i = 0; i < vl->values_len; i++) {
+        if (isnan(values[i]))
           continue;
 
         sum += values[i];
@@ -569,28 +501,28 @@ static int ut_report_state (const data_set_t *ds,
       else
         value = 100.0 * values[ds_index] / sum;
 
-      ssnprintf (buf, bufsize, ": Data source \"%s\" is currently "
-          "%g (%.2f%%). That is %s the %s threshold of %.2f%%.",
-          ds->ds[ds_index].name, values[ds_index], value,
-          (value < min) ? "below" : "above",
-          (state == STATE_ERROR) ? "failure" : "warning",
-          (value < min) ? min : max);
-    }
-    else /* is not inverted */
+      snprintf(buf, bufsize,
+               ": Data source \"%s\" is currently "
+               "%g (%.2f%%). That is %s the %s threshold of %.2f%%.",
+               ds->ds[ds_index].name, values[ds_index], value,
+               (value < min) ? "below" : "above",
+               (state == STATE_ERROR) ? "failure" : "warning",
+               (value < min) ? min : max);
+    } else /* is not inverted */
     {
-      ssnprintf (buf, bufsize, ": Data source \"%s\" is currently "
-          "%f. That is %s the %s threshold of %f.",
-          ds->ds[ds_index].name, values[ds_index],
-          (values[ds_index] < min) ? "below" : "above",
-          (state == STATE_ERROR) ? "failure" : "warning",
-          (values[ds_index] < min) ? min : max);
+      snprintf(buf, bufsize, ": Data source \"%s\" is currently "
+                             "%f. That is %s the %s threshold of %f.",
+               ds->ds[ds_index].name, values[ds_index],
+               (values[ds_index] < min) ? "below" : "above",
+               (state == STATE_ERROR) ? "failure" : "warning",
+               (values[ds_index] < min) ? min : max);
     }
   }
 
-  plugin_dispatch_notification (&n);
+  plugin_dispatch_notification(&n);
 
-  plugin_notification_meta_free (n.meta);
-  return (0);
+  plugin_notification_meta_free(n.meta);
+  return 0;
 } /* }}} int ut_report_state */
 
 /*
@@ -603,37 +535,30 @@ static int ut_report_state (const data_set_t *ds,
  * appropriate.
  * Does not fail.
  */
-static int ut_check_one_data_source (const data_set_t *ds,
-    const value_list_t __attribute__((unused)) *vl,
-    const threshold_t *th,
-    const gauge_t *values,
-    int ds_index)
-{ /* {{{ */
+static int ut_check_one_data_source(
+    const data_set_t *ds, const value_list_t __attribute__((unused)) * vl,
+    const threshold_t *th, const gauge_t *values, int ds_index) { /* {{{ */
   const char *ds_name;
   int is_warning = 0;
   int is_failure = 0;
   int prev_state = STATE_OKAY;
 
   /* check if this threshold applies to this data source */
-  if (ds != NULL)
-  {
+  if (ds != NULL) {
     ds_name = ds->ds[ds_index].name;
-    if ((th->data_source[0] != 0)
-	&& (strcmp (ds_name, th->data_source) != 0))
-      return (STATE_OKAY);
+    if ((th->data_source[0] != 0) && (strcmp(ds_name, th->data_source) != 0))
+      return STATE_OKAY;
   }
 
-  if ((th->flags & UT_FLAG_INVERT) != 0)
-  {
+  if ((th->flags & UT_FLAG_INVERT) != 0) {
     is_warning--;
     is_failure--;
   }
 
   /* XXX: This is an experimental code, not optimized, not fast, not reliable,
    * and probably, do not work as you expect. Enjoy! :D */
-  if (th->hysteresis > 0)
-  {
-    prev_state = uc_get_state(ds,vl);
+  if (th->hysteresis > 0) {
+    prev_state = uc_get_state(ds, vl);
     /* The purpose of hysteresis is elliminating flapping state when the value
      * oscilates around the thresholds. In other words, what is important is
      * the previous state; if the new value would trigger a transition, make
@@ -644,45 +569,47 @@ static int ut_check_one_data_source (const data_set_t *ds,
      * There is no hysteresis for the OKAY state.
      * */
     gauge_t hysteresis_for_warning = 0, hysteresis_for_failure = 0;
-    switch (prev_state)
-    {
-      case STATE_ERROR:
-        hysteresis_for_failure = th->hysteresis;
-        break;
-      case STATE_WARNING:
-        hysteresis_for_warning = th->hysteresis;
-        break;
-      case STATE_OKAY:
-        /* do nothing -- the hysteresis only applies to the non-normal states */
-        break;
+    switch (prev_state) {
+    case STATE_ERROR:
+      hysteresis_for_failure = th->hysteresis;
+      break;
+    case STATE_WARNING:
+      hysteresis_for_warning = th->hysteresis;
+      break;
+    case STATE_OKAY:
+      /* do nothing -- the hysteresis only applies to the non-normal states */
+      break;
     }
 
-    if ((!isnan (th->failure_min) && (th->failure_min + hysteresis_for_failure > values[ds_index]))
-	|| (!isnan (th->failure_max) && (th->failure_max - hysteresis_for_failure < values[ds_index])))
+    if ((!isnan(th->failure_min) &&
+         (th->failure_min + hysteresis_for_failure > values[ds_index])) ||
+        (!isnan(th->failure_max) &&
+         (th->failure_max - hysteresis_for_failure < values[ds_index])))
       is_failure++;
 
-    if ((!isnan (th->warning_min) && (th->warning_min + hysteresis_for_warning > values[ds_index]))
-	|| (!isnan (th->warning_max) && (th->warning_max - hysteresis_for_warning < values[ds_index])))
+    if ((!isnan(th->warning_min) &&
+         (th->warning_min + hysteresis_for_warning > values[ds_index])) ||
+        (!isnan(th->warning_max) &&
+         (th->warning_max - hysteresis_for_warning < values[ds_index])))
       is_warning++;
 
-  }
-  else { /* no hysteresis */
-    if ((!isnan (th->failure_min) && (th->failure_min > values[ds_index]))
-	|| (!isnan (th->failure_max) && (th->failure_max < values[ds_index])))
+  } else { /* no hysteresis */
+    if ((!isnan(th->failure_min) && (th->failure_min > values[ds_index])) ||
+        (!isnan(th->failure_max) && (th->failure_max < values[ds_index])))
       is_failure++;
 
-    if ((!isnan (th->warning_min) && (th->warning_min > values[ds_index]))
-	|| (!isnan (th->warning_max) && (th->warning_max < values[ds_index])))
+    if ((!isnan(th->warning_min) && (th->warning_min > values[ds_index])) ||
+        (!isnan(th->warning_max) && (th->warning_max < values[ds_index])))
       is_warning++;
   }
 
   if (is_failure != 0)
-    return (STATE_ERROR);
+    return STATE_ERROR;
 
   if (is_warning != 0)
-    return (STATE_WARNING);
+    return STATE_WARNING;
 
-  return (STATE_OKAY);
+  return STATE_OKAY;
 } /* }}} int ut_check_one_data_source */
 
 /*
@@ -693,60 +620,52 @@ static int ut_check_one_data_source (const data_set_t *ds,
  * which is `okay' if nothing has failed.
  * Returns less than zero if the data set doesn't have any data sources.
  */
-static int ut_check_one_threshold (const data_set_t *ds,
-    const value_list_t *vl,
-    const threshold_t *th,
-    const gauge_t *values,
-    int *ret_ds_index)
-{ /* {{{ */
+static int ut_check_one_threshold(const data_set_t *ds, const value_list_t *vl,
+                                  const threshold_t *th, const gauge_t *values,
+                                  int *ret_ds_index) { /* {{{ */
   int ret = -1;
   int ds_index = -1;
-  int i;
   gauge_t values_copy[ds->ds_num];
 
-  memcpy (values_copy, values, sizeof (values_copy));
+  memcpy(values_copy, values, sizeof(values_copy));
 
-  if ((th->flags & UT_FLAG_PERCENTAGE) != 0)
-  {
+  if ((th->flags & UT_FLAG_PERCENTAGE) != 0) {
     int num = 0;
-    gauge_t sum=0.0;
+    gauge_t sum = 0.0;
 
-    if (ds->ds_num == 1)
-    {
-      WARNING ("ut_check_one_threshold: The %s type has only one data "
+    if (ds->ds_num == 1) {
+      WARNING(
+          "ut_check_one_threshold: The %s type has only one data "
           "source, but you have configured to check this as a percentage. "
           "That doesn't make much sense, because the percentage will always "
-          "be 100%%!", ds->type);
+          "be 100%%!",
+          ds->type);
     }
 
     /* Prepare `sum' and `num'. */
-    for (i = 0; i < ds->ds_num; i++)
-      if (!isnan (values[i]))
-      {
+    for (size_t i = 0; i < ds->ds_num; i++)
+      if (!isnan(values[i])) {
         num++;
-	sum += values[i];
+        sum += values[i];
       }
 
-    if ((num == 0) /* All data sources are undefined. */
+    if ((num == 0)       /* All data sources are undefined. */
         || (sum == 0.0)) /* Sum is zero, cannot calculate percentage. */
     {
-      for (i = 0; i < ds->ds_num; i++)
+      for (size_t i = 0; i < ds->ds_num; i++)
         values_copy[i] = NAN;
-    }
-    else /* We can actually calculate the percentage. */
+    } else /* We can actually calculate the percentage. */
     {
-      for (i = 0; i < ds->ds_num; i++)
+      for (size_t i = 0; i < ds->ds_num; i++)
         values_copy[i] = 100.0 * values[i] / sum;
     }
   } /* if (UT_FLAG_PERCENTAGE) */
 
-  for (i = 0; i < ds->ds_num; i++)
-  {
+  for (size_t i = 0; i < ds->ds_num; i++) {
     int status;
 
-    status = ut_check_one_data_source (ds, vl, th, values_copy, i);
-    if (ret < status)
-    {
+    status = ut_check_one_data_source(ds, vl, th, values_copy, i);
+    if (ret < status) {
       ret = status;
       ds_index = i;
     }
@@ -755,7 +674,7 @@ static int ut_check_one_threshold (const data_set_t *ds,
   if (ret_ds_index != NULL)
     *ret_ds_index = ds_index;
 
-  return (ret);
+  return ret;
 } /* }}} int ut_check_one_threshold */
 
 /*
@@ -767,9 +686,9 @@ static int ut_check_one_threshold (const data_set_t *ds,
  * Returns zero on success and if no threshold has been configured. Returns
  * less than zero on failure.
  */
-static int ut_check_threshold (const data_set_t *ds, const value_list_t *vl,
-    __attribute__((unused)) user_data_t *ud)
-{ /* {{{ */
+static int ut_check_threshold(const data_set_t *ds, const value_list_t *vl,
+                              __attribute__((unused))
+                              user_data_t *ud) { /* {{{ */
   threshold_t *th;
   gauge_t *values;
   int status;
@@ -779,36 +698,33 @@ static int ut_check_threshold (const data_set_t *ds, const value_list_t *vl,
   int worst_ds_index = -1;
 
   if (threshold_tree == NULL)
-    return (0);
+    return 0;
 
   /* Is this lock really necessary? So far, thresholds are only inserted at
    * startup. -octo */
-  pthread_mutex_lock (&threshold_lock);
-  th = threshold_search (vl);
-  pthread_mutex_unlock (&threshold_lock);
+  pthread_mutex_lock(&threshold_lock);
+  th = threshold_search(vl);
+  pthread_mutex_unlock(&threshold_lock);
   if (th == NULL)
-    return (0);
+    return 0;
 
-  DEBUG ("ut_check_threshold: Found matching threshold(s)");
+  DEBUG("ut_check_threshold: Found matching threshold(s)");
 
-  values = uc_get_rate (ds, vl);
+  values = uc_get_rate(ds, vl);
   if (values == NULL)
-    return (0);
+    return 0;
 
-  while (th != NULL)
-  {
+  while (th != NULL) {
     int ds_index = -1;
 
-    status = ut_check_one_threshold (ds, vl, th, values, &ds_index);
-    if (status < 0)
-    {
-      ERROR ("ut_check_threshold: ut_check_one_threshold failed.");
-      sfree (values);
-      return (-1);
+    status = ut_check_one_threshold(ds, vl, th, values, &ds_index);
+    if (status < 0) {
+      ERROR("ut_check_threshold: ut_check_one_threshold failed.");
+      sfree(values);
+      return -1;
     }
 
-    if (worst_state < status)
-    {
+    if (worst_state < status) {
       worst_state = status;
       worst_th = th;
       worst_ds_index = ds_index;
@@ -817,18 +733,17 @@ static int ut_check_threshold (const data_set_t *ds, const value_list_t *vl,
     th = th->next;
   } /* while (th) */
 
-  status = ut_report_state (ds, vl, worst_th, values,
-      worst_ds_index, worst_state);
-  if (status != 0)
-  {
-    ERROR ("ut_check_threshold: ut_report_state failed.");
-    sfree (values);
-    return (-1);
+  status =
+      ut_report_state(ds, vl, worst_th, values, worst_ds_index, worst_state);
+  if (status != 0) {
+    ERROR("ut_check_threshold: ut_report_state failed.");
+    sfree(values);
+    return -1;
   }
 
-  sfree (values);
+  sfree(values);
 
-  return (0);
+  return 0;
 } /* }}} int ut_check_threshold */
 
 /*
@@ -836,9 +751,8 @@ static int ut_check_threshold (const data_set_t *ds, const value_list_t *vl,
  *
  * This function is called whenever a value goes "missing".
  */
-static int ut_missing (const value_list_t *vl,
-    __attribute__((unused)) user_data_t *ud)
-{ /* {{{ */
+static int ut_missing(const value_list_t *vl,
+                      __attribute__((unused)) user_data_t *ud) { /* {{{ */
   threshold_t *th;
   cdtime_t missing_time;
   char identifier[6 * DATA_MAX_NAME_LEN];
@@ -846,69 +760,59 @@ static int ut_missing (const value_list_t *vl,
   cdtime_t now;
 
   if (threshold_tree == NULL)
-    return (0);
+    return 0;
 
-  th = threshold_search (vl);
+  th = threshold_search(vl);
   /* dispatch notifications for "interesting" values only */
   if ((th == NULL) || ((th->flags & UT_FLAG_INTERESTING) == 0))
-    return (0);
+    return 0;
 
-  now = cdtime ();
+  now = cdtime();
   missing_time = now - vl->time;
-  FORMAT_VL (identifier, sizeof (identifier), vl);
+  FORMAT_VL(identifier, sizeof(identifier), vl);
 
-  NOTIFICATION_INIT_VL (&n, vl);
-  ssnprintf (n.message, sizeof (n.message),
-      "%s has not been updated for %.3f seconds.",
-      identifier, CDTIME_T_TO_DOUBLE (missing_time));
+  NOTIFICATION_INIT_VL(&n, vl);
+  snprintf(n.message, sizeof(n.message),
+           "%s has not been updated for %.3f seconds.", identifier,
+           CDTIME_T_TO_DOUBLE(missing_time));
   n.time = now;
 
-  plugin_dispatch_notification (&n);
+  plugin_dispatch_notification(&n);
 
-  return (0);
+  return 0;
 } /* }}} int ut_missing */
 
-static int ut_config (oconfig_item_t *ci)
-{ /* {{{ */
-  int i;
+static int ut_config(oconfig_item_t *ci) { /* {{{ */
   int status = 0;
-  int old_size = c_avl_size (threshold_tree);
+  int old_size = c_avl_size(threshold_tree);
 
-  threshold_t th;
-
-  if (threshold_tree == NULL)
-  {
-    threshold_tree = c_avl_create ((void *) strcmp);
-    if (threshold_tree == NULL)
-    {
-      ERROR ("ut_config: c_avl_create failed.");
-      return (-1);
+  if (threshold_tree == NULL) {
+    threshold_tree = c_avl_create((int (*)(const void *, const void *))strcmp);
+    if (threshold_tree == NULL) {
+      ERROR("ut_config: c_avl_create failed.");
+      return -1;
     }
   }
 
-  memset (&th, '\0', sizeof (th));
-  th.warning_min = NAN;
-  th.warning_max = NAN;
-  th.failure_min = NAN;
-  th.failure_max = NAN;
-
-  th.hits = 0;
-  th.hysteresis = 0;
-  th.flags = UT_FLAG_INTERESTING; /* interesting by default */
+  threshold_t th = {
+      .warning_min = NAN,
+      .warning_max = NAN,
+      .failure_min = NAN,
+      .failure_max = NAN,
+      .flags = UT_FLAG_INTERESTING /* interesting by default */
+  };
 
-  for (i = 0; i < ci->children_num; i++)
-  {
+  for (int i = 0; i < ci->children_num; i++) {
     oconfig_item_t *option = ci->children + i;
 
-    if (strcasecmp ("Type", option->key) == 0)
-      status = ut_config_type (&th, option);
-    else if (strcasecmp ("Plugin", option->key) == 0)
-      status = ut_config_plugin (&th, option);
-    else if (strcasecmp ("Host", option->key) == 0)
-      status = ut_config_host (&th, option);
-    else
-    {
-      WARNING ("threshold values: Option `%s' not allowed here.", option->key);
+    if (strcasecmp("Type", option->key) == 0)
+      status = ut_config_type(&th, option);
+    else if (strcasecmp("Plugin", option->key) == 0)
+      status = ut_config_plugin(&th, option);
+    else if (strcasecmp("Host", option->key) == 0)
+      status = ut_config_host(&th, option);
+    else {
+      WARNING("threshold values: Option `%s' not allowed here.", option->key);
       status = -1;
     }
 
@@ -917,20 +821,16 @@ static int ut_config (oconfig_item_t *ci)
   }
 
   /* register callbacks if this is the first time we see a valid config */
-  if ((old_size == 0) && (c_avl_size (threshold_tree) > 0))
-  {
-    plugin_register_missing ("threshold", ut_missing,
-        /* user data = */ NULL);
-    plugin_register_write ("threshold", ut_check_threshold,
-        /* user data = */ NULL);
+  if ((old_size == 0) && (c_avl_size(threshold_tree) > 0)) {
+    plugin_register_missing("threshold", ut_missing,
+                            /* user data = */ NULL);
+    plugin_register_write("threshold", ut_check_threshold,
+                          /* user data = */ NULL);
   }
 
-  return (status);
+  return status;
 } /* }}} int um_config */
 
-void module_register (void)
-{
-  plugin_register_complex_config ("threshold", ut_config);
+void module_register(void) {
+  plugin_register_complex_config("threshold", ut_config);
 }
-
-/* vim: set sw=2 ts=8 sts=2 tw=78 et fdm=marker : */