collectd.git
9 days agoMerge pull request #3170 from stratakis/py38 master
Pavel Rochnyak [Fri, 7 Jun 2019 15:56:21 +0000 (22:56 +0700)]
Merge pull request #3170 from stratakis/py38

Add Python 3.8 compatibility

9 days agoAdd Python 3.8 compatibility
Charalampos Stratakis [Fri, 7 Jun 2019 14:43:56 +0000 (16:43 +0200)]
Add Python 3.8 compatibility

From Python 3.8 and onwards C extensions are no longer
linked to libpython so in order to embed python within
an application the --embed flag needs to be added to
python3-config --libs. A fall back is provided as the
command will error out on previous python versions.

References: https://bugs.python.org/issue36721

13 days agoMerge pull request #3167 from ashie/remove-needless-tab
Pavel Rochnyak [Tue, 4 Jun 2019 03:23:49 +0000 (10:23 +0700)]
Merge pull request #3167 from ashie/remove-needless-tab

Makefile.am: Remove a needless tab

13 days agoMakefile.am: Remove a needless tab
Takuro Ashie [Tue, 4 Jun 2019 00:43:31 +0000 (09:43 +0900)]
Makefile.am: Remove a needless tab

13 days agoMerge pull request #3163 from rpv-tomsk/virt-1
Matthias Runge [Mon, 3 Jun 2019 08:17:20 +0000 (10:17 +0200)]
Merge pull request #3163 from rpv-tomsk/virt-1

virt plugin: improvements

2 weeks agovirt plugin: Use virGetLastError() instead of virConnGetLastError()
Pavel Rochnyack [Wed, 29 May 2019 16:02:41 +0000 (23:02 +0700)]
virt plugin: Use virGetLastError() instead of virConnGetLastError()

libvirt documentation explicitly points us to use virGetLastError():

 In a multi-threaded application, always use the global
 virGetLastError() API which is backed by thread local storage.

2 weeks agovirt plugin: minor updates after review
Pavel Rochnyack [Wed, 29 May 2019 15:45:03 +0000 (22:45 +0700)]
virt plugin: minor updates after review

2 weeks agoMerge pull request #3158 from smortex/riemann-meta-data
Pavel Rochnyak [Tue, 28 May 2019 09:35:18 +0000 (16:35 +0700)]
Merge pull request #3158 from smortex/riemann-meta-data

Copy MetaData to Riemann events in write_riemann

3 weeks agovirt plugin: Added connection state check via virConnectIsAlive()
Pavel Rochnyack [Fri, 24 May 2019 10:56:27 +0000 (17:56 +0700)]
virt plugin: Added connection state check via virConnectIsAlive()

Before this fix, if libvirt daemon was stopped, Collectd starts to spam logs with lot of "failed" messages.

With this fix it correctly re-establishes connection.

3 weeks agovirt plugin: Added timeout to event_loop thread
Pavel Rochnyack [Fri, 24 May 2019 10:48:18 +0000 (17:48 +0700)]
virt plugin: Added timeout to event_loop thread

As per virEventRunDefaultImpl() documentation, this function will block
forever if there are no registered event handlers.

This leads to Collectd is unable to correctly stop event_loop thread
if libvirtd was restarted.

Added empty timeout callback to fix this.

3 weeks agovirt plugin: Disable ExtraStats selectors when unsupported by libvirt
Pavel Rochnyack [Thu, 23 May 2019 20:46:26 +0000 (03:46 +0700)]
virt plugin: Disable ExtraStats selectors when unsupported by libvirt

When function is not supported by driver, log filled by continuous messages like:

libvirt: Domain Config error : this function is not supported by the connection driver: virDomainGetDiskErrors

libvirt API allows us to detect such cases and disable unsupported calls.

3 weeks agovirt plugin: Fixed typos and inconsistencies
Pavel Rochnyack [Thu, 23 May 2019 19:42:52 +0000 (02:42 +0700)]
virt plugin: Fixed typos and inconsistencies

3 weeks agovirt plugin: Do not request cpu maps when not required
Pavel Rochnyack [Thu, 23 May 2019 21:16:47 +0000 (04:16 +0700)]
virt plugin: Do not request cpu maps when not required

3 weeks agovirt plugin: Added ExtraStats selector 'vcpu'
Pavel Rochnyack [Thu, 23 May 2019 21:10:12 +0000 (04:10 +0700)]
virt plugin: Added ExtraStats selector 'vcpu'

This allows to disable virDomainGetVcpus calls when hypervisor/driver
does not supports that function.

Closes: #2615

3 weeks agovirt plugin: Added ExtraStats selector 'memory'
Pavel Rochnyack [Thu, 23 May 2019 19:37:53 +0000 (02:37 +0700)]
virt plugin: Added ExtraStats selector 'memory'

This allows to disable virDomainMemoryStats calls when hypervisor/drivers
does not supports that function or it does not provide additional details.

4 weeks agoMerge pull request #3125 from skob/master
Pavel Rochnyak [Sun, 19 May 2019 11:31:45 +0000 (18:31 +0700)]
Merge pull request #3125 from skob/master

mysql: [impr] enable uptime metric

4 weeks agomysql: [impr] enable uptime metric
Pavel Rochnyack [Sun, 19 May 2019 11:19:48 +0000 (18:19 +0700)]
mysql: [impr] enable uptime metric

4 weeks agoCopy MetaData to Riemann events
Romain Tartière [Fri, 17 May 2019 18:43:25 +0000 (08:43 -1000)]
Copy MetaData to Riemann events

Make it possible to capture information using filters in collectd and
use this information in Riemann for deciding what to do with the event.

ChangeLog: write_riemann plugin: MetaData is copied to Riemann events

4 weeks agoMerge pull request #2986 from shastah/feature/curl-address-family
Pavel Rochnyak [Wed, 15 May 2019 03:28:20 +0000 (10:28 +0700)]
Merge pull request #2986 from shastah/feature/curl-address-family

curl plugin: add AddressFamily

4 weeks agocurl_xml plugin: add AddressFamily
Jakub Jankowski [Tue, 14 May 2019 00:16:35 +0000 (02:16 +0200)]
curl_xml plugin: add AddressFamily

In situations when hostnames in URLs resolve to both IPv4 and IPv6
addresses, sometimes it's useful to have separate statistics for both
of these separately.

With this commit, within <URL> block you can set
  AddressFamily "ipv6"
or
  AddressFamily "ipv4"
to specifically use one or the other.

Signed-off-by: Jakub Jankowski <shasta@toxcorp.com>
4 weeks agocurl_json plugin: add AddressFamily
Jakub Jankowski [Tue, 14 May 2019 00:00:18 +0000 (02:00 +0200)]
curl_json plugin: add AddressFamily

In situations when hostnames in URLs resolve to both IPv4 and IPv6
addresses, sometimes it's useful to have separate statistics for both
of these separately.

With this commit, within <URL> block you can set
  AddressFamily "ipv6"
or
  AddressFamily "ipv4"
to specifically use one or the other.

Signed-off-by: Jakub Jankowski <shasta@toxcorp.com>
4 weeks agoMerge pull request #3152 from rpv-tomsk/libvirt-memory-report
Ruben Kerkhof [Mon, 13 May 2019 12:47:36 +0000 (14:47 +0200)]
Merge pull request #3152 from rpv-tomsk/libvirt-memory-report

virt plugin: Fix typo after #3151

4 weeks agoMerge pull request #3148 from rpv-tomsk/libvirt-1
Pavel Rochnyak [Mon, 13 May 2019 12:33:44 +0000 (19:33 +0700)]
Merge pull request #3148 from rpv-tomsk/libvirt-1

virt plugin: Updates regarding to 'domain_state' metric

4 weeks agoMerge pull request #3151 from rpv-tomsk/libvirt-memory-report
Ruben Kerkhof [Mon, 13 May 2019 11:42:44 +0000 (13:42 +0200)]
Merge pull request #3151 from rpv-tomsk/libvirt-memory-report

Libvirt plugin: split memory report into dedicated types

4 weeks agoMerge pull request #3150 from rpv-tomsk/libvirt-3
Ruben Kerkhof [Mon, 13 May 2019 11:41:33 +0000 (13:41 +0200)]
Merge pull request #3150 from rpv-tomsk/libvirt-3

virt plugin: Added new code of virDomainShutoffReason enum and domain events

4 weeks agoMerge pull request #3149 from rpv-tomsk/libvirt-2
Ruben Kerkhof [Mon, 13 May 2019 11:40:19 +0000 (13:40 +0200)]
Merge pull request #3149 from rpv-tomsk/libvirt-2

virt plugin: Do not fail if no connection on init()

4 weeks agoMerge pull request #3147 from rpv-tomsk/libvirt
Ruben Kerkhof [Mon, 13 May 2019 11:38:38 +0000 (13:38 +0200)]
Merge pull request #3147 from rpv-tomsk/libvirt

virt plugin: Support new metric from libvirt-5.0.0 virDomainMemoryStats()

4 weeks agovirt plugin: Fix typo
Pavel Rochnyack [Mon, 13 May 2019 09:07:56 +0000 (16:07 +0700)]
virt plugin: Fix typo

4 weeks agovirt plugin: clang-format
Pavel Rochnyack [Mon, 13 May 2019 09:04:46 +0000 (16:04 +0700)]
virt plugin: clang-format

4 weeks agovirt plugin: Added support for new shutdown event details
Pavel Rochnyack [Mon, 13 May 2019 08:13:50 +0000 (15:13 +0700)]
virt plugin: Added support for new shutdown event details

4 weeks agovirt plugin: Check for virt_notif_thread_init() success
Pavel Rochnyack [Mon, 13 May 2019 07:31:39 +0000 (14:31 +0700)]
virt plugin: Check for virt_notif_thread_init() success

4 weeks agovirt plugin: Added debug message
Pavel Rochnyack [Mon, 13 May 2019 07:26:22 +0000 (14:26 +0700)]
virt plugin: Added debug message

5 weeks agovirt plugin: do not report empty metrics
Pavel Rochnyack [Sun, 12 May 2019 19:59:23 +0000 (02:59 +0700)]
virt plugin: do not report empty metrics

5 weeks agovirt plugin: Split domain memory reporting to appropriate types
Pavel Rochnyack [Sun, 12 May 2019 19:11:47 +0000 (02:11 +0700)]
virt plugin: Split domain memory reporting to appropriate types

5 weeks agovirt plugin: Skip 'last_update' reporting as that is not memory but timestamp
Pavel Rochnyack [Sun, 12 May 2019 13:07:56 +0000 (20:07 +0700)]
virt plugin: Skip 'last_update' reporting as that is not memory but timestamp

5 weeks agovirt plugin: Added new code of virDomainShutoffReason enum
Pavel Rochnyack [Sun, 12 May 2019 18:43:57 +0000 (01:43 +0700)]
virt plugin: Added new code of virDomainShutoffReason enum

5 weeks agovirt plugin: Fixed virt_notif_thread_init() place
Pavel Rochnyack [Sun, 12 May 2019 12:26:38 +0000 (19:26 +0700)]
virt plugin: Fixed virt_notif_thread_init() place

5 weeks agovirt plugin: Do not fail if no connection on init()
Pavel Rochnyack [Sun, 12 May 2019 10:19:22 +0000 (17:19 +0700)]
virt plugin: Do not fail if no connection on init()

If Collectd started before libvirtd, that results as no connection and no more retries.
lv_init()/lv_connect() reworked to avoid this.

Reference: b2541eb463165a5973fedb5d51eab8288fcd7ebc
Reference: 5903e6d5414b1a9580a63c29afff1788cec6c91e

5 weeks agovirt plugin: Do not report 'domain_state' metric when not enabled by ExtraStats
Pavel Rochnyack [Sun, 12 May 2019 08:53:08 +0000 (15:53 +0700)]
virt plugin: Do not report 'domain_state' metric when not enabled by ExtraStats

PR #2701 adds 'domain_state' metric and ExtraStats's option `domain_state`
selector behaviour was changed: now it enables metric, not notification.
Removed inconsistency between documentation and implementation.

Not all `get_domain_state` calls was covered by selector check.
As result, metric was always sent for inactive domains.
That is fixed now.

5 weeks agovirt plugin: Renamed get_domain_state() to submit_domain_state()
Pavel Rochnyack [Sun, 12 May 2019 07:12:09 +0000 (14:12 +0700)]
virt plugin: Renamed get_domain_state() to submit_domain_state()

That function does not gets something to internal structures, but submits metric.

5 weeks agovirt plugin: Cleanup excessive check
Pavel Rochnyack [Sun, 12 May 2019 06:56:05 +0000 (13:56 +0700)]
virt plugin: Cleanup excessive check

That is already covered by check at upper level:

if (inst->id == 0 && persistent_notification)
  persistent_domains_state_notification();

5 weeks agovirt plugin: Support new metric from libvirt-5.0.0 virDomainMemoryStats()
Pavel Rochnyack [Sun, 12 May 2019 06:11:41 +0000 (13:11 +0700)]
virt plugin: Support new metric from libvirt-5.0.0 virDomainMemoryStats()

Closes: #3143

5 weeks agoMerge pull request #3019 from sradco/master
Ruben Kerkhof [Tue, 7 May 2019 08:04:33 +0000 (10:04 +0200)]
Merge pull request #3019 from sradco/master

Add write_syslog output plugin

6 weeks agoMerge pull request #3144 from rpv-tomsk/lua
Ruben Kerkhof [Thu, 2 May 2019 09:28:44 +0000 (11:28 +0200)]
Merge pull request #3144 from rpv-tomsk/lua

lua plugin: Make it possible to register more than one reader/writer; bugfixes; cleanup.

6 weeks agolua plugin: Make it possible to register more than one reader/writer.
Pavel Rochnyack [Wed, 1 May 2019 17:21:02 +0000 (00:21 +0700)]
lua plugin: Make it possible to register more than one reader/writer.

lua_tostring(), used to identify readers/writers, doesn't work
on functions (it returns NULL). So, callback name is not unique and
its registration fail.

Added code to store script path and callback index in LUA Registry and
to build callback name based on them.

Added possibility to pass LUA callback as global-scope function name.
In this case callback name is built using function name, not callback
index.

Closes: #2379
Closes: #3139

6 weeks agolua plugin: remove line feed in error message
Pavel Rochnyack [Wed, 1 May 2019 13:27:01 +0000 (20:27 +0700)]
lua plugin: remove line feed in error message

6 weeks agolua plugin: Don't destroy interpreter early
Pavel Rochnyack [Wed, 1 May 2019 12:50:21 +0000 (19:50 +0700)]
lua plugin: Don't destroy interpreter early

If script successfully registered at least one callback,
destroying interpreter will cause Collectd crash when
that callback will be called.

Unfortunately, there is no way to unregister these callbacks

6 weeks agolua plugin: free mutex on callback destroy
Pavel Rochnyack [Wed, 1 May 2019 12:32:14 +0000 (19:32 +0700)]
lua plugin: free mutex on callback destroy

6 weeks agolua plugin: don't elements from stack in `clua_store_thread`.
Pavel Rochnyack [Wed, 1 May 2019 09:10:35 +0000 (16:10 +0700)]
lua plugin: don't elements from stack in `clua_store_thread`.

Debug, before:

lua plugin: nargs after store_callback: 1
lua plugin: nargs after lua_newthread: 2
lua plugin: nargs after store_thread: 0

After:

lua plugin: nargs after store_callback: 1
lua plugin: nargs after lua_newthread: 2
lua plugin: nargs after store_thread: 1

So, stack is in expected state.

6 weeks agolua: cleanup
Pavel Rochnyack [Wed, 1 May 2019 07:32:52 +0000 (14:32 +0700)]
lua: cleanup

6 weeks agoMerge pull request #3001 from usev6/write_graphite_reverse_host
Pavel Rochnyak [Tue, 30 Apr 2019 07:54:53 +0000 (14:54 +0700)]
Merge pull request #3001 from usev6/write_graphite_reverse_host

write_graphite plugin: Add option to reverse host

6 weeks agoDeclare var inside loop (code review change)
usev6 [Tue, 30 Apr 2019 05:39:23 +0000 (07:39 +0200)]
Declare var inside loop (code review change)

6 weeks agoMerge pull request #3141 from ometol/master
Pavel Rochnyak [Mon, 29 Apr 2019 18:59:42 +0000 (01:59 +0700)]
Merge pull request #3141 from ometol/master

cpufreq plugin: Add FreeBSD support

6 weeks agoApply suggestions from code review
usev6 [Mon, 29 Apr 2019 18:28:34 +0000 (20:28 +0200)]
Apply suggestions from code review

* Use constant DATA_MAX_NAME_LEN instead of re-calculating array size
* Declare and initialize second loop var in for statement

6 weeks agoUpdate to resolve conflicts due to renamed files
usev6 [Mon, 29 Apr 2019 18:03:14 +0000 (20:03 +0200)]
Update to resolve conflicts due to renamed files

Merge branch 'master' into write_graphite_reverse_host

7 weeks agoChanges after applying contrib/format.sh
Marco van Tol [Tue, 23 Apr 2019 21:27:57 +0000 (23:27 +0200)]
Changes after applying contrib/format.sh

7 weeks agoAdd documentation for the FreeBSD bit for cpufreq
Marco van Tol [Tue, 23 Apr 2019 21:18:19 +0000 (23:18 +0200)]
Add documentation for the FreeBSD bit for cpufreq

7 weeks agoFix warnings when we're unable to poll
Marco van Tol [Tue, 23 Apr 2019 17:46:51 +0000 (19:46 +0200)]
Fix warnings when we're unable to poll

7 weeks agoAdd FreeBSD support for cpufreq
Marco van Tol [Tue, 23 Apr 2019 15:45:54 +0000 (17:45 +0200)]
Add FreeBSD support for cpufreq

2 months agoMerge pull request #3137 from dangowrt/master
Pavel Rochnyak [Sat, 13 Apr 2019 03:57:28 +0000 (10:57 +0700)]
Merge pull request #3137 from dangowrt/master

Add support for RS485 to modbus plugin

2 months agoAdd support for RS485 to modbus plugin
Daniel Golle [Thu, 28 Mar 2019 00:52:04 +0000 (01:52 +0100)]
Add support for RS485 to modbus plugin

Allow setting up RS485 mode for Modbus-RTU

2 months agoMerge pull request #3136 from mrunge/systemd_service
Ruben Kerkhof [Wed, 10 Apr 2019 09:09:25 +0000 (11:09 +0200)]
Merge pull request #3136 from mrunge/systemd_service

Remove ProtectSystem from service file

2 months agoRemove ProtectSystem from service file
Matthias Runge [Fri, 5 Apr 2019 13:19:19 +0000 (15:19 +0200)]
Remove ProtectSystem from service file

This prevents showing eg. /etc if that's a separate file system.

Resolves: https://github.com/collectd/collectd/issues/3134

2 months agoMerge pull request #2891 from elfiesmelfie/feat_intel_rdt
Matthias Runge [Thu, 4 Apr 2019 05:58:51 +0000 (07:58 +0200)]
Merge pull request #2891 from elfiesmelfie/feat_intel_rdt

Intel RDT plugin: add support for groups of PIDs.

2 months agoMerge pull request #3117 from elfiesmelfie/virt_fix_option_parsing
Matthias Runge [Thu, 4 Apr 2019 05:57:42 +0000 (07:57 +0200)]
Merge pull request #3117 from elfiesmelfie/virt_fix_option_parsing

virt: Fix parsing config file options

2 months agoMerge pull request #3116 from rpv-tomsk/collectd-master
Matthias Runge [Thu, 4 Apr 2019 05:46:52 +0000 (07:46 +0200)]
Merge pull request #3116 from rpv-tomsk/collectd-master

virt plugin: Fix segfaults on shutdown

2 months agovirt: Add NULL checking to multiple config strings validation
Antoine Naud [Thu, 28 Mar 2019 13:25:23 +0000 (13:25 +0000)]
virt: Add NULL checking to multiple config strings validation

Remove ERROR messages as requested by reviewer and one unnecessary condition in
if statement.

Change-Id: I2fc01f16789f7720b09d923c72339d7123d3863a
Signed-off-by: Antoine Naud <antoinex.naud@intel.com>
2 months agointel_rdt: multiple options are explicitly denied
Kamil Wiatrowski [Fri, 22 Mar 2019 13:49:57 +0000 (14:49 +0100)]
intel_rdt: multiple options are explicitly denied

Add a check to avoid placing multiple Cores or Processes options in
intel_rdt configuration in order to avoid misuse and errors.

Change-Id: I82504a650bf9c568862da9f129a84a3079990496
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
2 months agovirt: Add NULL checking to multiple config strings validation
Radoslaw Jablonski [Fri, 15 Mar 2019 06:42:55 +0000 (06:42 +0000)]
virt: Add NULL checking to multiple config strings validation

Change-Id: Ic1595a9438f5af6872dc030db949223477b3f238
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
2 months agocollect.conf.pod: Add more info about virt filtering options
Radoslaw Jablonski [Mon, 4 Feb 2019 13:35:35 +0000 (13:35 +0000)]
collect.conf.pod: Add more info about virt filtering options

Added more info and examples regarding virt filtering options:
-filtering by domain name
-filtering block devices
-filtering network interfaces

Change-Id: I5cfe41658f62f429b799aa93a3d0f96f7cf8b780
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
2 months agovirt: Fix domain filtering option
Radoslaw Jablonski [Fri, 1 Feb 2019 15:46:29 +0000 (15:46 +0000)]
virt: Fix domain filtering option

Previously all domains were visible even if certain domains
should be filtered (only block devices and interface devices
were filtered instead of entire domains)
Now entire domains are filtered - if domain should be filtered
out, then it won't be visible the same way as filtered
block devices and network interfaces.

Change-Id: Ib4e50ad32fd94c900c3e83353d28ae06cbfdb442
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
2 months agovirt: Fix network interface filtering
Radoslaw Jablonski [Thu, 31 Jan 2019 14:05:28 +0000 (14:05 +0000)]
virt: Fix network interface filtering

Previously network device filtering was not working properly
if InterfaceFormat was set to 'name' or 'address' values.
Additionally implementation for filtering by interface number
was missing.

Change-Id: Ic6aa1d355423305d08bcab8282dc29009b200b5a
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
2 months agovirt: Fix parsing configuration options
Radoslaw Jablonski [Tue, 12 Mar 2019 09:02:06 +0000 (09:02 +0000)]
virt: Fix parsing configuration options

-lv_config function was re-written to use complex config callback

-fixed invalid parsing that caused collectd termination even if values
in config file for virt were correct(ExtraStats and RefreshInterval)

-added return statement to properly finish successful parsing
'ExtraStats' option value - without that, parsing of config file will
fail if 'ExtraStats' option is used in the collectd config file
because return code is the one for unrecognized parameter key.

-fixed parsing of RefreshInterval - previously error was thrown by
mistake if value was not written between double quotes(i.e. "60" was
fine but 60 was not)

-previously validation for boolean option value(such as value of
'IgnoreSelected' parameter) in virt plugin was missing and bad input
in config file could be unnoticed by user(in config file, boolean
value is parsed from its string representation). Now validation is
added and error is thrown whenever value can't be parsed directly as
'true'|'yes'|'on' or 'false'|'no'|'off'.

-additionally error messages have been added in all places where
parsing failed in order to notify the user about the reason of
collectd initialization failure.

Change-Id: I2069977395371e89f4a02eb544ffb7bda8c5c5ce
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
3 months agomysql: [impr] enable uptime metric
SK [Tue, 12 Mar 2019 20:26:17 +0000 (23:26 +0300)]
mysql: [impr] enable uptime metric

3 months agovirt plugin: Changed place of event loop start/stop debug messages output
Pavel Rochnyack [Tue, 12 Mar 2019 15:51:33 +0000 (22:51 +0700)]
virt plugin: Changed place of event loop start/stop debug messages output

3 months agoMerge pull request #2874 from elfiesmelfie/feat_virt_block_info
Pavel Rochnyak [Thu, 7 Mar 2019 18:26:15 +0000 (01:26 +0700)]
Merge pull request #2874 from elfiesmelfie/feat_virt_block_info

virt: Add block info statistics for disk devices

3 months agoAdd write_syslog output plugin
Shirly Radco [Wed, 5 Dec 2018 19:32:16 +0000 (21:32 +0200)]
Add write_syslog output plugin

This patch adds an output plugin to send metrics
as CEE-enhanced Syslog log messages by TCP .

The syslog message includes the metrics data in
human readable structured data format and in json
format.

It allows adding additional metedata.

This plugin is based on the write_tsdb plugin.

Signed-off-by: Shirly Radco <sradco@redhat.com>
3 months agovirt: Fetch block info stats from libvirt only if needed
Radoslaw Jablonski [Thu, 28 Feb 2019 14:14:01 +0000 (14:14 +0000)]
virt: Fetch block info stats from libvirt only if needed

Domain block info statistics will be retrieved from libvirt
only if one of extra stats is enabled:
- ex_stats_disk_allocation
- ex_stats_disk_capacity
- ex_stats_disk_physical

Change-Id: I0367c6ec7aafbf9558aaa100a12d40605ab9ba72
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
3 months agoMerge pull request #3108 from rubenk/cirrus-improvements
Marc Fournier [Thu, 7 Mar 2019 10:31:10 +0000 (11:31 +0100)]
Merge pull request #3108 from rubenk/cirrus-improvements

Cirrus improvements

3 months agointel_rdt: Added check if name group is defined before updating of pids list
Aleksinski, MichalX [Wed, 6 Mar 2019 13:50:17 +0000 (13:50 +0000)]
intel_rdt: Added check if name group is defined before updating of pids list

Change-Id: Ic99acd51be69d2678f25bdde9ca37011ad24fe99

3 months agointel_rdt: Fixed compile error in debug build
Aleksinski, MichalX [Thu, 28 Feb 2019 07:20:15 +0000 (07:20 +0000)]
intel_rdt: Fixed compile error in debug build

Change-Id: Ia932f377c5194240aab910d052e422b99ea542a5

3 months agoutils_proc_pids: moved to utils directory
Aleksinski, MichalX [Wed, 20 Feb 2019 12:32:50 +0000 (12:32 +0000)]
utils_proc_pids: moved to utils directory

Change-Id: Ia7c9bf5dca2b871b05c9ed3876059e6d34bd943e

3 months agointel_rdt: refactored proc utils to increase efficiency
Aleksinski, MichalX [Wed, 7 Nov 2018 23:59:26 +0000 (23:59 +0000)]
intel_rdt: refactored proc utils to increase efficiency

Change-Id: Ibb0dc6fe59eb77a217ab3b45ec0c1437bc9eb281

3 months agointel_rdt: updated pqos mocks for pqos version 3.0
Aleksinski, MichalX [Fri, 22 Feb 2019 07:10:00 +0000 (07:10 +0000)]
intel_rdt: updated pqos mocks for pqos version 3.0

Change-Id: Ibcf8c2fd6d1b490cbeeef7480c49da84389104f4

3 months agointel_rdt: close file descriptor on error
Aleksinski, MichalX [Fri, 26 Oct 2018 01:02:09 +0000 (02:02 +0100)]
intel_rdt: close file descriptor on error

Change-Id: I161c8df1e6a4c4c4e0dd4e20601323ef7a1c18f5

3 months agoFix for CI error in test code on epel6 platform.
Wojciech Andralojc [Mon, 6 Aug 2018 12:43:02 +0000 (13:43 +0100)]
Fix for CI error in test code on epel6 platform.

Signed-off-by: Wojciech Andralojc <wojciechx.andralojc@intel.com>
Change-Id: I325ea0728dd1eb65776f239b0d7977cc02f9c8db

3 months agointel_rdt: refactor pids monitoring code.
Mateusz Starzyk [Thu, 14 Jun 2018 05:28:39 +0000 (06:28 +0100)]
intel_rdt: refactor pids monitoring code.
Extract pids config to seperate file.
Extract pids config tests to seperate file.

Change-Id: I2978db56b15a126eced12f40baac631517303e04
Signed-off-by: Mateusz Starzyk <mateuszx.starzyk@intel.com>
3 months agointel-rdt: Changed memory allocation of new and lost pids tables from static to dynamic
Aleksinski, MichalX [Mon, 30 Jul 2018 08:09:00 +0000 (09:09 +0100)]
intel-rdt: Changed memory allocation of new and lost pids tables from static to dynamic

Change-Id: I3936fe78cfcbb4ce053d38ff1a3236c21eac9fd7
Signed-off-by: Michal Aleksinski <michalx.aleksinski@intel.com>
3 months agoCorrected issues reported by klockwork
Aleksinski, MichalX [Tue, 24 Jul 2018 07:39:20 +0000 (08:39 +0100)]
Corrected issues reported by klockwork

Change-Id: I3737a39c40d89a8782ef9c3d8195351f0fdeb278

3 months agointel_rdt: update unit-tests for process monitoring
Starzyk, MateuszX [Wed, 21 Mar 2018 08:14:53 +0000 (08:14 +0000)]
intel_rdt: update unit-tests for process monitoring

Refactor certain functions to be testable.

Change-Id: I5adb6ed1b076f0cebc70641f04dd101d4e89b9cc
Signed-off-by: Starzyk, MateuszX <mateuszx.starzyk@intel.com>
3 months agointel_rdt: collect data for monitored processes
Starzyk, MateuszX [Fri, 9 Mar 2018 12:20:01 +0000 (12:20 +0000)]
intel_rdt: collect data for monitored processes

Change-Id: Ib5a7d318bde69ee8f496b39ca74b3ee4e58d8f5b
Signed-off-by: Starzyk, MateuszX <mateuszx.starzyk@intel.com>
3 months agointel_rdt: Backwards compatibility, libpqos v1
Andralojc, WojciechX [Thu, 8 Mar 2018 15:00:26 +0000 (15:00 +0000)]
intel_rdt: Backwards compatibility, libpqos v1

Change-Id: I677c8215f89c04cedcb4c9e7d630f187a76a6cc7
Signed-off-by: Andralojc, WojciechX <wojciechx.andralojc@intel.com>
3 months agointel_rdt: PID groups change detection
Mateusz Starzyk [Fri, 15 Jun 2018 10:13:10 +0000 (11:13 +0100)]
intel_rdt: PID groups change detection

Change-Id: I569d72d0f12dca314e865f0b9236dc09a053c5e5
Signed-off-by: Andralojc, WojciechX <wojciechx.andralojc@intel.com>
3 months agointel_rdt: Update config parser for PID monitoring
Andralojc, WojciechX [Fri, 23 Feb 2018 14:44:57 +0000 (14:44 +0000)]
intel_rdt: Update config parser for PID monitoring

"Processes" option added.

Change-Id: I7f62a51fc06e0c7503caa7860807f1c8e09b2fa1
Signed-off-by: Andralojc, WojciechX <wojciechx.andralojc@intel.com>
3 months agointel_rdt: add PQOS API stubs for pid monitoring.
Starzyk, MateuszX [Thu, 1 Mar 2018 10:08:28 +0000 (10:08 +0000)]
intel_rdt: add PQOS API stubs for pid monitoring.

Add temporary functions to enable further development of rdt plugin.
These stubbed functions will be removed once libpqos extends it's API.

Change-Id: I39dd428e39fd6055774dfc39b4c0690aedee4ebe
Signed-off-by: Starzyk, MateuszX <mateuszx.starzyk@intel.com>
3 months agointel_rdt: adds pids extraction for given processes list
Starzyk, MateuszX [Mon, 19 Feb 2018 14:52:38 +0000 (14:52 +0000)]
intel_rdt: adds pids extraction for given processes list

adds intel_rdt_tests file with unit-tests of newly introduced functions.

Change-Id: I0e26322caa19f57b7d660807646bd437586cd80d
Signed-off-by: Starzyk, MateuszX <mateuszx.starzyk@intel.com>
3 months agovirt plugin: Fix segfaults on shutdown
Pavel Rochnyack [Tue, 26 Feb 2019 19:59:17 +0000 (02:59 +0700)]
virt plugin: Fix segfaults on shutdown

If connection has failed then `lv_init' returns early without initializing `notif_thread'.
This causes segfault due to incorrect `pthread_join()` call on Collectd shutdown.

Closes: #3082

3 months agoMerge pull request #3110 from rubenk/configure-ac-keep-plugin-list-sorted
Pavel Rochnyak [Thu, 21 Feb 2019 19:24:12 +0000 (02:24 +0700)]
Merge pull request #3110 from rubenk/configure-ac-keep-plugin-list-sorted

configure.ac: keep the list of plugins sorted

3 months agoconfigure.ac: keep the list of plugins sorted
Ruben Kerkhof [Thu, 21 Feb 2019 15:01:38 +0000 (16:01 +0100)]
configure.ac: keep the list of plugins sorted

3 months agoCirrus CI: remove musl-libc job
Ruben Kerkhof [Thu, 21 Feb 2019 10:59:29 +0000 (11:59 +0100)]
Cirrus CI: remove musl-libc job