collectd.git
3 years agoMerge pull request #3061 from octo/docs
Matthias Runge [Tue, 12 Feb 2019 12:58:27 +0000 (13:58 +0100)]
Merge pull request #3061 from octo/docs

CONTRIBUTING.md: Improve wording around ChangeLog; fix example.

3 years agoMerge pull request #3055 from dfandrich/travis
Ruben Kerkhof [Tue, 12 Feb 2019 10:11:45 +0000 (11:11 +0100)]
Merge pull request #3055 from dfandrich/travis

Add OS X to the Travis build matrix.

3 years agoMerge pull request #3021 from rubenk/libcollectdclient-fix-stringop-warning
Ruben Kerkhof [Tue, 12 Feb 2019 08:57:46 +0000 (09:57 +0100)]
Merge pull request #3021 from rubenk/libcollectdclient-fix-stringop-warning

Libcollectdclient fix stringop warning

3 years agoMerge pull request #2961 from octo/ff/utils
Florian Forster [Tue, 12 Feb 2019 08:37:26 +0000 (09:37 +0100)]
Merge pull request #2961 from octo/ff/utils

Tree wide: Move utilities and libraries to src/utils/.

3 years ago.travis.yml: Use the "apt" and "homebrew" add-ons.
Florian Forster [Tue, 12 Feb 2019 08:20:53 +0000 (09:20 +0100)]
.travis.yml: Use the "apt" and "homebrew" add-ons.

This might be more optimized than installing ourselves.

3 years ago.travis.yml: Remove $(nproc).
Florian Forster [Tue, 12 Feb 2019 07:42:51 +0000 (08:42 +0100)]
.travis.yml: Remove $(nproc).

nproc is not available on Mac OS X.

3 years agoTree wide: Move utilities and libraries to src/utils/.
Florian Forster [Thu, 18 Oct 2018 15:03:47 +0000 (17:03 +0200)]
Tree wide: Move utilities and libraries to src/utils/.

This is a first step that does not yet include *all* "utils_*.c" files,
but we're getting there.

3 years agoAdd OS X to the Travis build matrix.
Dan Fandrich [Fri, 1 Feb 2019 13:14:14 +0000 (14:14 +0100)]
Add OS X to the Travis build matrix.

3 years agoMerge branch 'collectd-5.8'
Florian Forster [Sun, 10 Feb 2019 20:50:51 +0000 (21:50 +0100)]
Merge branch 'collectd-5.8'

Conflicts:
src/sensors.c

3 years agoMerge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Sun, 10 Feb 2019 20:44:20 +0000 (21:44 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8

3 years agodocs/CONTRIBUTING.md: s/test/text/
Florian Forster [Sun, 10 Feb 2019 13:21:23 +0000 (14:21 +0100)]
docs/CONTRIBUTING.md: s/test/text/

3 years agoMove CONTRIBUTING.md to the docs/ directory.
Florian Forster [Sun, 10 Feb 2019 06:41:53 +0000 (07:41 +0100)]
Move CONTRIBUTING.md to the docs/ directory.

3 years agoCONTRIBUTING.md: Clarify our requirements for a "ChangeLog:" line.
Florian Forster [Sun, 10 Feb 2019 06:41:29 +0000 (07:41 +0100)]
CONTRIBUTING.md: Clarify our requirements for a "ChangeLog:" line.

3 years agoAuto-Merge pull request #3063 from octo/issue/3062
collectd bot [Thu, 7 Feb 2019 13:19:41 +0000 (14:19 +0100)]
Auto-Merge pull request #3063 from octo/issue/3062

Automatically merged due to "Automerge" label

3 years agostrjoin(): Fix behavior if output buffer is NULL.
Florian Forster [Thu, 7 Feb 2019 10:33:16 +0000 (11:33 +0100)]
strjoin(): Fix behavior if output buffer is NULL.

Additionally, test the (NULL, 0) output buffer for all test cases rather
than an individual, isolated test case.

Fixes: #3062

3 years agolibcollectdclient: fix minor cosmetic issue
Ruben Kerkhof [Fri, 14 Dec 2018 16:28:37 +0000 (17:28 +0100)]
libcollectdclient: fix minor cosmetic issue

String should be NUL-terminated, so compare with the NUL char

3 years agolibcollectdclient: fix gcc warning
Ruben Kerkhof [Fri, 14 Dec 2018 16:27:44 +0000 (17:27 +0100)]
libcollectdclient: fix gcc warning

make[1]: Entering directory '/home/ruben/src/collectd'
  CC       src/libcollectdclient/libcollectdclient_la-network_parse.lo
In function ‘parse_string’,
    inlined from ‘parse_identifier’ at src/libcollectdclient/network_parse.c:169:7,
    inlined from ‘network_parse.constprop’ at src/libcollectdclient/network_parse.c:540:11:
src/libcollectdclient/network_parse.c:161:3: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
   strncpy(out, in, out_size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~

3 years agoAuto-Merge pull request #3058 from cjmayo/debug_utf8
collectd bot [Thu, 7 Feb 2019 08:16:09 +0000 (09:16 +0100)]
Auto-Merge pull request #3058 from cjmayo/debug_utf8

Automatically merged due to "Automerge" label

3 years agoMerge pull request #3057 from cjmayo/style_smart_temperature
Florian Forster [Thu, 7 Feb 2019 08:04:29 +0000 (09:04 +0100)]
Merge pull request #3057 from cjmayo/style_smart_temperature

collection3: Add Type for smart_temperature

3 years agoCONTRIBUTING.md: Improve wording around ChangeLog; fix example.
Florian Forster [Thu, 7 Feb 2019 07:55:21 +0000 (08:55 +0100)]
CONTRIBUTING.md: Improve wording around ChangeLog; fix example.

3 years agoMerge pull request #3059 from octo/sock_cloexec
Florian Forster [Wed, 6 Feb 2019 22:16:01 +0000 (23:16 +0100)]
Merge pull request #3059 from octo/sock_cloexec

write_prometheus plugin: Only use SOCK_CLOEXEC if it is defined.

3 years agocollection3: Output graph.cgi debug as UTF-8
Chris Mayo [Wed, 6 Feb 2019 19:51:49 +0000 (19:51 +0000)]
collection3: Output graph.cgi debug as UTF-8

Ensure text and symbols e.g. degrees Celsius are shown as intended.

3 years agocollection3: Add Type for smart_temperature
Chris Mayo [Wed, 6 Feb 2019 19:40:04 +0000 (19:40 +0000)]
collection3: Add Type for smart_temperature

Copied from Type temperature.

3 years agowrite_prometheus plugin: Only use SOCK_CLOEXEC if it is defined.
Florian Forster [Wed, 6 Feb 2019 14:47:00 +0000 (15:47 +0100)]
write_prometheus plugin: Only use SOCK_CLOEXEC if it is defined.

Fixes compilation issue on Mac OS X. See also #3055.

3 years agoMerge pull request #3053 from collectd/code_owners
Florian Forster [Fri, 1 Feb 2019 11:14:27 +0000 (12:14 +0100)]
Merge pull request #3053 from collectd/code_owners

CODEOWNERS: Add code owners as discussed at the meetup.

3 years agoMerge pull request #3054 from octo/docs
Florian Forster [Fri, 1 Feb 2019 09:48:31 +0000 (10:48 +0100)]
Merge pull request #3054 from octo/docs

CONTRIBUTING.md: Document the new change log requirement / behavior.

3 years agoCONTRIBUTING.md: Document the new change log requirement / behavior.
Florian Forster [Fri, 1 Feb 2019 07:08:37 +0000 (08:08 +0100)]
CONTRIBUTING.md: Document the new change log requirement / behavior.

3 years agoCODEOWNERS: Add code owners as discussed at the meetup.
Florian Forster [Thu, 31 Jan 2019 15:35:39 +0000 (16:35 +0100)]
CODEOWNERS: Add code owners as discussed at the meetup.

See also: https://help.github.com/articles/about-code-owners/

3 years agoMerge pull request #3047 from cjmayo/style_border
Pavel Rochnyak [Thu, 31 Jan 2019 10:04:38 +0000 (17:04 +0700)]
Merge pull request #3047 from cjmayo/style_border

collection3: Improve index.cgi form fieldset border style

3 years agocollection3: Improve index.cgi form fieldset border style
Chris Mayo [Wed, 30 Jan 2019 20:22:47 +0000 (20:22 +0000)]
collection3: Improve index.cgi form fieldset border style

- Fit to the form contents instead of filling the page width
- Relate better to the table below by aligning the left-hand side and
  increasing the space between

3 years agoMerge pull request #3040 from AlexZzz/collectd-5.8
Pavel Rochnyak [Wed, 30 Jan 2019 07:44:10 +0000 (14:44 +0700)]
Merge pull request #3040 from AlexZzz/collectd-5.8

Backport: netlink plugin: Use of less strict rules in link_filter_cb()

3 years agoMerge pull request #3042 from srivasta/upstream-fixes
Ruben Kerkhof [Thu, 24 Jan 2019 20:35:36 +0000 (21:35 +0100)]
Merge pull request #3042 from srivasta/upstream-fixes

[python-3.7-fix]: Allow compilation with Python 3.7

3 years ago[python-3.7-fix]: Allow compilation with Python 3.7
Manoj Srivastava [Thu, 17 Jan 2019 19:08:56 +0000 (11:08 -0800)]
[python-3.7-fix]: Allow compilation with Python 3.7

PyOS_AfterFork() is deprecated in favour of the new functions
PyOS_BeforeFork(), PyOS_AfterFork_Parent() and
PyOS_AfterFork_Child(). (Contributed by Antoine Pitrou in bpo-16500.)

Since the -Werror=deprecated-declarations flag is on, the fact that
PyOS_AfterFork is deprecated now results in a warning, and since all
warnings being treated as errors, collectd fails to compile.

This commit detects when we have python 3.7 or newer, and uses the new
replacement function.

Signed-off-by: Manoj Srivastava <srivasta@golden-gryphon.com>
3 years agonetlink plugin: Use of less strict rules in link_filter_cb()
Pavel Rochnyack [Mon, 7 May 2018 15:53:23 +0000 (22:53 +0700)]
netlink plugin: Use of less strict rules in link_filter_cb()

mnl_attr_validate2() function implements strict equality check of kernel and
userspace structures size. Additional counters was added to 4.6 Linux kernel,
sizes was changed and mismatch can occur.

This patch weakened validation.
Now Collectd just checks if structures, received from kernel space, has enough
data.

Closes: #2510

# Conflicts:
# src/netlink.c

3 years agoprocesses: Reduce procstat entry 'age' limit
Pavel Rochnyack [Wed, 19 Dec 2018 13:44:25 +0000 (20:44 +0700)]
processes: Reduce procstat entry 'age' limit

The 'age' value can grow only when process terminated.

There is no sence to wait 10 read cycles for process rebirth.

Theoretically, this reduces probability for process data takeover by
another process with same pid.

Issue: #3026

3 years agoprocesses: Fix 'delay_rate' race condition
Pavel Rochnyack [Wed, 19 Dec 2018 12:57:04 +0000 (19:57 +0700)]
processes: Fix 'delay_rate' race condition

When ts_delay_by_tgid() failed (for example, when observable process
terminates), `ps->delay` fields are not updated and remain set to zero.

This interpreted as counter overflow and produces spike.

Issue: #3026

3 years agocollectd.conf(5): finish a sentence
Ruben Kerkhof [Tue, 18 Dec 2018 17:54:35 +0000 (18:54 +0100)]
collectd.conf(5): finish a sentence

3 years agocollectd.conf(5): fix a few typos
Ruben Kerkhof [Tue, 18 Dec 2018 17:52:08 +0000 (18:52 +0100)]
collectd.conf(5): fix a few typos

3 years agoRewrite configure check for CUDA
Ruben Kerkhof [Sun, 16 Dec 2018 19:16:59 +0000 (20:16 +0100)]
Rewrite configure check for CUDA

It had a bunch of issues, one of them that it touched CFLAGS, the other
that it didn't use CUDA_CFLAGS.

The check is still too simple, we need to check if we can actually use
the library instead of just the header.

3 years agoTreewide: do NUL-termination correctly
Ruben Kerkhof [Sun, 16 Dec 2018 14:11:02 +0000 (15:11 +0100)]
Treewide: do NUL-termination correctly

This is purely cosmetic but still, it sets a good example

3 years agoFix build
Ruben Kerkhof [Sun, 16 Dec 2018 13:04:04 +0000 (14:04 +0100)]
Fix build

lookup_identifier_t has a few array members.
To zero-initialize these we need a pair of extra braces.

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80454

3 years agoFix a couple of warnings in test suite
Ruben Kerkhof [Sun, 16 Dec 2018 12:40:53 +0000 (13:40 +0100)]
Fix a couple of warnings in test suite

src/utils_vl_lookup_test.c: In function ‘checked_lookup_add’:
src/utils_vl_lookup_test.c:91:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(ident.host, host, sizeof(ident.host));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c:92:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(ident.plugin, plugin, sizeof(ident.plugin));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c:93:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(ident.plugin_instance, plugin_instance,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           sizeof(ident.plugin_instance));
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c:95:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(ident.type, type, sizeof(ident.type));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c:96:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(ident.type_instance, type_instance, sizeof(ident.type_instance));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c: In function ‘checked_lookup_search’:
src/utils_vl_lookup_test.c:113:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(vl.host, host, sizeof(vl.host));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c:114:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(vl.plugin, plugin, sizeof(vl.plugin));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c:115:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(vl.plugin_instance, plugin_instance, sizeof(vl.plugin_instance));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c:116:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(vl.type, type, sizeof(vl.type));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils_vl_lookup_test.c:117:3: warning: ‘strncpy’ specified bound 128 equals destination size [-Wstringop-truncation]
   strncpy(vl.type_instance, type_instance, sizeof(vl.type_instance));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CCLD     test_utils_vl_lookup

3 years agoIgnore test-suite.log in all directories
Ruben Kerkhof [Sun, 16 Dec 2018 12:36:51 +0000 (13:36 +0100)]
Ignore test-suite.log in all directories

3 years agoMerge pull request #3022 from rubenk/treewide-fix-some-style-issues
Florian Forster [Sun, 16 Dec 2018 07:33:39 +0000 (08:33 +0100)]
Merge pull request #3022 from rubenk/treewide-fix-some-style-issues

Treewide: fix some style issues

3 years agoxencpu plugin: fix minor style issues
Ruben Kerkhof [Sat, 15 Dec 2018 18:35:42 +0000 (19:35 +0100)]
xencpu plugin: fix minor style issues

3 years agovirt plugin: fix some minor style issues
Ruben Kerkhof [Sat, 15 Dec 2018 18:26:04 +0000 (19:26 +0100)]
virt plugin: fix some minor style issues

3 years agoutils_rrdcreate.c: fix minor style issue
Ruben Kerkhof [Sat, 15 Dec 2018 18:20:43 +0000 (19:20 +0100)]
utils_rrdcreate.c: fix minor style issue

3 years agoutils_ovs.c: fix some minor stylistic issues
Ruben Kerkhof [Sat, 15 Dec 2018 18:17:16 +0000 (19:17 +0100)]
utils_ovs.c: fix some minor stylistic issues

3 years agoutils_db_query.c: fix some minor style issues
Ruben Kerkhof [Sat, 15 Dec 2018 18:07:56 +0000 (19:07 +0100)]
utils_db_query.c: fix some minor style issues

3 years agosnmp_agent plugin: fix minor nit
Ruben Kerkhof [Sat, 15 Dec 2018 18:01:41 +0000 (19:01 +0100)]
snmp_agent plugin: fix minor nit

3 years agopostgresql plugin: fix some stylistic issues
Ruben Kerkhof [Sat, 15 Dec 2018 17:57:17 +0000 (18:57 +0100)]
postgresql plugin: fix some stylistic issues

3 years agoovs_stats plugin: fix some stylistic issues
Ruben Kerkhof [Sat, 15 Dec 2018 17:53:24 +0000 (18:53 +0100)]
ovs_stats plugin: fix some stylistic issues

3 years agooracle plugin: remove unneccesary cast
Ruben Kerkhof [Sat, 15 Dec 2018 17:50:18 +0000 (18:50 +0100)]
oracle plugin: remove unneccesary cast

3 years agoliboconfig: fix minor style issues
Ruben Kerkhof [Sat, 15 Dec 2018 17:47:13 +0000 (18:47 +0100)]
liboconfig: fix minor style issues

3 years agolibcollectdclient: fix minor style issue
Ruben Kerkhof [Sat, 15 Dec 2018 17:44:40 +0000 (18:44 +0100)]
libcollectdclient: fix minor style issue

3 years agojava plugin: fix minor style issue
Ruben Kerkhof [Sat, 15 Dec 2018 17:42:59 +0000 (18:42 +0100)]
java plugin: fix minor style issue

3 years agoipmi plugin: remove unneccesary cast
Ruben Kerkhof [Sat, 15 Dec 2018 17:41:58 +0000 (18:41 +0100)]
ipmi plugin: remove unneccesary cast

3 years agointel_rdt plugin: fix some minor style issues
Ruben Kerkhof [Sat, 15 Dec 2018 17:38:00 +0000 (18:38 +0100)]
intel_rdt plugin: fix some minor style issues

3 years agointel_pmu plugin: fix some minor style issues
Ruben Kerkhof [Sat, 15 Dec 2018 17:36:36 +0000 (18:36 +0100)]
intel_pmu plugin: fix some minor style issues

3 years agogmond plugin: fix minor style issues
Ruben Kerkhof [Sat, 15 Dec 2018 17:33:00 +0000 (18:33 +0100)]
gmond plugin: fix minor style issues

3 years agodisk plugin: fix minor style issue
Ruben Kerkhof [Sat, 15 Dec 2018 17:29:29 +0000 (18:29 +0100)]
disk plugin: fix minor style issue

3 years agodaemon/utils_cache.c: fix minor style issue
Ruben Kerkhof [Sat, 15 Dec 2018 17:26:37 +0000 (18:26 +0100)]
daemon/utils_cache.c: fix minor style issue

3 years agodaemon/types_list.c: fix minor style issue
Ruben Kerkhof [Sat, 15 Dec 2018 17:23:55 +0000 (18:23 +0100)]
daemon/types_list.c: fix minor style issue

3 years agodaemon/plugin.c: fix two more stylistic issues
Ruben Kerkhof [Sat, 15 Dec 2018 17:22:30 +0000 (18:22 +0100)]
daemon/plugin.c: fix two more stylistic issues

3 years agodaemon/plugin.c: remove unneccesary casts
Ruben Kerkhof [Sat, 15 Dec 2018 17:21:18 +0000 (18:21 +0100)]
daemon/plugin.c: remove unneccesary casts

3 years agodaemon/plugin.c: fix minor style issue
Ruben Kerkhof [Sat, 15 Dec 2018 17:18:26 +0000 (18:18 +0100)]
daemon/plugin.c: fix minor style issue

3 years agocpufreq plugin: fix minor style issue
Ruben Kerkhof [Sat, 15 Dec 2018 17:13:42 +0000 (18:13 +0100)]
cpufreq plugin: fix minor style issue

3 years agobarometer plugin: remove unneccesary cast
Ruben Kerkhof [Sat, 15 Dec 2018 17:08:36 +0000 (18:08 +0100)]
barometer plugin: remove unneccesary cast

3 years agocollectd-nagios: remove unneccesary casts
Ruben Kerkhof [Fri, 14 Dec 2018 18:15:07 +0000 (19:15 +0100)]
collectd-nagios: remove unneccesary casts

3 years agoceph plugin: use recommended style for calloc
Ruben Kerkhof [Fri, 14 Dec 2018 18:13:15 +0000 (19:13 +0100)]
ceph plugin: use recommended style for calloc

4 years agoMerge pull request #3017 from rpv-tomsk/collectd-collectd-5.8
Pavel Rochnyak [Thu, 6 Dec 2018 17:14:04 +0000 (00:14 +0700)]
Merge pull request #3017 from rpv-tomsk/collectd-collectd-5.8

configure.ac: run dpdk build tests only if pkgconfig fails

4 years agoconfigure.ac: run dpdk build tests only if pkgconfig fails
Luca Boccassi [Mon, 3 Dec 2018 15:56:13 +0000 (15:56 +0000)]
configure.ac: run dpdk build tests only if pkgconfig fails

The AC_CHECK_LIB test runs unconditionally, and fails with DPDK 18.11
when built with Meson as there is no longer a libdpdk.so linker script,
but only a pkg-config file, so -ldpdk (which is what AC_CHECK_LIB runs)
fails.

Use AC_LINK_IFELSE instead, with compiler and linker flags set
appropriately.

Signed-off-by: Luca Boccassi <bluca@debian.org>
4 years agoMerge pull request #3015 from bluca/dpdk_pkgconfig
Pavel Rochnyak [Thu, 6 Dec 2018 16:59:36 +0000 (23:59 +0700)]
Merge pull request #3015 from bluca/dpdk_pkgconfig

configure.ac: run dpdk build tests only if pkgconfig fails

4 years agoconfigure.ac: run dpdk build tests only if pkgconfig fails
Luca Boccassi [Mon, 3 Dec 2018 15:56:13 +0000 (15:56 +0000)]
configure.ac: run dpdk build tests only if pkgconfig fails

The AC_CHECK_LIB test runs unconditionally, and fails with DPDK 18.11
when built with Meson as there is no longer a libdpdk.so linker script,
but only a pkg-config file, so -ldpdk (which is what AC_CHECK_LIB runs)
fails.

Use AC_LINK_IFELSE instead, with compiler and linker flags set
appropriately.

Signed-off-by: Luca Boccassi <bluca@debian.org>
4 years agovirt plugin: Add missing config_keys
Pavel Rochnyack [Wed, 5 Dec 2018 09:19:53 +0000 (16:19 +0700)]
virt plugin: Add missing config_keys

4 years agovirt plugin: New options: ReportBlockDevices and ReportNetworkInterfaces
Pavel Rochnyack [Wed, 5 Dec 2018 07:29:31 +0000 (14:29 +0700)]
virt plugin: New options: ReportBlockDevices and ReportNetworkInterfaces

This allows to disable unneeded reports if stats are gathered by another plugin.

4 years agovirt plugin: Move adding of devices into own functions
Pavel Rochnyack [Wed, 5 Dec 2018 06:52:47 +0000 (13:52 +0700)]
virt plugin: Move adding of devices into own functions

This also covers case when error while adding block device
refuse adding of domain network devices.

4 years agovirt plugin: Fixed mistake in variable rename
Pavel Rochnyack [Wed, 5 Dec 2018 06:28:30 +0000 (13:28 +0700)]
virt plugin: Fixed mistake in variable rename

4 years agovirt plugin: Handle ignorelists properly
Pavel Rochnyack [Wed, 5 Dec 2018 06:11:12 +0000 (13:11 +0700)]
virt plugin: Handle ignorelists properly

Added check for ignorelist_create() success.
Removed unnecessary "not null" checks in rest of code.

4 years agovirt plugin: Updated InterfaceFormat documentation
Pavel Rochnyack [Tue, 4 Dec 2018 17:20:36 +0000 (00:20 +0700)]
virt plugin: Updated InterfaceFormat documentation

4 years agoMerge pull request #3014 from rpv-tomsk/collectd-master
Pavel Rochnyak [Tue, 4 Dec 2018 08:54:44 +0000 (15:54 +0700)]
Merge pull request #3014 from rpv-tomsk/collectd-master

sensors plugin: Drop support for libsensors older than 3.0.0

4 years agoMerge pull request #3000 from teknoraver/master
Pavel Rochnyak [Mon, 3 Dec 2018 18:13:12 +0000 (01:13 +0700)]
Merge pull request #3000 from teknoraver/master

Add ovs-dpdk extended metrics

4 years agoindent with contrib/format.sh
Matteo Croce [Mon, 3 Dec 2018 17:21:03 +0000 (18:21 +0100)]
indent with contrib/format.sh

4 years agoAdd ovs-dpdk extended metrics
Matteo Croce [Mon, 3 Dec 2018 17:17:01 +0000 (18:17 +0100)]
Add ovs-dpdk extended metrics

Signed-off-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
4 years agoMerge pull request #3013 from rpv-tomsk/collectd-collectd-5.8
Pavel Rochnyak [Mon, 3 Dec 2018 11:57:29 +0000 (18:57 +0700)]
Merge pull request #3013 from rpv-tomsk/collectd-collectd-5.8

sensors: Removed checks for upper limit of SENSORS_API_VERSION

4 years agosensors plugin: Drop support for libsensors older than 3.0.0
Pavel Rochnyack [Mon, 3 Dec 2018 11:56:39 +0000 (18:56 +0700)]
sensors plugin: Drop support for libsensors older than 3.0.0

The lm_sensors-3.0.0, which introduces 'modern' API, released 2007-11-24.
The time came to drop older version support.

4 years agosensors: Removed checks for upper limit of SENSORS_API_VERSION
Pavel Rochnyack [Mon, 3 Dec 2018 11:34:14 +0000 (18:34 +0700)]
sensors: Removed checks for upper limit of SENSORS_API_VERSION

That makes no more sense after lm-sensors got new maintainers.

Issue: #3006

4 years agosensors: Removed checks for upper limit of SENSORS_API_VERSION
Pavel Rochnyack [Mon, 3 Dec 2018 11:34:14 +0000 (18:34 +0700)]
sensors: Removed checks for upper limit of SENSORS_API_VERSION

That makes no more sense after lm-sensors got new maintainers.

Closes: #3006

4 years agoMerge pull request #3012 from rpv-tomsk/collectd-master
Pavel Rochnyak [Mon, 3 Dec 2018 11:27:18 +0000 (18:27 +0700)]
Merge pull request #3012 from rpv-tomsk/collectd-master

ovs_stats: Cleanup and improve

4 years agoovs_stats: Optimize read callback
Pavel Rochnyack [Mon, 3 Dec 2018 10:38:17 +0000 (17:38 +0700)]
ovs_stats: Optimize read callback

4 years agoovs_stats: Do not create bridge if it has not be monitored.
Pavel Rochnyack [Mon, 3 Dec 2018 10:29:27 +0000 (17:29 +0700)]
ovs_stats: Do not create bridge if it has not be monitored.

4 years agoovs_stats: Fix indent
Pavel Rochnyack [Mon, 3 Dec 2018 10:16:17 +0000 (17:16 +0700)]
ovs_stats: Fix indent

4 years agoovs_stats: Locking reworked
Pavel Rochnyack [Mon, 3 Dec 2018 10:10:23 +0000 (17:10 +0700)]
ovs_stats: Locking reworked

Locking now done in unified way, on top-level.
That removes usage of global variables in unprotected way.

4 years agoovs_stats: Do not create ports if there is no bridge name
Pavel Rochnyack [Mon, 3 Dec 2018 09:32:29 +0000 (16:32 +0700)]
ovs_stats: Do not create ports if there is no bridge name

That has no sence, as it will not pass condition in ovs_stats_plugin_read()

4 years agoMerge pull request #3011 from rpv-tomsk/collectd-master
Pavel Rochnyak [Mon, 3 Dec 2018 06:52:44 +0000 (13:52 +0700)]
Merge pull request #3011 from rpv-tomsk/collectd-master

ovs_stats: Code style and cleanup

4 years agoovs_stats: Removed unused variable
Pavel Rochnyack [Mon, 3 Dec 2018 06:45:16 +0000 (13:45 +0700)]
ovs_stats: Removed unused variable

4 years agoovs_stats: Fix indents
Pavel Rochnyack [Mon, 3 Dec 2018 06:44:36 +0000 (13:44 +0700)]
ovs_stats: Fix indents

4 years agoMerge pull request #2880 from abays/add_ovs_stats_bonds_3
Pavel Rochnyak [Mon, 3 Dec 2018 05:49:18 +0000 (12:49 +0700)]
Merge pull request #2880 from abays/add_ovs_stats_bonds_3

ovs_stats bonds support with separate interface stats

4 years agoMerge pull request #3010 from rpv-tomsk/collectd-5.8
Pavel Rochnyak [Sun, 2 Dec 2018 20:03:17 +0000 (03:03 +0700)]
Merge pull request #3010 from rpv-tomsk/collectd-5.8

write_mongodb: Fix plugin dependencies

4 years agowrite_mongodb: Fix plugin dependencies
Pavel Rochnyack [Sun, 2 Dec 2018 19:48:08 +0000 (02:48 +0700)]
write_mongodb: Fix plugin dependencies

Issue: #2900