Zebity Spring [Fri, 12 Jul 2019 07:33:46 +0000 (17:33 +1000)]
Merge upstream, address conflict in src/utils/cmds/cmds_test.c
(cherry picked from commit
a72ad42076337f3b85db3b06565ae86a83226ab3)
Dagobert Michelsen [Fri, 5 Jul 2019 09:16:25 +0000 (11:16 +0200)]
Move Makefile rules for pid_test inside conditional for code
(cherry picked from commit
45b8c056d89f4b029e6017035ce6a4a37a36d260)
Dagobert Michelsen [Tue, 2 Jul 2019 11:56:54 +0000 (13:56 +0200)]
Add missing definitions for libnetsnmpagent
(cherry picked from commit
3b05d9f7b7b46e0c4fee296ad2d6f16ecc82173e)
Radoslaw Jablonski [Thu, 18 Jul 2019 11:01:25 +0000 (13:01 +0200)]
Merge pull request #3224 from mrunge/codeowners
Move trusted-contributors down the list
Matthias Runge [Thu, 18 Jul 2019 09:42:10 +0000 (11:42 +0200)]
Move trusted-contributors down the list
since the last matching pattern takes the most precedence.
rjablonx [Tue, 16 Jul 2019 10:53:11 +0000 (12:53 +0200)]
Merge pull request #3214 from rpv-tomsk/issue-3181
Issue 3181
Pavel Rochnyack [Sat, 13 Jul 2019 15:52:18 +0000 (22:52 +0700)]
daemon: Check if plugin actually loaded before reporting configuration issues
Issue: #3215
Pavel Rochnyack [Fri, 12 Jul 2019 13:04:48 +0000 (20:04 +0700)]
configure.ac: Removed unused checks for functions
Pavel Rochnyack [Fri, 12 Jul 2019 12:35:23 +0000 (19:35 +0700)]
daemon: Recover setlocale() call in src/daemon/collectd.c do_init()
865f2eb31e8264edd9337bc63ac59f6c2fa3b5a7 breaks locale checks
Issue: #3181
Pavel Rochnyack [Fri, 12 Jul 2019 12:07:39 +0000 (19:07 +0700)]
disk.c: remove unused lines
limits.h check removed in
865f2eb31e8264edd9337bc63ac59f6c2fa3b5a7
limits.h included in src/daemon/collectd.h unconditionally
Issue: #3181
sranga4 [Fri, 12 Jul 2019 20:43:33 +0000 (13:43 -0700)]
Merge pull request #3153 from zebity/master
Add snprintf wrapper to avoid "Truncation Warnings" with GCC 8.2/3 compiler
Zebity Spring [Fri, 12 Jul 2019 13:25:54 +0000 (23:25 +1000)]
Run contrib/format.sh across entire *.h/*.c source tree (2nd of 2)
Zebity Spring [Fri, 12 Jul 2019 13:09:51 +0000 (23:09 +1000)]
Run contrib/format.sh across entire *.h/*.c source tree (1st of 2)
rjablonx [Fri, 12 Jul 2019 11:09:00 +0000 (13:09 +0200)]
Merge pull request #3072 from octo/ff/network_test
Add a unit test for the network plugin.
Zebity Spring [Fri, 12 Jul 2019 08:09:56 +0000 (18:09 +1000)]
Merge remote-tracking branch 'upstream/master'
Zebity Spring [Fri, 12 Jul 2019 08:07:46 +0000 (18:07 +1000)]
run all updated *.h *.c through clang-format again
Zebity Spring [Fri, 12 Jul 2019 07:45:33 +0000 (17:45 +1000)]
Merge upstream, address conflict in src/utils/cmds/cmds_test.c
Zebity Spring [Fri, 12 Jul 2019 07:33:46 +0000 (17:33 +1000)]
Merge upstream, address conflict in src/utils/cmds/cmds_test.c
collectd bot [Wed, 10 Jul 2019 07:17:39 +0000 (09:17 +0200)]
Auto-Merge pull request #3206 from dago/pid_test
Automatically merged due to "Automerge" label
Dagobert Michelsen [Mon, 8 Jul 2019 11:23:18 +0000 (13:23 +0200)]
Fix bug that leads to CPPFLAGS gets overridden with CFLAGS when libxxms is enabled
Pavel Rochnyak [Fri, 5 Jul 2019 16:09:00 +0000 (23:09 +0700)]
Merge branch 'master' into master
Dagobert Michelsen [Fri, 5 Jul 2019 09:16:25 +0000 (11:16 +0200)]
Move Makefile rules for pid_test inside conditional for code
collectd bot [Fri, 5 Jul 2019 08:23:17 +0000 (10:23 +0200)]
Auto-Merge pull request #3205 from rpv-tomsk/3112-powerdns
Automatically merged due to "Automerge" label
Pavel Rochnyack [Fri, 5 Jul 2019 04:54:08 +0000 (11:54 +0700)]
powerdns: Added 'unreachables' reporting
Issue: #3112
Pavel Rochnyack [Fri, 5 Jul 2019 04:51:42 +0000 (11:51 +0700)]
powerdns: Fix formatting, broken by clang-format
collectd bot [Tue, 2 Jul 2019 13:53:05 +0000 (15:53 +0200)]
Auto-Merge pull request #3203 from dago/netsnmpagent
Automatically merged due to "Automerge" label
Dagobert Michelsen [Tue, 2 Jul 2019 11:56:54 +0000 (13:56 +0200)]
Add missing definitions for libnetsnmpagent
Pavel Rochnyack [Wed, 15 May 2019 07:33:02 +0000 (14:33 +0700)]
dns plugin: Do not use headers from glibc
glibc has removed __NAMESER and __BIND symbols from their codebase.
There is no benefits of use defines from glibc, so replaced them by numbers.
Closes: #3145
(cherry picked from commit
faa20ef796abc91656c5c583970db9a9f4daf911)
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Tue, 2 Jul 2019 09:05:02 +0000 (11:05 +0200)]
Fix return code introduced by #3182
Change-Id: I0972f74f3fff05cf29fa9b0be383f0b0df1e6d03
Fixes: #3200
(cherry picked from commit
835a58c09ff7afd44627915c9274b16c5df0fb50)
Dagobert Michelsen [Mon, 1 Jul 2019 12:21:39 +0000 (14:21 +0200)]
Use pid_test only when compiling the plugin that uses it
(cherry picked from commit
a7401cc81d05bf4f230aaf35e4109a23b60fc546)
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Mon, 24 Jun 2019 08:37:40 +0000 (10:37 +0200)]
clang-format
(cherry picked from commit
4af2afc84a90fe37e4988fca08ea79a6343c6b94)
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Fri, 28 Jun 2019 09:01:33 +0000 (11:01 +0200)]
better user feedback
Change-Id: Iae7c3208024372485fd0901898cbe2e178610082
(cherry picked from commit
d75591c9762f93d8656846fd2796fdb775b1c69f)
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Wed, 19 Jun 2019 08:32:11 +0000 (10:32 +0200)]
Fix return value or loglevel for several plugins
Some plugins' RC was != 0 and started to fail due to
stricter verification introduced by
3b9c7b2.
This commit fixes those return values.
For some plugins, fix verbosity of error message: non-zero rc
should be error, not warning.
Change-Id: I9a3f1f80e266858b6744fd9d9d99b352b8d94306
Change-Id: Ibf6ebc6cdc93c6e105d488e4a131dcb6e8eea19b
Change-Id: I35bac15fa0a89b068575739ac1cff0115c9d3a40
s
Change-Id: I992002c56763fbdea5347e5b6e176cc86f5a08ce
(cherry picked from commit
a07f44c9cd5828a84545dcfe22544bfed2ea8812)
Dagobert Michelsen [Fri, 28 Jun 2019 08:55:16 +0000 (10:55 +0200)]
Use GCC-specific flags only when compiling with GCC
(cherry picked from commit
9317d0734808f56a5d181ff2864332705fcb87e0)
Dagobert Michelsen [Thu, 27 Jun 2019 14:51:06 +0000 (16:51 +0200)]
Make sure files in this changeset are formatted properly
(cherry picked from commit
9315ccb08ebd29f0b79426853c2e7adf448c26e9)
Dagobert Michelsen [Thu, 27 Jun 2019 12:08:30 +0000 (14:08 +0200)]
Add standard include early or _FILE_OFFSET_BITS will have definition mismatches on Solaris
(cherry picked from commit
54d4f889eb72249824ef4ee6b155b0e0fb858be2)
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Wed, 19 Jun 2019 08:34:25 +0000 (10:34 +0200)]
be more verbose when plugin config cb is failing
3b9c7b2 introduced stricter RC check.
This commit provides user feedback when config callback is failing.
Change-Id: Ia9c13048e95559b5be84477fc1602ff418a1df37
(cherry picked from commit
42a30efe33c4d16276589e0dd1f9e135b38e054d)
Takuro Ashie [Tue, 18 Jun 2019 06:54:51 +0000 (15:54 +0900)]
regex match: Fix unexpected match with empty meta data
If a user set
MetaData "foo" "bar"
and a metric does not have meta data (vl->meta == NULL), it causes
unexpected match.
Existance of MetaData config should be checked before meta data in
a metric.
See also: #1930
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
(cherry picked from commit
d4f53887527777296b0982af60f4c0fecdb2f0d9)
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Mon, 17 Jun 2019 11:26:11 +0000 (13:26 +0200)]
fix comment
Change-Id: I655dd0b3cb82053f7cc50dec149d4f7cc25ee18b
(cherry picked from commit
2d485cf961eb65d4a55c5c64aa40fdbcca8f41f1)
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Mon, 17 Jun 2019 11:06:45 +0000 (13:06 +0200)]
fix deps
Change-Id: I8199655fcd22082a2f3cfb0e5ab7db289df1a5e7
(cherry picked from commit
9e5b363dda7306b628c1bf91c349ed51f11dbae6)
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Mon, 17 Jun 2019 07:14:13 +0000 (09:14 +0200)]
New upstream plugins
* nvidia_gpu
* write_stackdriver
* pcie_errors
The first 2 are disabled, as I don't know what lib they require
(configure fails)
Change-Id: I56456b418edd3defb3c5620a5ad58f527951309c
(cherry picked from commit
09abfaaeb71957c6039387ad3f5d82803c14ddda)
Pavel Rochnyak [Tue, 2 Jul 2019 09:23:47 +0000 (16:23 +0700)]
Merge pull request #3201 from ccin2p3/f/fix-syslog-rc
Fix return code introduced by #3182
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Tue, 2 Jul 2019 09:05:02 +0000 (11:05 +0200)]
Fix return code introduced by #3182
Change-Id: I0972f74f3fff05cf29fa9b0be383f0b0df1e6d03
Fixes: #3200
Pavel Rochnyak [Tue, 2 Jul 2019 04:27:11 +0000 (11:27 +0700)]
Merge pull request #3197 from dago/pid_test
Use test_utils_proc_pids only when compiling the plugin that uses it
Dagobert Michelsen [Mon, 1 Jul 2019 12:21:39 +0000 (14:21 +0200)]
Use pid_test only when compiling the plugin that uses it
Matthias Runge [Mon, 1 Jul 2019 07:25:33 +0000 (09:25 +0200)]
Merge pull request #2725 from RafaelMarinheiro/fix_grpc_query_values
utils_cache: fix pointer reference and meta_data ingestion
Pavel Rochnyak [Sat, 29 Jun 2019 08:17:11 +0000 (15:17 +0700)]
Merge pull request #3178 from ashie/fix-match-regex-for-empty-meta
regex match: Fix unexpected match with empty meta data
Pavel Rochnyak [Fri, 28 Jun 2019 10:57:34 +0000 (17:57 +0700)]
Merge pull request #3195 from dago/gccflags
Use GCC-specific flags only when compiling with GCC
Matthias Runge [Fri, 28 Jun 2019 10:31:16 +0000 (12:31 +0200)]
Merge pull request #3160 from rpv-tomsk/collectd-uptime-memcached
memcached plugin: Report uptime metric
collectd bot [Fri, 28 Jun 2019 10:17:47 +0000 (12:17 +0200)]
Auto-Merge pull request #3193 from dago/fileoffsetbits
Automatically merged due to "Automerge" label
Matthias Runge [Fri, 28 Jun 2019 10:05:32 +0000 (12:05 +0200)]
Merge pull request #3156 from rpv-tomsk/dns
dns plugin: Do not use headers from glibc
Matthias Runge [Fri, 28 Jun 2019 09:39:38 +0000 (11:39 +0200)]
Merge pull request #3182 from ccin2p3/f/config-return-codes
Fix return value or loglevel for several plugins
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Mon, 24 Jun 2019 08:37:40 +0000 (10:37 +0200)]
clang-format
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Fri, 28 Jun 2019 09:01:33 +0000 (11:01 +0200)]
better user feedback
Change-Id: Iae7c3208024372485fd0901898cbe2e178610082
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Wed, 19 Jun 2019 08:32:11 +0000 (10:32 +0200)]
Fix return value or loglevel for several plugins
Some plugins' RC was != 0 and started to fail due to
stricter verification introduced by
3b9c7b2.
This commit fixes those return values.
For some plugins, fix verbosity of error message: non-zero rc
should be error, not warning.
Change-Id: I9a3f1f80e266858b6744fd9d9d99b352b8d94306
Change-Id: Ibf6ebc6cdc93c6e105d488e4a131dcb6e8eea19b
Change-Id: I35bac15fa0a89b068575739ac1cff0115c9d3a40
s
Change-Id: I992002c56763fbdea5347e5b6e176cc86f5a08ce
Dagobert Michelsen [Fri, 28 Jun 2019 08:55:16 +0000 (10:55 +0200)]
Use GCC-specific flags only when compiling with GCC
Dagobert Michelsen [Thu, 27 Jun 2019 14:51:06 +0000 (16:51 +0200)]
Make sure files in this changeset are formatted properly
Dagobert Michelsen [Thu, 27 Jun 2019 12:08:30 +0000 (14:08 +0200)]
Add standard include early or _FILE_OFFSET_BITS will have definition mismatches on Solaris
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Wed, 19 Jun 2019 08:34:25 +0000 (10:34 +0200)]
be more verbose when plugin config cb is failing
3b9c7b2 introduced stricter RC check.
This commit provides user feedback when config callback is failing.
Change-Id: Ia9c13048e95559b5be84477fc1602ff418a1df37
Andrew Bays [Tue, 18 Jun 2019 16:53:06 +0000 (12:53 -0400)]
Align with new util library locations
Andrew Bays [Tue, 18 Jun 2019 16:29:47 +0000 (12:29 -0400)]
clang formatting
Andrew Bays [Tue, 18 Jun 2019 16:29:03 +0000 (12:29 -0400)]
Align with new util library locations
Matthias Runge [Tue, 18 Jun 2019 09:29:25 +0000 (11:29 +0200)]
Merge pull request #3175 from ccin2p3/f/collectd-redhat-spec-5.9.0
redhat spec: fix build due to new upstream plugins
Takuro Ashie [Tue, 18 Jun 2019 06:54:51 +0000 (15:54 +0900)]
regex match: Fix unexpected match with empty meta data
If a user set
MetaData "foo" "bar"
and a metric does not have meta data (vl->meta == NULL), it causes
unexpected match.
Existance of MetaData config should be checked before meta data in
a metric.
See also: #1930
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Andrew Bays [Mon, 17 Jun 2019 11:51:42 +0000 (07:51 -0400)]
Cast cdtime_t to unsigned long long when necessary
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Mon, 17 Jun 2019 11:26:11 +0000 (13:26 +0200)]
fix comment
Change-Id: I655dd0b3cb82053f7cc50dec149d4f7cc25ee18b
Andrew Bays [Mon, 17 Jun 2019 11:23:14 +0000 (07:23 -0400)]
Attempt to align with new util library locations
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Mon, 17 Jun 2019 11:06:45 +0000 (13:06 +0200)]
fix deps
Change-Id: I8199655fcd22082a2f3cfb0e5ab7db289df1a5e7
Fᴀʙɪᴇɴ Wᴇʀɴʟɪ [Mon, 17 Jun 2019 07:14:13 +0000 (09:14 +0200)]
New upstream plugins
* nvidia_gpu
* write_stackdriver
* pcie_errors
The first 2 are disabled, as I don't know what lib they require
(configure fails)
Change-Id: I56456b418edd3defb3c5620a5ad58f527951309c
Andrew Bays [Fri, 14 Jun 2019 17:03:04 +0000 (13:03 -0400)]
clang formatting, again
Andrew Bays [Fri, 14 Jun 2019 17:01:59 +0000 (13:01 -0400)]
Bump CI for connectivity plugin
Florian Forster [Thu, 13 Jun 2019 10:20:20 +0000 (12:20 +0200)]
ChangeLog: s/Foster/Forster/
Florian Forster [Thu, 13 Jun 2019 09:32:39 +0000 (11:32 +0200)]
Bump version to 5.9.0; Update ChangeLog.
Pavel Rochnyak [Fri, 7 Jun 2019 15:56:21 +0000 (22:56 +0700)]
Merge pull request #3170 from stratakis/py38
Add Python 3.8 compatibility
Charalampos Stratakis [Fri, 7 Jun 2019 14:43:56 +0000 (16:43 +0200)]
Add Python 3.8 compatibility
From Python 3.8 and onwards C extensions are no longer
linked to libpython so in order to embed python within
an application the --embed flag needs to be added to
python3-config --libs. A fall back is provided as the
command will error out on previous python versions.
References: https://bugs.python.org/issue36721
Pavel Rochnyak [Tue, 4 Jun 2019 03:23:49 +0000 (10:23 +0700)]
Merge pull request #3167 from ashie/remove-needless-tab
Makefile.am: Remove a needless tab
Takuro Ashie [Tue, 4 Jun 2019 00:43:31 +0000 (09:43 +0900)]
Makefile.am: Remove a needless tab
Matthias Runge [Mon, 3 Jun 2019 08:17:20 +0000 (10:17 +0200)]
Merge pull request #3163 from rpv-tomsk/virt-1
virt plugin: improvements
Zebity Spring [Mon, 3 Jun 2019 06:45:04 +0000 (16:45 +1000)]
Merge remote-tracking branch 'upstream/master'
Pavel Rochnyack [Wed, 29 May 2019 16:02:41 +0000 (23:02 +0700)]
virt plugin: Use virGetLastError() instead of virConnGetLastError()
libvirt documentation explicitly points us to use virGetLastError():
In a multi-threaded application, always use the global
virGetLastError() API which is backed by thread local storage.
Pavel Rochnyack [Wed, 29 May 2019 15:45:03 +0000 (22:45 +0700)]
virt plugin: minor updates after review
Pavel Rochnyak [Tue, 28 May 2019 09:35:18 +0000 (16:35 +0700)]
Merge pull request #3158 from smortex/riemann-meta-data
Copy MetaData to Riemann events in write_riemann
Pavel Rochnyack [Fri, 24 May 2019 10:56:27 +0000 (17:56 +0700)]
virt plugin: Added connection state check via virConnectIsAlive()
Before this fix, if libvirt daemon was stopped, Collectd starts to spam logs with lot of "failed" messages.
With this fix it correctly re-establishes connection.
Pavel Rochnyack [Fri, 24 May 2019 10:48:18 +0000 (17:48 +0700)]
virt plugin: Added timeout to event_loop thread
As per virEventRunDefaultImpl() documentation, this function will block
forever if there are no registered event handlers.
This leads to Collectd is unable to correctly stop event_loop thread
if libvirtd was restarted.
Added empty timeout callback to fix this.
Pavel Rochnyack [Thu, 23 May 2019 20:46:26 +0000 (03:46 +0700)]
virt plugin: Disable ExtraStats selectors when unsupported by libvirt
When function is not supported by driver, log filled by continuous messages like:
libvirt: Domain Config error : this function is not supported by the connection driver: virDomainGetDiskErrors
libvirt API allows us to detect such cases and disable unsupported calls.
Pavel Rochnyack [Thu, 23 May 2019 19:42:52 +0000 (02:42 +0700)]
virt plugin: Fixed typos and inconsistencies
Pavel Rochnyack [Thu, 23 May 2019 21:16:47 +0000 (04:16 +0700)]
virt plugin: Do not request cpu maps when not required
Pavel Rochnyack [Thu, 23 May 2019 21:10:12 +0000 (04:10 +0700)]
virt plugin: Added ExtraStats selector 'vcpu'
This allows to disable virDomainGetVcpus calls when hypervisor/driver
does not supports that function.
Closes: #2615
Pavel Rochnyack [Thu, 23 May 2019 19:37:53 +0000 (02:37 +0700)]
virt plugin: Added ExtraStats selector 'memory'
This allows to disable virDomainMemoryStats calls when hypervisor/drivers
does not supports that function or it does not provide additional details.
Pavel Rochnyack [Sun, 19 May 2019 10:27:23 +0000 (17:27 +0700)]
check_uptime: New plugin, based on new cache_event callback.
Plugin checks for cache events for uptime metric, and send notifications
when metric state changed.
Pavel Rochnyack [Sun, 19 May 2019 17:30:32 +0000 (00:30 +0700)]
memcached plugin: Report uptime metric
Issue: #2852
Pavel Rochnyak [Sun, 19 May 2019 11:31:45 +0000 (18:31 +0700)]
Merge pull request #3125 from skob/master
mysql: [impr] enable uptime metric
Pavel Rochnyack [Sun, 19 May 2019 11:19:48 +0000 (18:19 +0700)]
mysql: [impr] enable uptime metric
Romain Tartière [Fri, 17 May 2019 18:43:25 +0000 (08:43 -1000)]
Copy MetaData to Riemann events
Make it possible to capture information using filters in collectd and
use this information in Riemann for deciding what to do with the event.
ChangeLog: write_riemann plugin: MetaData is copied to Riemann events
Zebity Spring [Thu, 16 May 2019 15:59:58 +0000 (01:59 +1000)]
Run all changed files 68 8.c/1*.h through format.sh web util
Zebity Spring [Thu, 16 May 2019 14:26:35 +0000 (00:26 +1000)]
Run all changed files 68 8.c/1 *.h through clang-format agin..
Zebity Spring [Thu, 16 May 2019 13:56:25 +0000 (23:56 +1000)]
Run all changed files 68 8.c/1*.h through clang-format
Zebity Spring [Thu, 16 May 2019 12:24:51 +0000 (22:24 +1000)]
Merge remote-tracking branch 'upstream/master'
Pavel Rochnyack [Wed, 15 May 2019 07:33:02 +0000 (14:33 +0700)]
dns plugin: Do not use headers from glibc
glibc has removed __NAMESER and __BIND symbols from their codebase.
There is no benefits of use defines from glibc, so replaced them by numbers.
Closes: #3145
Pavel Rochnyak [Wed, 15 May 2019 03:28:20 +0000 (10:28 +0700)]
Merge pull request #2986 from shastah/feature/curl-address-family
curl plugin: add AddressFamily